15.0 stock picking on hold #2608
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing because of another module "sale_order_discount_invoicing", for which tests are failing |
alihashaam
force-pushed
the
15.0-stock_picking_on_hold
branch
from
f805485
to
25f135e
Compare
|
@alihashaam Thanks for this. IMHO, this has same functionality as https://github.com/OCA/sale-workflow/tree/15.0/sale_stock_picking_blocking As done in v16, the blocking reason is now computed stored. So, your module could depends on invoice_status field, then, assign the blocking reason. https://github.com/OCA/sale-workflow/blob/16.0/sale_stock_picking_blocking/models/sale_order.py#L33 What do you think ? |
|
@rousseldenis Thank you for the suggestion, it makes sense to base this module on |
ortlam
force-pushed
the
15.0-stock_picking_on_hold
branch
from
d2c4c85
to
5d3806a
Compare
|
I don't think that test failure is related to this module stock_picking_on_hold. |
ortlam
force-pushed
the
15.0-stock_picking_on_hold
branch
from
5d3806a
to
40e579c
Compare
ortlam
force-pushed
the
15.0-stock_picking_on_hold
branch
from
40e579c
to
cc331f8
Compare
[15.0][upd] conditional readonly added to hold_picking_until_payment [15.0][upd] hold_picking_until_payment set to true by default [15.0][IMP] Base stock_picking_on_hold on sale_stock_picking_blocking
ortlam
force-pushed
the
15.0-stock_picking_on_hold
branch
from
cc331f8
to
dc74d44
Compare
ortlam
force-pushed
the
15.0-stock_picking_on_hold
branch
from
c8fcad5
to
e03106f
Compare
[FIX] Don't block sale orders with website_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.