[15.0][FIX] sale_planner_calendar: Recurrent events not removed when changing the recurrence from the planner #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosRoca13
changed the title
| def _rewrite_recurrence(self, values, time_values, recurrence_values): | ||
| """Remove key from context when this method is executed to avoid loose | ||
| information when accesing calendar_event_ids of the recurrence_id. | ||
| """ |
There was a problem hiding this comment.
Set ctx before condition to avoid "local variable 'ctx' referenced before assignment" error
…ng the recurrence from the planner By doing this change we avoid avoid loose information when accesing calendar_event_ids of the recurrence_id.
CarlosRoca13
force-pushed
the
15.0-IMP-sale_planner_calendar
branch
from
f728e4b
to
7a9ddd0
Compare
sergio-teruel
approved these changes
Aug 30, 2023
carlosdauden
approved these changes
Aug 30, 2023
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at efc8a2c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT44306
ping @sergio-teruel @carlosdauden