[16.0][MIG] sale_resource_booking: Migration to 16.0

[norlinhenrik]

No description provided.

[rrebollo]

@norlinhenrik me over here to. In my doodba local environment no tests are failling this same branch. Is there any way to trigger checks again???

[rrebollo]

@jguenat @stefan-tecnativa @norlinhenrik I can´t see failling tests. I even didn´t find any when running in my local doodba. Could anyone trigger tests again?

[norlinhenrik]

I think OCA cannot successfully test sale_resource_booking until resource_booking is merged. But you can do it on your local computer with these parameters:
--test-enable --test-tags=/sale_resource_booking --stop-after-init (optional)

[rrebollo]

@norlinhenrik I'm considering to make an small improvement: trigger an onchange to auto select first product when booking type is selected. Why? I was testing to create a quote directly from booking, an error raises, looking at the trace I figure out it's because I forgot to select product. What do U think? Is there any convention against "onchanges"? Anyway we need to prevent quote action from calling if no product is selected? Which path would U suggest??

[norlinhenrik]

"onchange to auto select first product" is good if there is only one product available. If there are many products available, I think it is better to select the product manually.

"prevent quote action from calling if no product is selected" is also good to implement.

[rrebollo]

"onchange to auto select first product" is good if there is only one product available. If there are many products available, I think it is better to select the product manually.

"prevent quote action from calling if no product is selected" is also good to implement.

Last two commits here to implement mentioned improvements https://github.com/BinhexSystemss/sale-workflow/tree/16.0-dev. Could U merge it???

[rrebollo]

Sale order isn't been "reload" after booking confirmation wizard closes. U need to manually reload browser tab to see the state changed to confirmed. It doesn't matter which button U click on wizard.

I did some digging so I think the root cause it's maybe in web_ir_actions_act_multi.
By our part the problem lies here:

https://github.com/ows-cloud/sale-workflow/blob/d68949ea1212ed5c458a1adb61930fce34c9adb3/sale_resource_booking/models/sale_order.py#L48-L66

    def action_confirm(self):
        """Ask to fill booking values, if necessary."""
        result = super().action_confirm()
        try:
            # Only open wizard if doing this from a single record with bookings
            if len(self) > 1 or not self.resource_booking_ids:
                return result
        except exceptions.AccessError:
            # User without access to resource.booking; no confirm wizard
            return result
        # Support chained actions, like when event_sale is installed
        action = self.env["ir.actions.act_window"]._for_xml_id(
            "sale_resource_booking.sale_order_booking_confirm_action"
        )
        action["context"] = {"default_order_id": self.id}
        actions = [action]
        if isinstance(result, dict):
            actions.insert(0, result)
        return {"type": "ir.actions.act_multi", "actions": actions}

Following web_ir_actions_act_multi README instructions I tried to just add reload action client to actions list but then tab is reloaded and wizard got never called. As a temporal (and awful) workaround I'm just directly returning reload action client from both wizard 's buttons actions. Any thougths @norlinhenrik @pedrobaeza?

[norlinhenrik]

@rrebollo I made a commit with a workaround similar to what you described. This is how it will be then after CONFIRM.

[augustodinizl]

typo error

[augustodinizl]

i think that the correct field here, is partner_ids

[norlinhenrik]

Done

[norlinhenrik]

@rrebollo @augustodinizl Are you ready to approve, or do you see more things to do first?

[augustodinizl]

LGTM

[norlinhenrik]

I have squahed my commits now, and I think it is ready to merge.

[pedrobaeza]

CI seems to be red. Can you check?

[rrebollo]

CI seems to be red. Can you check?

Hi, it looks none of the failing tests are linked to sale_resource_booking, maybe re triggering?

[pedrobaeza]

Try to rebase to see

[norlinhenrik]

I have rebased now.

First failing check: sale_resource_booking is installed in lines 515-559.
The test fails at line 924. Bottom: psycopg2.errors.SerializationFailure: could not serialize access due to concurrent update

sale.order.line
In the last push, resource_booking_id is renamed to "Resource Booking" (singular).
Still the log complains about 2 fields named "Resource Bookings" (plural)...