Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][9.0] Add sale_automatic_workflow_payment_mode #297

Merged
merged 5 commits into from
Aug 23, 2016

Conversation

guewen
Copy link
Member

@guewen guewen commented May 3, 2016

Glue module between sale_automatic_workflow and account_payment_sale

Depends on #291 and OCA/bank-payment#270

@coveralls
Copy link

coveralls commented May 3, 2016

Coverage Status

Coverage remained the same at 75.652% when pulling 37b2744 on guewen:add-sale_automatic_workflow_payment_mode into d368776 on OCA:9.0.

@sebastienbeau
Copy link
Member

👍 Great we finaly converge ! code review ok

@atchuthan
Copy link
Member

code reviewed 👍

@coveralls
Copy link

coveralls commented May 31, 2016

Coverage Status

Coverage remained the same at 75.652% when pulling 95a002f on guewen:add-sale_automatic_workflow_payment_mode into 7fa8bb5 on OCA:9.0.

@florian-dacosta
Copy link
Contributor

code review 👍

@atchuthan
Copy link
Member

atchuthan commented Jul 26, 2016

@guewen As OCA/bank-payment#270 is already merged, I tried rebuilding the runbot, but it seems to be failing due to missing bank-payment in oca_dependencies.txt.

@atchuthan
Copy link
Member

@guewen sale_automatic_workflow is not in the working branch of this PR(https://github.com/guewen/sale-workflow/tree/add-sale_automatic_workflow_payment_mode), thus failing to find the module on runbot test.

Log from ci/runbot test:
2016-07-25 13:23:28 INFO runbot odoo.runbot:0 init Init build environment
2016-07-25 13:23:57 INFO runbot odoo.runbot:0 test_base Start test base module
2016-07-25 13:24:15 ERROR server openerp.modules.graph:114 add_modules module sale_automatic_workflow_payment_mode: Unmet dependencies: sale_automatic_workflow, account_payment_sale
2016-07-25 13:41:32 WARNING server openerp.modules.graph:118 add_modules Some modules were not loaded.
2016-07-25 13:40:45 INFO runbot odoo.runbot:0 run Start running build 3151072-297-95a002

@atchuthan
Copy link
Member

@guewen: any comment about the last 2 discussions/comments.

guewen and others added 4 commits August 16, 2016 11:03
Glue module between sale_automatic_workflow and account_payment_sale
Either at initialization of the addon or if the filter is deleted
@guewen guewen force-pushed the add-sale_automatic_workflow_payment_mode branch from 95a002f to 5bb8c95 Compare August 16, 2016 09:03
@guewen
Copy link
Member Author

guewen commented Aug 16, 2016

@atchuthan I rebased

needed for sale_automatic_workflow_payment_mode
@guewen
Copy link
Member Author

guewen commented Aug 16, 2016

Added a dependency on the repository oca/bank-payment

@parthivgls
Copy link

👍 can we move ahead with this PR ? as it's blocking OCA/connector-ecommerce#32

# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)

{'name': 'Sale Automatic Workflow - Payment Mode',
'version': '9.0.2.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 9.0.2.0.0?

@pedrobaeza
Copy link
Member

OK, we can move on with this although the version seems a bit strange, but it's not a blocker.

@pedrobaeza pedrobaeza merged commit db5418b into OCA:9.0 Aug 23, 2016
hugosantosred pushed a commit to factorlibre/sale-workflow that referenced this pull request Feb 9, 2018
[ADD] sale_automatic_workflow_payment_mode
hugosantosred pushed a commit to factorlibre/sale-workflow that referenced this pull request Feb 26, 2018
[ADD] sale_automatic_workflow_payment_mode
captivea-dcr pushed a commit to captivea-dcr/sale-workflow that referenced this pull request Jul 7, 2020
[ADD] sale_automatic_workflow_payment_mode
ThomasBinsfeld pushed a commit to acsone/sale-workflow that referenced this pull request Oct 9, 2020
[ADD] sale_automatic_workflow_payment_mode
ThomasBinsfeld pushed a commit to acsone/sale-workflow that referenced this pull request Oct 22, 2020
[ADD] sale_automatic_workflow_payment_mode
ThomasBinsfeld pushed a commit to acsone/sale-workflow that referenced this pull request Oct 30, 2020
[ADD] sale_automatic_workflow_payment_mode
PCatinean pushed a commit to PCatinean/sale-workflow that referenced this pull request Feb 2, 2021
[ADD] sale_automatic_workflow_payment_mode
danielduqma pushed a commit to factorlibre/sale-workflow that referenced this pull request Feb 9, 2021
[ADD] sale_automatic_workflow_payment_mode
bizzappdev pushed a commit to bizzappdev/sale-workflow that referenced this pull request Feb 21, 2021
[ADD] sale_automatic_workflow_payment_mode
hailangvn pushed a commit to hailangvn/sale-workflow that referenced this pull request May 15, 2021
[ADD] sale_automatic_workflow_payment_mode
hailangvn pushed a commit to hailangvn/sale-workflow that referenced this pull request May 16, 2021
[ADD] sale_automatic_workflow_payment_mode
victoralmau pushed a commit to Tecnativa/sale-workflow that referenced this pull request Jul 27, 2021
[ADD] sale_automatic_workflow_payment_mode
victoralmau pushed a commit to Tecnativa/sale-workflow that referenced this pull request Jul 27, 2021
[ADD] sale_automatic_workflow_payment_mode
victoralmau pushed a commit to Tecnativa/sale-workflow that referenced this pull request Aug 31, 2021
[ADD] sale_automatic_workflow_payment_mode
victoralmau pushed a commit to Tecnativa/sale-workflow that referenced this pull request Sep 13, 2021
[ADD] sale_automatic_workflow_payment_mode
victoralmau pushed a commit to Tecnativa/sale-workflow that referenced this pull request Sep 14, 2021
[ADD] sale_automatic_workflow_payment_mode
chouab pushed a commit to chouab/sale-workflow that referenced this pull request Nov 3, 2021
[ADD] sale_automatic_workflow_payment_mode
jaredkipe pushed a commit to hibou-io/oca-sale-workflow that referenced this pull request Dec 15, 2021
[ADD] sale_automatic_workflow_payment_mode
JordiBForgeFlow pushed a commit to ForgeFlow/sale-workflow that referenced this pull request Dec 30, 2021
[ADD] sale_automatic_workflow_payment_mode
flachica pushed a commit to flachica/sale-workflow that referenced this pull request May 6, 2022
[ADD] sale_automatic_workflow_payment_mode
flachica pushed a commit to flachica/sale-workflow that referenced this pull request Aug 13, 2022
[ADD] sale_automatic_workflow_payment_mode
flachica pushed a commit to flachica/sale-workflow that referenced this pull request Aug 17, 2022
[ADD] sale_automatic_workflow_payment_mode
flachica pushed a commit to flachica/sale-workflow that referenced this pull request Oct 18, 2022
[ADD] sale_automatic_workflow_payment_mode
flachica pushed a commit to flachica/sale-workflow that referenced this pull request Dec 21, 2022
[ADD] sale_automatic_workflow_payment_mode
florian-dacosta pushed a commit to akretion/sale-workflow that referenced this pull request Dec 30, 2022
[ADD] sale_automatic_workflow_payment_mode
florian-dacosta pushed a commit to akretion/sale-workflow that referenced this pull request Jan 31, 2023
[ADD] sale_automatic_workflow_payment_mode
pilarvargas-tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request Feb 7, 2023
[ADD] sale_automatic_workflow_payment_mode
sergio-teruel pushed a commit to Tecnativa/sale-workflow that referenced this pull request Feb 13, 2023
[ADD] sale_automatic_workflow_payment_mode
sonhd91 pushed a commit to sonhd91/sale-workflow that referenced this pull request Mar 30, 2023
[ADD] sale_automatic_workflow_payment_mode
john-herholz-dt pushed a commit to DeineTuer-GmbH/OCA_sale-workflow that referenced this pull request Jan 11, 2024
[ADD] sale_automatic_workflow_payment_mode
john-herholz-dt pushed a commit to DeineTuer-GmbH/OCA_sale-workflow that referenced this pull request Jul 14, 2024
[ADD] sale_automatic_workflow_payment_mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants