-
-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][9.0] Add sale_automatic_workflow_payment_mode #297
[WIP][9.0] Add sale_automatic_workflow_payment_mode #297
Conversation
👍 Great we finaly converge ! code review ok |
code reviewed 👍 |
2be1ea0
to
329076b
Compare
code review 👍 |
@guewen As OCA/bank-payment#270 is already merged, I tried rebuilding the runbot, but it seems to be failing due to missing bank-payment in oca_dependencies.txt. |
@guewen sale_automatic_workflow is not in the working branch of this PR(https://github.com/guewen/sale-workflow/tree/add-sale_automatic_workflow_payment_mode), thus failing to find the module on runbot test. Log from ci/runbot test: |
@guewen: any comment about the last 2 discussions/comments. |
Glue module between sale_automatic_workflow and account_payment_sale
Either at initialization of the addon or if the filter is deleted
95a002f
to
5bb8c95
Compare
@atchuthan I rebased |
needed for sale_automatic_workflow_payment_mode
Added a dependency on the repository oca/bank-payment |
👍 can we move ahead with this PR ? as it's blocking OCA/connector-ecommerce#32 |
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html) | ||
|
||
{'name': 'Sale Automatic Workflow - Payment Mode', | ||
'version': '9.0.2.0.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 9.0.2.0.0?
OK, we can move on with this although the version seems a bit strange, but it's not a blocker. |
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
[ADD] sale_automatic_workflow_payment_mode
Glue module between sale_automatic_workflow and account_payment_sale
Depends on #291 and OCA/bank-payment#270