[17.0][FIX] sale_fixed_discount: SOL discount propagation to invoice line #3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimGlimmerveen-360ERP
approved these changes
May 27, 2024
|
Can this one be merged? |
astirpe
force-pushed
the
17_fix_sale_fixed_discount
branch
from
fe0bfd9
to
c73fbd4
Compare
rousseldenis
approved these changes
Jun 24, 2024
|
/ocabot merge major |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 264a80d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
when creating or editing a sale order line by using the UI, the
_onchange_discount_fixed()ensures that thediscountfield is computed based on the value ofdiscount_fixedandprice_unitfields. Keeping thediscountupdated is important because this value will be propagated to the invoice line at the moment the invoice is generated.Description of the issue:
The onchange method is not triggered in case we create or modify the sale order line by using an API (and so without using the UI) or when we update
discount_fixedandprice_unitfield in custom code.This means that the wrong
discountvalue (that stays0.0) will be propagated to the invoice line at the moment the invoice is generated.Proposed fix:
with this PR the onchange method is replaced by extending the
_compute_discount()method, ensuring that thediscountfield is consistent withdiscount_fixed