[17.0][MIG] sale_order_product_recommendation: Migration to 17.0 #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeer2234
force-pushed
the
17.0-mig-sale_order_product_recommendation
branch
from
6e26886
to
0f87a76
Compare
|
Sorry @jeer2234 you are not allowed to mark the addon tobe migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
dreispt
approved these changes
Jul 24, 2024
|
/ocabot migration sale_order_product_recommendation |
dreispt
requested changes
Aug 20, 2024
There was a problem hiding this comment.
There is a problem with the [IMP] sale_order_product_recommendation: pre-commit auto fixes commit - the diff touches a few other modules, and should only make changes to the module being migrated.
jeer2234
force-pushed
the
17.0-mig-sale_order_product_recommendation
branch
from
0f87a76
to
ea26bb3
Compare
|
/ocabot rebase |
This wizard that you can see now in your quotations will let you add products quickly based on the customer's recent purchase history.
We can't limit results on read_group, because we can't set the same criteria to order results, and thus the N groups populated might be not the top ones looked for.
- When a SO is confirmed the button is still visible so the wizard can be used to add or remove lines and products. The same restrictions that exist editing the order manually apply to the wizard.
Using force_save option in views
- Improve test declaration inherability
…ok products in recommendation wizard BTW I fixed a bug that counted products in the active SO as delivered, when it was impossible in most cases. Fixed the test to reflect the new logic. Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>
Add kanban + form for proper mobile usage.
…fied` It's better to simply check the flag condition than to keep that field.
…t to product default one Having a related field to default sale secondary UoM makes this recommendator to not fit possible different secondary UoM to be used. This commit fixes this behavior. A refactoring on the main module having a prepare method hook has been needed.
…hanges Previous code was not very resilient to possible extra adaptations or require specific code to be added to the old hook `_trigger_so_line_onchanges`. With this, we make sure all onchanges are executed thanks to the odoo.tests.Form class. We lose a bit of performance, but it's better than to have issues with data not correctly synchronized.
Currently translated at 100.0% (72 of 72 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/es/
Before this patch, UoM wasn't being properly inherited into generated lines when those lines didn't exist previously in the SO. Also, changing it manually didn't work as expected in that same case. This is because the UoM was related to the SOL UoM. But if there was no SOL, it did nothing. Now it's properly computed. UoM comes from the product if there's no SOL or it can't provide it. The user can change it to other UoM of the same category. The change is propagated when applying the wizard, both when creating lines and updating them. Tests added. @moduon MT-4472
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/
Currently translated at 100.0% (75 of 75 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/es/
Currently translated at 100.0% (75 of 75 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/it/
Product category was labeled as "Complete name" due to a typo in field definition, which didn't make any sense. @moduon MT-5404
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/
…gating recommendations to sale order
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/
Currently translated at 100.0% (73 of 73 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_product_recommendation/pt_BR/
|
Congratulations, PR rebased to 17.0. |
OCA-git-bot
force-pushed
the
17.0-mig-sale_order_product_recommendation
branch
from
ea26bb3
to
5f3e03b
Compare
rousseldenis
approved these changes
Aug 22, 2024
dreispt
approved these changes
Aug 22, 2024
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 2d88642. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standard Migration