Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][9.0] sale_order_type #340

Merged
merged 13 commits into from
Oct 13, 2016
Merged

[MIG][9.0] sale_order_type #340

merged 13 commits into from
Oct 13, 2016

Conversation

nicomacr
Copy link
Contributor

Migrate to v9:

  • No more order_policy on odoo v9
  • No more invoice_state on odoo v9
  • No more generate invoice from stock
  • Some light fixes

@nicomacr nicomacr mentioned this pull request Sep 23, 2016
Closed
50 tasks
@pedrobaeza
Copy link
Member

There's an improvement as PR for 8.0 that you can include: #333

@nicomacr
Copy link
Contributor Author

Is not better to wait 8.0 imps to be aprooved and later make a PR to add them to v9?

@pedrobaeza
Copy link
Member

Well, you can also help reviewing the PR to speed up the merge 😉

@StefanRijnhart
Copy link
Member

Thank you! Can you please check the Travis Errors?

@StefanRijnhart StefanRijnhart added this to the 9.0 milestone Sep 28, 2016
@eLBati
Copy link
Member

eLBati commented Oct 4, 2016

Thank you @nicomacr , could you include the last 8.0 changes of the module (#333) when applicable?

eLBati and others added 7 commits October 4, 2016 11:09
@eLBati @nicomacr
FIX sale_order_type: propagate sale type to invoice
3d6ffa7 
Conflicts:
	sale_order_type/models/sale_order.py
	sale_order_type/models/stock_picking.py
	sale_order_type/tests/test_sale_order_type.py
@eLBati @nicomacr
ADD Payment Term, Pricelist and Incoterm to sale order type
04a9448 
Conflicts:
	sale_order_type/models/sale_order.py
	sale_order_type/tests/test_sale_order_type.py
	sale_order_type/views/sale_order_type_view.xml
@eLBati @nicomacr
ADD sale type for invoices
30aee23 
Conflicts:
	sale_order_type/README.rst
	sale_order_type/models/account_invoice.py
	sale_order_type/tests/test_sale_order_type.py
@eLBati @nicomacr
IMP description
2b09c1d
@nicomacr
FIX
921e5ca
@nicomacr
FIX test case
829ff2f
@nicomacr
FIX
16df273
@eLBati
Copy link
Member

eLBati commented Oct 6, 2016

@nicomacr it seems some 8.0 changes are still missing, like c118301

Please see https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0#technical-method-to-migrate-a-module-from-80-to-90-branch

thanks

@nicomacr
ADD multicompany rule for sale.order.type and company in sale.order.t…
f8e2481 
…ype (OCA#292)

[IMP] sale_order_type: multicompany handle
Conflicts:
	sale_order_type/models/sale_order_type.py
@eLBati
Copy link
Member

eLBati commented Oct 7, 2016

Running

git diff 8.0..adhoc-dev/9.0-mig-sale_order_type sale_order_type

it seems several translations are missing

@nicomacr
Copy link
Contributor Author

These translations were added later, as I bring from the 8.0

StefanRijnhart
StefanRijnhart approved these changes Oct 12, 2016
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now!

andreschenkels
andreschenkels approved these changes Oct 13, 2016
View reviewed changes
Copy link
Member

@andreschenkels andreschenkels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done 👍

@pedrobaeza pedrobaeza merged commit 6211827 into OCA:9.0 Oct 13, 2016
@nicomacr nicomacr deleted the 9.0-mig-sale_order_type branch April 5, 2017 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@andreschenkels andreschenkels andreschenkels approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nicomacr @pedrobaeza @StefanRijnhart @eLBati @andreschenkels