sale_order_type improvements #333
Conversation
eLBati
force-pushed
the
imp_sale_order_type
branch
from
596d689
to
ed23616
Compare
|
|
||
|
|
||
| class AccountInvoice(models.Model): | ||
| _inherit = 'account.invoice' | ||
|
|
||
| sale_type_id = fields.Many2one( |
There was a problem hiding this comment.
Better to bind this to account journal instead.
There was a problem hiding this comment.
@pedrobaeza, journal contains accounting specific informations. Sale Type is more like a Line of business. That is, for the same journal, I could configure several lines of business: I should not be forced to create a journal for every line of business
|
Please only one module per PR |
eLBati
force-pushed
the
imp_sale_order_type
branch
from
1e298b2
to
72727ee
Compare
|
@pedrobaeza Thanks |
|
Please check CIs status |
eLBati
force-pushed
the
imp_sale_order_type
branch
from
72727ee
to
5f7d442
Compare
|
@pedrobaeza travis should be ok now |
|
Please rebase to fix runbot and can you check if you can improve the test coverage? |
eLBati
force-pushed
the
imp_sale_order_type
branch
from
1730897
to
26d5ddc
Compare
eLBati
force-pushed
the
imp_sale_order_type
branch
from
26d5ddc
to
1b3e822
Compare
|
@pedrobaeza thanks, done |
|
👍 |
|
Thank you, but can you describe these new features in the module's README? |
|
@StefanRijnhart description improved |
eLBati
force-pushed
the
imp_sale_order_type
branch
from
5672a04
to
10bcab4
Compare
|
LGTM 👍 |
|
👍 |
| if self.type_id.pricelist_id: | ||
| self.pricelist_id = self.type_id.pricelist_id.id | ||
| if self.type_id.incoterm_id: | ||
| self.incoterm = self.type_id.incoterm_id.id |
There was a problem hiding this comment.
This method will invoke multiple times the write method of the sale.order object (potentially this can happen up to 6 times). I believe it would be better, as also advised in the official Odoo documentation, to gather all the values that need to be updated in a dictionary and to explicitly invoke the write method once for all in the end. This for performance reasons.
There was a problem hiding this comment.
@espo-tony, I agree.
Could you please make a PR on branch 8.0?
Thank you in advance.
There was a problem hiding this comment.
@tafaRU , I'm sorry I made a mistake:
Being this method decorated with the onchange decorator, it will not trigger the write method of the object, instead all the work will be done in the cache. No performance issue in this case.
I'm sorry for wasting your time.
There was a problem hiding this comment.
@espo-tony, no problem! I also did not see the onchage decorator 😉
ADD Payment Term, Pricelist and Incoterm to sale order type
ADD sale type for invoices