[IMP] add multi-company support in module sale_exceptions + faulty de… #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault function signature
|
Hey @metaminux, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
Hey @metaminux, Appreciation of efforts, |
|
Closing this as no activity. @metaminux Please feel free to reopen it if you still need it. Take care of your PR's |
|
Yes, I'd like to reopen, as the only missing step was the merge... don't seem to be able to though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fault function signature
This commit is part of 7.0 branch for 2 years and could benefit to 8.0 too.
Not having "company_id" field in sale.exception model leads to the following error when opening or creating a sale order after migration from 7.0 to 8.0 :
ValueError: Invalid field 'company_id' in leaf "<osv.ExtendedLeaf: ('company_id', '=', False) on sale_exception (ctx: )>"