[9.0][FIX] sale_automatic_workflow: Add security groups to avoid show information always #394
Conversation
sergio-teruel
force-pushed
the
9.0-PR-sale_automatic_workflow-security-groups
branch
from
e052775
to
543534c
Compare
|
Other repo modules changes:
|
sergio-teruel
force-pushed
the
9.0-PR-sale_automatic_workflow-security-groups
branch
from
543534c
to
51b5007
Compare
|
@pedrobaeza update for base.group_user |
|
Well, I was thinking more on sales user, as employee doesn't see that objects. |
sergio-teruel
force-pushed
the
9.0-PR-sale_automatic_workflow-security-groups
branch
from
51b5007
to
aa1a7eb
Compare
| @@ -95,6 +96,7 @@ | |||
| <field name="name">sale_exception.view_order_tree</field> | |||
| <field name="model">sale.order</field> | |||
| <field name="inherit_id" ref="sale.view_order_tree"/> | |||
| <field name="groups_id" eval="[(4, ref('base.group_user'))]"/> | |||
| <field name="arch" type="xml"> | |||
There was a problem hiding this comment.
It makes more sense to me to assign this to the sale user
There was a problem hiding this comment.
Change in this commit aa1a7eb
There was a problem hiding this comment.
Well, this commit is not here in this PR...
|
@sergio-teruel please change the user to finally merge this. |
|
Ping @sergio-teruel |
|
There are still comments unattended. |
|
@pedrobaeza I changed the group in this commit aa1a7eb |
… information always. [9.0][FIX] sale_exception: Add security group to minimal sales group to avoid show information always.
…to avoid show information always.
sergio-teruel
force-pushed
the
9.0-PR-sale_automatic_workflow-security-groups
branch
from
233672b
to
978db93
Compare
|
@aheficent Fix security groups |
| @@ -69,6 +69,7 @@ | |||
| <field name="name">sale_exception.view_order_form</field> | |||
| <field name="model">sale.order</field> | |||
| <field name="inherit_id" ref="sale.view_order_form"/> | |||
| <field name="groups_id" eval="[(4, ref('base.group_sale_salesman'))]"/> | |||
There was a problem hiding this comment.
Why this one only on sales manager?
There was a problem hiding this comment.
Agh, incorrect line for commenting. It's in the above change the one that it's only on managers.
|
Travis is ❌ |
|
@sergio-teruel could we fix travis and merge this please? |
|
Problem is with So it's here on the 9.0 branch https://github.com/OCA/sale-workflow/blob/9.0/sale_automatic_workflow/models/automatic_workflow_job.py#L29 |
|
Closing as this is out of interest now |
cc @Tecnativa