-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0][FIX] sale_automatic_workflow: Add security groups to avoid show information always #394
[9.0][FIX] sale_automatic_workflow: Add security groups to avoid show information always #394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only sales manager?
e052775
to
543534c
Compare
Other repo modules changes:
|
543534c
to
51b5007
Compare
@pedrobaeza update for base.group_user |
Well, I was thinking more on sales user, as employee doesn't see that objects. |
51b5007
to
aa1a7eb
Compare
@@ -95,6 +96,7 @@ | |||
<field name="name">sale_exception.view_order_tree</field> | |||
<field name="model">sale.order</field> | |||
<field name="inherit_id" ref="sale.view_order_tree"/> | |||
<field name="groups_id" eval="[(4, ref('base.group_user'))]"/> | |||
<field name="arch" type="xml"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes more sense to me to assign this to the sale user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change in this commit aa1a7eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this commit is not here in this PR...
@sergio-teruel please change the user to finally merge this. |
Ping @sergio-teruel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a long time in production environment 👍
There are still comments unattended. |
@pedrobaeza I changed the group in this commit aa1a7eb |
… information always. [9.0][FIX] sale_exception: Add security group to minimal sales group to avoid show information always.
…to avoid show information always.
233672b
to
978db93
Compare
@aheficent Fix security groups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -69,6 +69,7 @@ | |||
<field name="name">sale_exception.view_order_form</field> | |||
<field name="model">sale.order</field> | |||
<field name="inherit_id" ref="sale.view_order_form"/> | |||
<field name="groups_id" eval="[(4, ref('base.group_sale_salesman'))]"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this one only on sales manager?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are mistaken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agh, incorrect line for commenting. It's in the above change the one that it's only on managers.
Travis is ❌ |
@sergio-teruel could we fix travis and merge this please? |
Problem is with So it's here on the 9.0 branch https://github.com/OCA/sale-workflow/blob/9.0/sale_automatic_workflow/models/automatic_workflow_job.py#L29 |
Closing as this is out of interest now |
cc @Tecnativa