12.0 mig sale order line date #703

mpanarin · 2018-10-01T15:51:28Z

Migration of the sale_order_line_date as well as adding the setup directory

[FIX] Update readme to latest template

mpanarin · 2018-10-02T07:27:32Z

Travis is red due to absence of branch 12 in odoo repo

nikul-serpentcs

Small Change

sale_order_line_date/__init__.py

tafaRU · 2018-10-02T09:12:12Z

This module cannot be tested on runbot as sale_management is not installed. I'm wondering if it's worth to add it as dependency: what do you think about it?

mpanarin · 2018-10-02T09:15:17Z

@tafaRU not sure what you mean.
The module depends only on the core Sale module

sale_order_line_date/__manifest__.py

mpanarin · 2018-10-02T09:18:31Z

@tafaRU nvm, will fix
@nikul-serpentcs

in v12 sale_management is a wrap_around app module. If it's not installed you won't see menuitems like Sale.

mpanarin · 2018-10-02T09:35:36Z

@tafaRU @nikul-serpentcs updated

nikul-serpentcs

Code Review LGTM

grindtildeath

IMO you should remove the related on sale.order.line to allow the field to be set manually on each line.

sale_order_line_date/models/sale_order_line.py

grindtildeath · 2019-03-06T16:10:12Z

sale_order_line_date/models/sale_order.py

-        result = super(SaleOrder, self).onchange_requested_date()
-        if not result:
-            result = {}
+        result = super()._onchange_commitment_date() or {}
        if not self:


Is this possible ? 🤔

grindtildeath · 2019-03-06T16:12:15Z

sale_order_line_date/models/sale_order.py

-    def onchange_requested_date(self):
+    # requested_date was renamed to commitment_date
+    @api.onchange('commitment_date')
+    def _onchange_commitment_date(self):


Is this onchange really needed since the field on sale.order.line is now related to the one on sale.order ?

sale_order_line_date/models/sale_order_line.py

grindtildeath

groups are also missing on the view

sale_order_line_date/views/sale_order_view.xml

Co-Authored-By: mpanarin <31699470+mpanarin@users.noreply.github.com>

grindtildeath · 2019-03-08T15:18:59Z

@mpanarin Just opened a PR on your branch to restore former behaviour : mpanarin#2
@lreficent @aheficent I added this check here : https://github.com/mpanarin/sale-workflow/pull/2/files#diff-f5a53ebb0e1154f5d42ec9cd83645498R21
Probably not the cleanest way to do it, but I tried to respect the legacy code as much as possible and it avoids bad side effect if the write is on lines from different sale.orders.

Restore sale.order.line commitment_date as unrelated to sale.order

sale_order_line_date/models/sale_order_line.py

to please flake8

grindtildeath

LGTM, the suggestion should fix travis issue.

grindtildeath · 2019-06-21T07:26:26Z

sale_order_line_date/models/sale_order_line.py

+
+    @api.multi
+    def write(self, vals):
+        # Force commitment date only if all the lines 


Suggested change

# Force commitment date only if all the lines

# Force commitment date only if all the lines

AaronHForgeFlow · 2019-06-21T10:48:49Z

I cannot install sale_stock on runbot 😱

Field effective_date does not exist
Error context:
View sale.order.form.sale.stock
[view_id: 900, xml_id: n/a, model: sale.order, parent_id: 666]
None" while parsing /home/odoo/OCB-12.0/addons/sale_stock/views/sale_order_views.xml:4, near

I reproduced also on local, but still trying to find out the reason.

LoisRForgeFlow · 2019-07-10T15:15:19Z

@mpanarin are you going to finish this?

mpanarin · 2019-07-11T08:31:45Z

@lreficent sorry, but I don't have the time right now. Feel free to resubmit new pr with updates, or open a pr to my fork and I will accept it.

rafaelbn

Dear @mpanarin , it looks like this PR is no working and you are not going to continue. What do you think about closing it and continue in #875 ?

Functionally tested: doesn't work, when trying to add a sale order line:

Error:
Odoo Server Error

Traceback (most recent call last):
File "/.repo_requirements/odoo/odoo/http.py", line 656, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/.repo_requirements/odoo/odoo/http.py", line 314, in _handle_exception
raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
File "/.repo_requirements/odoo/odoo/tools/pycompat.py", line 87, in reraise
raise value
File "/.repo_requirements/odoo/odoo/http.py", line 698, in dispatch
result = self._call_function(**self.params)
File "/.repo_requirements/odoo/odoo/http.py", line 346, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/.repo_requirements/odoo/odoo/service/model.py", line 97, in wrapper
return f(dbname, *args, **kwargs)
File "/.repo_requirements/odoo/odoo/http.py", line 339, in checked_call
result = self.endpoint(*a, **kw)
File "/.repo_requirements/odoo/odoo/http.py", line 941, in call
return self.method(*args, **kw)
File "/.repo_requirements/odoo/odoo/http.py", line 519, in response_wrap
response = f(*args, **kw)
File "/home/odoo/OCB-12.0/addons/web/controllers/main.py", line 962, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/home/odoo/OCB-12.0/addons/web/controllers/main.py", line 954, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/.repo_requirements/odoo/odoo/api.py", line 745, in call_kw
return _call_kw_model(method, model, args, kwargs)
File "/.repo_requirements/odoo/odoo/api.py", line 718, in _call_kw_model
result = method(recs, *args, **kwargs)
File "/.repo_requirements/odoo/odoo/models.py", line 1376, in load_views
for [v_id, v_type] in views
File "/.repo_requirements/odoo/odoo/models.py", line 1376, in
for [v_id, v_type] in views
File "/home/odoo/OCB-12.0/addons/mail/models/mail_thread.py", line 410, in fields_view_get
res = super(MailThread, self).fields_view_get(view_id=view_id, view_type=view_type, toolbar=toolbar, submenu=submenu)
File "/.repo_requirements/odoo/odoo/models.py", line 1462, in fields_view_get
xarch, xfields = View.postprocess_and_fields(self._name, etree.fromstring(result['arch']), view_id)
File "/.repo_requirements/odoo/odoo/addons/base/models/ir_ui_view.py", line 1106, in postprocess_and_fields
self.raise_view_error(message, view_id)
File "/.repo_requirements/odoo/odoo/addons/base/models/ir_ui_view.py", line 548, in raise_view_error
raise ValueError(message)
ValueError: Field property_valuation does not exist

Error context:
View n/a
[view_id: n/a, xml_id: n/a, model: n/a, parent_id: n/a]

rafaelbn · 2019-09-22T16:49:14Z

sale_order_line_date/README.rst

+|badge1| |badge2| |badge3| |badge4| |badge5| 
+
+This module adds requested date to a sales order lines and propagate it to
+stock moves and procurements.


So this module must depends in stock

rafaelbn · 2019-09-22T16:50:37Z

sale_order_line_date/__manifest__.py

+    "license": "AGPL-3",
+    # sale_order_dates became part of the sale module in 12.0
+    "depends": [
+        "sale_management",


this module should depends in stock and it doesn't

In v11 depenede in sale_order_dates https://github.com/OCA/sale-workflow/blob/11.0/sale_order_line_date/__manifest__.py#L19

V11 depends on sale_order_dates, but the commitment_date field on sale.order was moved to base sale module in V12. So no need for another dependency.
The method _prepare_procurement_values is used by sale_stock, and there needs to be a dependency or else the sale_stock values will overwrite the values from this module.

ghost · 2019-10-16T09:09:56Z

Hello everyone there! What is the state of the migration? I need the module working in version 12. Can I contribute in the PR? Thanks in advance.

LoisRForgeFlow · 2019-10-28T11:01:17Z

Hi @BT-jmolina, seems that it has been abandoned, so you can help by taking over an opening a new Pull Request finishing the job. I'll be glad to review!

LoisRForgeFlow · 2019-10-28T11:03:53Z

@BT-jmolina Actually there is another PR open, you can review and colaborate there instead: #875.

@OCA/core-maintainers this can be closed as it has been superseded by #875

MiquelRForgeFlow · 2019-11-04T20:30:42Z

Superseded by #984.

AaronHForgeFlow and others added 9 commits October 1, 2018 14:50

Update code

377499e

[FIX] Update readme to latest template

sale_order_line_date v9

c464db0

OCA Transbot updated translations from Transifex

3994b2a

[MIG] sale_order_line_date v10

58ceeec

OCA Transbot updated translations from Transifex

1a38128

[MIG] sale_order_line_date: Migration to 11.0

9df1ec6

[FIX] Function name to prepare procurement values

01a8fdd

[UPD] Update sale_order_line_date.pot

62c5fba

[MIG] 12.0 sale_order_line_date

c6512ea

mpanarin mentioned this pull request Oct 1, 2018

Migration to version 12.0 #700

Closed

54 tasks

pedrobaeza added this to the 12.0 milestone Oct 2, 2018

nikul-serpentcs reviewed Oct 2, 2018

View reviewed changes

sale_order_line_date/__init__.py Outdated Show resolved Hide resolved

nikul-serpentcs reviewed Oct 2, 2018

View reviewed changes

sale_order_line_date/__manifest__.py Outdated Show resolved Hide resolved

fixup! [MIG] 12.0 sale_order_line_date

7b4a38a

nikul-serpentcs reviewed Oct 2, 2018

View reviewed changes

grindtildeath suggested changes Mar 6, 2019

View reviewed changes

grindtildeath reviewed Mar 7, 2019

View reviewed changes

sale_order_line_date/views/sale_order_view.xml Outdated Show resolved Hide resolved

sale_order_line_date/views/sale_order_view.xml Outdated Show resolved Hide resolved

sale_order_line_date/views/sale_order_view.xml Outdated Show resolved Hide resolved

grindtildeath and others added 6 commits March 8, 2019 16:00

Update sale_order_line_date/models/sale_order_line.py

ebca600

Co-Authored-By: mpanarin <31699470+mpanarin@users.noreply.github.com>

Update sale_order_line_date/models/sale_order_line.py

d860032

Co-Authored-By: mpanarin <31699470+mpanarin@users.noreply.github.com>

Update sale_order_line_date/views/sale_order_view.xml

5bf2474

Co-Authored-By: mpanarin <31699470+mpanarin@users.noreply.github.com>

Update sale_order_line_date/views/sale_order_view.xml

c17bce1

Co-Authored-By: mpanarin <31699470+mpanarin@users.noreply.github.com>

Update sale_order_line_date/views/sale_order_view.xml

a5100b0

Co-Authored-By: mpanarin <31699470+mpanarin@users.noreply.github.com>

Restore sale.order.line commitment_date as unrelated to sale.order

243d393

Merge pull request #2 from grindtildeath/12.0_mig_sale_order_line_date

fb9be78

Restore sale.order.line commitment_date as unrelated to sale.order

gurneyalex reviewed Mar 20, 2019

View reviewed changes

sale_order_line_date/models/sale_order_line.py Outdated Show resolved Hide resolved

gurneyalex added 2 commits June 20, 2019 12:23

fix category in the manifest

43ad67f

split long line

4f2ec66

to please flake8

gurneyalex approved these changes Jun 20, 2019

View reviewed changes

gurneyalex added the needs review label Jun 20, 2019

[UPD] README.rst

c16badf

grindtildeath approved these changes Jun 21, 2019

View reviewed changes

OCA-git-bot added the approved label Jun 21, 2019

AaronHForgeFlow mentioned this pull request Jun 21, 2019

12.0 mig sale order line date #875

Closed

rafaelbn requested changes Sep 22, 2019

View reviewed changes

OCA-git-bot removed the approved label Sep 22, 2019

rafaelbn added needs fixing and removed needs review labels Sep 22, 2019

MiquelRForgeFlow mentioned this pull request Nov 4, 2019

[12.0][MIG] sale_order_line_date #984

Merged

sbidoul closed this Nov 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

12.0 mig sale order line date #703

12.0 mig sale order line date #703

mpanarin commented Oct 1, 2018

mpanarin commented Oct 2, 2018

nikul-serpentcs left a comment

tafaRU commented Oct 2, 2018

mpanarin commented Oct 2, 2018

mpanarin commented Oct 2, 2018

mpanarin commented Oct 2, 2018

nikul-serpentcs left a comment

grindtildeath left a comment

grindtildeath Mar 6, 2019

grindtildeath Mar 6, 2019

grindtildeath left a comment

grindtildeath commented Mar 8, 2019

grindtildeath left a comment

grindtildeath Jun 21, 2019

AaronHForgeFlow commented Jun 21, 2019

LoisRForgeFlow commented Jul 10, 2019

mpanarin commented Jul 11, 2019 •

edited

rafaelbn left a comment

rafaelbn Sep 22, 2019

rafaelbn Sep 22, 2019

RLeeOSI Oct 23, 2019 •

edited

ghost commented Oct 16, 2019

LoisRForgeFlow commented Oct 28, 2019

LoisRForgeFlow commented Oct 28, 2019

MiquelRForgeFlow commented Nov 4, 2019

	# Force commitment date only if all the lines
	# Force commitment date only if all the lines

12.0 mig sale order line date #703

12.0 mig sale order line date #703

Conversation

mpanarin commented Oct 1, 2018

mpanarin commented Oct 2, 2018

nikul-serpentcs left a comment

Choose a reason for hiding this comment

tafaRU commented Oct 2, 2018

mpanarin commented Oct 2, 2018

mpanarin commented Oct 2, 2018

mpanarin commented Oct 2, 2018

nikul-serpentcs left a comment

Choose a reason for hiding this comment

grindtildeath left a comment

Choose a reason for hiding this comment

grindtildeath Mar 6, 2019

Choose a reason for hiding this comment

grindtildeath Mar 6, 2019

Choose a reason for hiding this comment

grindtildeath left a comment

Choose a reason for hiding this comment

grindtildeath commented Mar 8, 2019

grindtildeath left a comment

Choose a reason for hiding this comment

grindtildeath Jun 21, 2019

Choose a reason for hiding this comment

AaronHForgeFlow commented Jun 21, 2019

LoisRForgeFlow commented Jul 10, 2019

mpanarin commented Jul 11, 2019 • edited

rafaelbn left a comment

Choose a reason for hiding this comment

rafaelbn Sep 22, 2019

Choose a reason for hiding this comment

rafaelbn Sep 22, 2019

Choose a reason for hiding this comment

RLeeOSI Oct 23, 2019 • edited

Choose a reason for hiding this comment

ghost commented Oct 16, 2019

LoisRForgeFlow commented Oct 28, 2019

LoisRForgeFlow commented Oct 28, 2019

MiquelRForgeFlow commented Nov 4, 2019

mpanarin commented Jul 11, 2019 •

edited

RLeeOSI Oct 23, 2019 •

edited