Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12.0 mig sale order line date #703
12.0 mig sale order line date #703
Changes from 10 commits
377499e
c464db0
3994b2a
58ceeec
1a38128
9df1ec6
01a8fdd
62c5fba
c6512ea
7b4a38a
ebca600
d860032
5bf2474
c17bce1
a5100b0
243d393
fb9be78
43ad67f
4f2ec66
c16badf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this module should depends in stock and it doesn't
In v11 depenede in
sale_order_dates
https://github.com/OCA/sale-workflow/blob/11.0/sale_order_line_date/__manifest__.py#L19There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V11 depends on sale_order_dates, but the commitment_date field on sale.order was moved to base sale module in V12. So no need for another dependency.
The method _prepare_procurement_values is used by sale_stock, and there needs to be a dependency or else the sale_stock values will overwrite the values from this module.