[11.0] [MIG] sale_rental #819

ghost · 2019-03-29T03:42:33Z

No description provided.

…the same SO as the rentals = the start date of the rentals, because we suppose that these products are "accessories" of the rental. Re-organise the order of some lines of code to make it more "logic".

Add list of limitations in the module description.

Add full FR translation for sale_start_end_dates Add partial FR translation for sale_rental

This bug was very annoying because it means that, if you had sale_rental installed, you are missing the link betweek purchase order lines and invoice lines (for purchase orders created from pickings)

…es from products

…ew of sale order line, and instructions on how to do it Add demo data to automatically add admin and demo to group sale.group_mrp_properties, to have access to form view of sale order lines.

Add a link to the screencast in the module description

…y of the rental features

Fix translated string in code

Add option to copy image from product to rental service default_code should not be a required field in rental service wizard Add help message on rental_qty field

Replace openerp by odoo in import declarations

ghost · 2019-06-18T07:41:27Z

Fixed in commit #819

HaraldPanten

Functional review 👎

Can not create Rental service in Rental tab, an error is shown:

Traceback (most recent call last): File "/.repo_requirements/odoo/odoo/http.py", line 653, in _handle_exception return super(JsonRequest, self)._handle_exception(exception) File "/.repo_requirements/odoo/odoo/http.py", line 312, in _handle_exception raise pycompat.reraise(type(exception), exception, sys.exc_info()[2]) File "/.repo_requirements/odoo/odoo/tools/pycompat.py", line 87, in reraise raise value File "/.repo_requirements/odoo/odoo/http.py", line 695, in dispatch result = self._call_function(**self.params) File "/.repo_requirements/odoo/odoo/http.py", line 344, in _call_function return checked_call(self.db, *args, **kwargs) File "/.repo_requirements/odoo/odoo/service/model.py", line 97, in wrapper return f(dbname, *args, **kwargs) File "/.repo_requirements/odoo/odoo/http.py", line 337, in checked_call result = self.endpoint(*a, **kw) File "/.repo_requirements/odoo/odoo/http.py", line 939, in __call__ return self.method(*args, **kw) File "/.repo_requirements/odoo/odoo/http.py", line 517, in response_wrap response = f(*args, **kw) File "/home/odoo/OCB-11.0/addons/web/controllers/main.py", line 938, in call_button action = self._call_kw(model, method, args, {}) File "/home/odoo/OCB-11.0/addons/web/controllers/main.py", line 926, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "/.repo_requirements/odoo/odoo/api.py", line 689, in call_kw return call_kw_multi(method, model, args, kwargs) File "/.repo_requirements/odoo/odoo/api.py", line 680, in call_kw_multi result = method(recs, *args, **kwargs) File "/home/odoo/build/OCA/sale-workflow/sale_rental/wizard/create_rental_product.py", line 77, in create_rental_product product = pp_obj.create(self._prepare_rental_product()) File "/home/odoo/build/OCA/sale-workflow/sale_rental/wizard/create_rental_product.py", line 53, in _prepare_rental_product day_uom_id = self.ref('product.product_uom_day') AttributeError: 'create.rental.product' object has no attribute 'ref'

ghost · 2019-06-18T09:30:35Z

Functional review

Can not create Rental service in Rental tab, an error is shown:

Traceback (most recent call last): File "/.repo_requirements/odoo/odoo/http.py", line 653, in _handle_exception return super(JsonRequest, self)._handle_exception(exception) File "/.repo_requirements/odoo/odoo/http.py", line 312, in _handle_exception raise pycompat.reraise(type(exception), exception, sys.exc_info()[2]) File "/.repo_requirements/odoo/odoo/tools/pycompat.py", line 87, in reraise raise value File "/.repo_requirements/odoo/odoo/http.py", line 695, in dispatch result = self._call_function(**self.params) File "/.repo_requirements/odoo/odoo/http.py", line 344, in _call_function return checked_call(self.db, *args, **kwargs) File "/.repo_requirements/odoo/odoo/service/model.py", line 97, in wrapper return f(dbname, *args, **kwargs) File "/.repo_requirements/odoo/odoo/http.py", line 337, in checked_call result = self.endpoint(*a, **kw) File "/.repo_requirements/odoo/odoo/http.py", line 939, in __call__ return self.method(*args, **kw) File "/.repo_requirements/odoo/odoo/http.py", line 517, in response_wrap response = f(*args, **kw) File "/home/odoo/OCB-11.0/addons/web/controllers/main.py", line 938, in call_button action = self._call_kw(model, method, args, {}) File "/home/odoo/OCB-11.0/addons/web/controllers/main.py", line 926, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "/.repo_requirements/odoo/odoo/api.py", line 689, in call_kw return call_kw_multi(method, model, args, kwargs) File "/.repo_requirements/odoo/odoo/api.py", line 680, in call_kw_multi result = method(recs, *args, **kwargs) File "/home/odoo/build/OCA/sale-workflow/sale_rental/wizard/create_rental_product.py", line 77, in create_rental_product product = pp_obj.create(self._prepare_rental_product()) File "/home/odoo/build/OCA/sale-workflow/sale_rental/wizard/create_rental_product.py", line 53, in _prepare_rental_product day_uom_id = self.ref('product.product_uom_day') AttributeError: 'create.rental.product' object has no attribute 'ref'

Fixed in commit

HaraldPanten

Functional review.

LGTM 👍

alexis-via · 2019-07-12T10:46:04Z

sale_rental/models/stock.py

+        'stock.location.route', string='Sell Rented Product Route')
+
+    @api.onchange('rental_allowed')
+    def _onchange_rrental_allowed(self):


This double "r" is a typo, right ?

benbrich · 2019-10-14T15:01:29Z

Thanks @danhvophuong for your great work! How about getting this one merged? Or is there more to be fixed than just the "r" typo @alexis-via found?

ghost · 2019-10-16T10:15:28Z

just "r" typo, I will fix it soon

benbrich · 2019-10-16T10:20:14Z

Great! and thanks for the good work!

oca-clabot · 2019-10-16T10:36:03Z

Hey @danhvophuong, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Danh Vo danh@trobz.com (no github login found)

Appreciation of efforts,
OCA CLAbot

benbrich · 2019-10-16T11:54:56Z

Hey @danhvophuong it looks like there is some prob with the CLA, but as I saw you have already a merged pr so I assume there is a prob on OCA side. Can you confirm that you have signed the CLA, so @pedrobaeza can check this? Thanks

ghost · 2019-10-16T11:59:27Z

Confirmed, I already signed CLA with email vophuongdanh@gmail.com. I am working on another environment so the configuration can be different

benbrich · 2019-10-16T12:16:35Z

So, when I see things right we should get a 'go' from @nikul-serpentcs and @alexis-via to merge this one. Thanks for a fast rereview... :-)

yweng8111 · 2019-10-16T14:40:14Z

sale_rental/models/sale_order.py

+    @api.multi
+    def _get_rental_date_planned(self):
+        self.ensure_one()
+        start_date = datetime.strptime(
+            self.start_date, DEFAULT_SERVER_DATE_FORMAT)
+        return start_date.strftime(DEFAULT_SERVER_DATETIME_FORMAT)


Thanks for your great work. I have just one suggestion after my review. Instead of "strptime" and "strftime" You can use functions "from_string" and "to_string" of fields.Datetime and fields.Date.

yweng8111 · 2019-10-17T10:30:57Z

sale_rental/models/sale_order.py

+                if line.rental_type == 'new_rental':
+                    sale_rental = self.env['sale.rental'].search(
+                        [('start_order_line_id', '=', line.id)], limit=1)
+                    sale_rental.out_move_id._action_cancel()
+                    sale_rental.in_move_id._action_cancel()


Moves for rental will be cancelled in super function. You don't need to do it again.

yweng8111 · 2019-10-18T14:21:45Z

sale_rental/models/sale_order.py

+            if line.rental_type == 'new_rental':
+                vals = {
+                    'company_id': line.order_id.company_id,
+                    'group_id': procurement_group,
+                    'sale_line_id': line.id,
+                    'date_planned': line._get_rental_date_planned(),
+                    'route_ids': line.order_id.warehouse_id.rental_route_id,
+                    'warehouse_id': line.order_id.warehouse_id or False,
+                    'partner_dest_id': line.order_id.partner_shipping_id
+                }


Could you please move this part into a new function of "sale.order.line", so that it can be extended easily.

ghost · 2019-11-12T04:48:28Z

@yweng8111 the adjustment is pushed

yweng8111 · 2019-11-19T15:17:21Z

sale_rental/models/sale_order.py

+                line.order_id.procurement_group_id = procurement_group
+
+            if line.rental_type == 'new_rental':
+                vals = self.prepare_rental_values(procurement_group)


I think here should be
vals = line.prepare_rental_values(procurement_group)
Otherwise we will get the singleton Error, if the sale order has more than 1 sale order lines.

yweng8111

Thanks

rousseldenis · 2020-01-20T12:41:11Z

@nikul-serpentcs @alexis-via Could you update your review?

nikul-serpentcs · 2020-07-17T11:18:15Z

@danhvophuong squash commits

rousseldenis · 2022-02-04T09:52:12Z

Closing this as too old. Please feel free to reopen it if needed.

Alexis de Lattre and others added 30 commits March 29, 2019 10:25

Initial check-in of the rental project.

1906c42

We want to have the date_planned of the regular products that are on …

b0d9daa

…the same SO as the rentals = the start date of the rentals, because we suppose that these products are "accessories" of the rental. Re-organise the order of some lines of code to make it more "logic".

Restrict to "day" UoM in the constraint.

4a3ca0b

Add list of limitations in the module description.

Add read access on rental to stock user.

fd3d398

Add POT file

0c2fb4b

Add full FR translation for sale_start_end_dates Add partial FR translation for sale_rental

Add pt_BR translation, contributed by Caio Barros.

f599101

[FIX] Missing call to super in _invoice_line_hook

280c503

This bug was very annoying because it means that, if you had sale_rental installed, you are missing the link betweek purchase order lines and invoice lines (for purchase orders created from pickings)

Better default values in the wizard for the creation of rental servic…

04087af

…es from products

Add a note about the fact that you need to have access to the form vi…

462b061

…ew of sale order line, and instructions on how to do it Add demo data to automatically add admin and demo to group sale.group_mrp_properties, to have access to form view of sale order lines.

FIX my commit revno 9 on the wizard to create the rental service

d85635c

Add a link to the screencast in the module description

Port to v8 and new API with several enhancements

dac8fdc

Fix typo

782cda1

Inherit of product_id_change on product_id field, for better usabilit…

f5a9786

…y of the rental features

Fix flake8 warnings

a855585

Fix spelling mistake notified by @jbeficent

b403688

Update POT file and FR translation

140f818

Fix translated string in code

Take into account the remarks of Jordi Ballester

7f4e97d

Add option to copy image from product to rental service default_code should not be a required field in rental service wizard Add help message on rental_qty field

FIX Tax on sale order lines

cfc51f0

FIX the "0" qty by default in sale order lines

c329bde

Add missing default oca icons

cefa7b3

Slovene translations added

bec2be6

OCA Transbot updated translations from Transifex

314dd6c

OCA Transbot updated translations from Transifex

b070c29

[UPD] prefix versions with 8.0

c3058a6

OCA Transbot updated translations from Transifex

4cc310a

[MIG] Make modules uninstallable

2ace2b1

[MIG] Rename manifest files

e62f9c0

Port sale_start_end_dates and sale_rental (#353)

fd3c47f

[10.0][MIG] sale_start_end_dates and sale_rental

71c275b

[FIX] Product qty on rental pickings

c66f5ad

Replace openerp by odoo in import declarations

ghost mentioned this pull request Mar 29, 2019

Migration to version 11.0 #538

Closed

65 tasks

pedrobaeza added this to the 11.0 milestone Mar 29, 2019

OCA-git-bot mentioned this pull request Mar 29, 2019

Migration to version 12.0 #700

Closed

54 tasks

HaraldPanten requested changes Jun 18, 2019

View reviewed changes

HaraldPanten approved these changes Jun 18, 2019

View reviewed changes

alexis-via reviewed Jul 12, 2019

View reviewed changes

[MIG] sale_rental: Migration to 11.0

2518168

yweng8111 approved these changes Oct 16, 2019

View reviewed changes

yweng8111 reviewed Oct 17, 2019

View reviewed changes

yweng8111 suggested changes Oct 18, 2019

View reviewed changes

[IMP]sale_rental: Migration to 11.0

3597c79

yweng8111 approved these changes Nov 12, 2019

View reviewed changes

yweng8111 suggested changes Nov 19, 2019

View reviewed changes

[IMP]Adjusting for singleton issue

7de2579

yweng8111 approved these changes Jan 20, 2020

View reviewed changes

rousseldenis added the migration label Jan 20, 2020

rousseldenis closed this Feb 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0] [MIG] sale_rental #819

[11.0] [MIG] sale_rental #819

ghost commented Mar 29, 2019

ghost commented Jun 18, 2019

HaraldPanten left a comment

ghost commented Jun 18, 2019

HaraldPanten left a comment

alexis-via Jul 12, 2019

benbrich commented Oct 14, 2019

ghost commented Oct 16, 2019

benbrich commented Oct 16, 2019

oca-clabot commented Oct 16, 2019

benbrich commented Oct 16, 2019

ghost commented Oct 16, 2019

benbrich commented Oct 16, 2019

yweng8111 Oct 16, 2019

yweng8111 Oct 17, 2019 •

edited

Loading

yweng8111 Oct 18, 2019

ghost commented Nov 12, 2019

yweng8111 Nov 19, 2019 •

edited

Loading

ghost Dec 25, 2019

yweng8111 left a comment

rousseldenis commented Jan 20, 2020

nikul-serpentcs commented Jul 17, 2020

rousseldenis commented Feb 4, 2022

[11.0] [MIG] sale_rental #819

[11.0] [MIG] sale_rental #819

Conversation

ghost commented Mar 29, 2019

ghost commented Jun 18, 2019

HaraldPanten left a comment

Choose a reason for hiding this comment

ghost commented Jun 18, 2019

HaraldPanten left a comment

Choose a reason for hiding this comment

alexis-via Jul 12, 2019

Choose a reason for hiding this comment

benbrich commented Oct 14, 2019

ghost commented Oct 16, 2019

benbrich commented Oct 16, 2019

oca-clabot commented Oct 16, 2019

benbrich commented Oct 16, 2019

ghost commented Oct 16, 2019

benbrich commented Oct 16, 2019

yweng8111 Oct 16, 2019

Choose a reason for hiding this comment

yweng8111 Oct 17, 2019 • edited Loading

Choose a reason for hiding this comment

yweng8111 Oct 18, 2019

Choose a reason for hiding this comment

ghost commented Nov 12, 2019

yweng8111 Nov 19, 2019 • edited Loading

Choose a reason for hiding this comment

ghost Dec 25, 2019

Choose a reason for hiding this comment

yweng8111 left a comment

Choose a reason for hiding this comment

rousseldenis commented Jan 20, 2020

nikul-serpentcs commented Jul 17, 2020

rousseldenis commented Feb 4, 2022

yweng8111 Oct 17, 2019 •

edited

Loading

yweng8111 Nov 19, 2019 •

edited

Loading