Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] connector_search_engine: check binding model #177

Merged
merged 1 commit into from Dec 15, 2023
Merged

[16.0][IMP] connector_search_engine: check binding model #177

merged 1 commit into from Dec 15, 2023

Conversation

qgroulard
Copy link
Contributor

No description provided.

@qgroulard qgroulard mentioned this pull request Dec 1, 2023
Merged
1 task
flotho
flotho approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.
Not so much changes,
LGTM

simahawk
simahawk reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, small remark on the tests

connector_search_engine/tests/test_all.py Outdated Show resolved Hide resolved
@lmignon
Copy link
Sponsor Contributor

lmignon commented Dec 14, 2023

@qgroulard Can you take into account the last comment from Simone?

@lmignon lmignon force-pushed the 16.0-fix-search_engine_binding_check_model-qgr branch from 02013d1 to 2b71764 Compare December 15, 2023 07:27
@lmignon lmignon force-pushed the 16.0-fix-search_engine_binding_check_model-qgr branch from 2b71764 to e828c12 Compare December 15, 2023 07:28
@lmignon
Copy link
Sponsor Contributor

lmignon commented Dec 15, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-177-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7fc01ec into OCA:16.0 Dec 15, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a9066f9. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-fix-search_engine_binding_check_model-qgr branch December 15, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk left review comments

@flotho flotho flotho approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qgroulard @lmignon @OCA-git-bot @simahawk @flotho