IMP print failed query to help debugging #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Oct 23, 2019
bealdav
force-pushed
the
12-sql-abs-print-query
branch
from
d4c6a7c
to
65241d6
Compare
legalsylvain
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
LGTM for me. Thanks for the improvment.
@pedrobaeza, @foutoucour, could you update your review ?
regards.
pedrobaeza
approved these changes
Oct 24, 2019
foutoucour
approved these changes
Oct 24, 2019
|
/ocabot merge |
|
On my way to merge this fine PR! |
OCA-git-bot
added a commit
that referenced
this pull request
Oct 24, 2019
|
Congratulations, your PR was merged at cd0c676. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please @legalsylvain