[12.0] [IMP] sentry: migrate sentry-raven to new api sentry-sdk

[fernandahf]

Description of the issue/feature this PR addresses:

Current behavior before PR: events sent for sentry-raven with context, excluding loggers, exceptions and filtering sense data. In fact, Sentry warns about migrate to new api:

Desired behavior after PR is merged: events sent for sentry-sdk with context, excluding loggers, exceptions and filtering sensitive data, show events in sentry sdk without warning about update api. Sentry just shows sentry-sdk version without warning migrate.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[moylop260]

Could you check if we can remove raven entirely as dependency, please?

[moylop260]

@barsi @naglis @versada
We are migrating the new api of sentry
Could you check it, please?

It is still WIP but if you can get a look here we will grateful

[moylop260]

For the record,
A good improvement I saw using sentry-sdk instead of sentry-raven is it is adding a tag with the hash of the trace

• 

I had needed before to have this value and I just use the following PR to add it manually:

• [REF] sql_db: Add traceback stack if there is a exeception running a query Vauxoo/odoo#358

Now it is auto-generated.

[moylop260]

For the record,
Another improvement:

• Before of this PR USER: IP Address 127.0.0.1
• After this PR USER: IP Address "REAL-PUBLIC-IP"

[hparfr]

Thanks for this great and needed work.
Didn't had time to test it yet, some remarks from the code review.

[hoangtrann]

Any updates on this guys?

[moylop260]

@hoangtrann

We are waiting for approves

I mean, we need almost 2 approves to install and configure this module with this new change and do feedback or approve.

Fell free to test it, please

[ryantran-novobi]

I have deployed and ran this PR successfully on Odoo instance running on Odoo.sh

ping @moylop260 @hparfr @fernandahf

[kirtangajjar]

I tested this PR. It works fine on my local. I'm able to see the errors in sentry, however, I'm unable to see anything in the performance screen. Is it expected?

[hoangtrann]

Not sure if this is relavant, but how could we enhance the presentation of model object in sentry, like sale.order(124292,) or sale.order(124292, 124293)

@fernandahf @moylop260

[fernandahf]

@kirtangajjar

What is the performance screen? I searched but didn't find it.

Regards.

[kirtangajjar]

@fernandahf Check the below screenshot.

Here are the link to official docs:

https://docs.sentry.io/product/performance/
https://docs.sentry.io/product/performance/getting-started/

[kirtangajjar]

@fernandahf Did you get time to look at it?

[hparfr]

Thanks

[themreza]

What's the status here?

[fernandahf]

@themreza

We are waiting for approves

I mean, we need almost 1 approve to install and configure this module with this new change and do feedback or approve.

Fell free to test it, please

[themreza]

I tested the code in this branch on Odoo 14 and I can confirm that issues are being correctly sent to Sentry.

Although the performance feature is sending data, it's really vague and rather pointless.

I intentionally ran some excessively slow requests to see the trace, ideally starting from the HTTP request all the way to the database query or the compute methods responsible, but no details were included:

Also, there is no frontend tracking via JavaScript:

I'm not sure if it's a bug, but when I added sentry_traces_sample_rate to odoo.conf, the parsed value was str rather than float.

P.S.: It wasn't working at first which threw me off for a while, but I later figured out it was because I was running Odoo via PyCharm's debug mode and it didn't send anything.

[themreza]

I figured out the frontend issue and performance tracking.

With a simple template it's possible to inject Sentry's JavaScript bundle:

<?xml version="1.0" encoding="UTF-8"?>
<odoo>
    <template id="assets_backend" name="sentry_javascript_assets" inherit_id="web.assets_backend">
        <xpath expr="." position="inside">
            <script
                    src="https://browser.sentry-cdn.com/6.5.1/bundle.tracing.min.js"
                    integrity="sha384-TkhX8dCdk4BiV9tdHwvmIHWhdvw+LGo0SrMWTTBZ2T/sAUnxQWPuRiXELaaiZT6A"
                    crossorigin="anonymous">
            </script>
            <script>
                Sentry.init({
                  dsn: "YOUR_DSN",

                  // This enables automatic instrumentation (highly recommended), but is not
                  // necessary for purely manual usage
                  integrations: [new Sentry.Integrations.BrowserTracing()],

                  // To set a uniform sample rate
                  tracesSampleRate: 0.2
                });
            </script>
        </xpath>
    </template>
</odoo>

I believe if we enable propagate_traces option, we can link the server-sided traces to frontend ones.

But still, the backend traces are not offering a detailed breakdown of what the request consisted of.

[ryantran-novobi]

@moylop260 would you mind taking a look at this one? I believe that all the discussions are resolved and it's waiting for your approval so far

[moylop260]

@ryantran-novobi

Let's do it

[moylop260]

/ocabot merge major

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-1942-by-moylop260-bump-major, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at b370e86. Thanks a lot for contributing to OCA. ❤️

[codeagencybe]

Is this issue already resolved and ready to use now on v14?
I just downloaded the latest version and installed and it reports to me I need to upgrade the SDK.
But this issue seems to have resolved that issue?
Any feedback please?

[fernandahf]

Hi @codeagencybe

It's not in forward-ported yet, but there is one PR related to v14.0

#1976