7.0 pep8 #27
Merged
7.0 pep8 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling d323598 on savoirfairelinux:7.0-pep8 into * on OCA:7.0*. |
|
Changes Unknown when pulling 9b4e2a3 on savoirfairelinux:7.0-pep8 into * on OCA:7.0*. |
|
👍 LGTM |
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <openerp> | |||
| <data> | |||
| <delete model="ir.ui.menu" id="base.module_mi" /> | |||
| <delete model="ir.ui.menu" id="base.menu_module_updates" /> | |||
| <delete model="ir.ui.menu" search="[('parent_id', '=', ref('base.menu_management'), ('name', '=', 'Apps'))]" /> | |||
There was a problem hiding this comment.
Why do you change this? I prefer removal by id.
There was a problem hiding this comment.
Because it will cause an exception when init (not update) is run twice, which travis tests do.
I don't like leaving any code that can spontaneously crash.
This is not an easy problem to solve. Either we delete with a search or we tell users to never init twice AND change the Odoo test code.
There was a problem hiding this comment.
Yeah, this is a good reason indeed. OK, let's change this then.
Regards.
|
👍 |
|
👍 LGTM |
pedrobaeza
added a commit
that referenced
this pull request
Jul 24, 2014
StefanRijnhart
pushed a commit
to StefanRijnhart/server-tools
that referenced
this pull request
Feb 26, 2017
[IMP] easy_web_export : migration to 8.0
lasley
pushed a commit
to LasLabs/server-tools
that referenced
this pull request
Jun 15, 2017
* REF move db tools fix modules to adho modules * REF
hughesbm
pushed a commit
to LasLabs/server-tools
that referenced
this pull request
Jun 15, 2017
DEL remote backup functionality and start to simplify scheduller schemma IMP big improvements on database tools FIX menores last commit IMP ADD removed wizard to make it uninstalable FIX views order FIX ADD securit rules IMP remove automatic from database_backup_clean called from cron IMP FIX format for pep IMP pep FIX imports IMP add fabric to travis IMP manifests ADD translations IMP add backup_format pgdump functionality to database tools IMP add hourly backup IMP varios IMP IMP clean prints FIX backup clean IMP data on db tools IMp alert if backup already exists IMP restore with overwrite IMP pylint IMP version on database tools FIX backups on multiple databases ADD modules status management IMP db tools IMP FIX minor imp FIX pylint IMP disable backups by default IMP minor fix OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex IMP module version check IMP increase manifest version FIX format IMP db backups check OCA Transbot updated translations from Transifex IMP default datetime value IMP use v9 and installble = False FIX for v9 and make installable ADD license to __openerp__.py IMp db tools for fix db automatically MINOR FIXES IMP error messages FIX IMP modulestatus identifiers REF format FIX FIX IMP no backups if not enable IMP use info instead of warning IMP db tools, make cron fix db IMP deactivate fix cron IMP notas IMp increase interval of fix IMP IMP IMP db backup delete IMP IMP FIX version FIX db tools REF IMP db fix FIX IMP IMP varias IMP REF ADd wizard for backup now REF IMP varios INIT v9 IMP FIX IMP FIX IMP IMP db tools IMP migration to v9 IMP IMP FIX depends IMP IMP FIR lint IMP database_tools views REF change warning for validation error IMP IMP views OCA Transbot updated translations from Transifex IMP REF REF OCA Transbot updated translations from Transifex IMP log IMP View DEL fix db controller IMP db config performance ADD db tools cli IMP clean db code IMP FIX FIX webserver REF OCA Transbot updated translations from Transifex IMP db tools, add create db IMP REF DEL createdb functionality, native if you set database on odoo conf REF move db tools fix modules to adho modules (OCA#27) * REF move db tools fix modules to adho modules * REF OCA Transbot updated translations from Transifex
lasley
pushed a commit
to LasLabs/server-tools
that referenced
this pull request
Jun 19, 2017
* REF move db tools fix modules to adho modules * REF
hughesbm
pushed a commit
to LasLabs/server-tools
that referenced
this pull request
Jun 19, 2017
IMP IMP IMp IMp IMP FIX lint IMP ADD server-tools depend FIX FIX IMP IMP IMP remove mass editting repe IMP increase version number FI IMP IMP reload on click IMP FIX IMP db fix FIX IMP IMP FIX FIX IMP IMP varias IMP IMP adhoc modules FIX FIX IMP IMP IMP FIX IMP IMP varias IMp FIX REF FIX IMP minor improvements IMP varios INIT v9 IMP FIX FIX REF IMP IMP IMP IMP IMP IMP adhoc modules FIX adhoc modules recurssion IMP try me on test IMP add incompatible modules functionallity MIG adhoc_modules REF REF change warning for validation error IMP views OCA Transbot updated translations from Transifex REF OCA Transbot updated translations from Transifex IMP FIX (6, False, []) for [] IMP FIX IMP usability IMP demo data ADD missing file IMP block uninstall of modules for other user than admin OCA Transbot updated translations from Transifex DEL createdb functionality, native if you set database on odoo conf IMP REF OCA Transbot updated translations from Transifex REF REF REF REF move db tools fix modules to adho modules (OCA#27) * REF move db tools fix modules to adho modules * REF REF REF OCA Transbot updated translations from Transifex REF disable automatic backup FIX REF
hughesbm
pushed a commit
to LasLabs/server-tools
that referenced
this pull request
Jun 29, 2017
IMP IMP IMp IMp IMP FIX lint IMP ADD server-tools depend FIX FIX IMP IMP IMP remove mass editting repe IMP increase version number FI IMP IMP reload on click IMP FIX IMP db fix FIX IMP IMP FIX FIX IMP IMP varias IMP IMP adhoc modules FIX FIX IMP IMP IMP FIX IMP IMP varias IMp FIX REF FIX IMP minor improvements IMP varios INIT v9 IMP FIX FIX REF IMP IMP IMP IMP IMP IMP adhoc modules FIX adhoc modules recurssion IMP try me on test IMP add incompatible modules functionallity MIG adhoc_modules REF REF change warning for validation error IMP views OCA Transbot updated translations from Transifex REF OCA Transbot updated translations from Transifex IMP FIX (6, False, []) for [] IMP FIX IMP usability IMP demo data ADD missing file IMP block uninstall of modules for other user than admin OCA Transbot updated translations from Transifex DEL createdb functionality, native if you set database on odoo conf IMP REF OCA Transbot updated translations from Transifex REF REF REF REF move db tools fix modules to adho modules (OCA#27) * REF move db tools fix modules to adho modules * REF REF REF OCA Transbot updated translations from Transifex REF disable automatic backup FIX REF
Garamotte
pushed a commit
to subteno-it/server-tools
that referenced
this pull request
Jul 12, 2017
Add license key in __openerp__.py
hughesbm
pushed a commit
to LasLabs/server-tools
that referenced
this pull request
Jul 13, 2017
IMP IMP IMp IMp IMP FIX lint IMP ADD server-tools depend FIX FIX IMP IMP IMP remove mass editting repe IMP increase version number FI IMP IMP reload on click IMP FIX IMP db fix FIX IMP IMP FIX FIX IMP IMP varias IMP IMP adhoc modules FIX FIX IMP IMP IMP FIX IMP IMP varias IMp FIX REF FIX IMP minor improvements IMP varios INIT v9 IMP FIX FIX REF IMP IMP IMP IMP IMP IMP adhoc modules FIX adhoc modules recurssion IMP try me on test IMP add incompatible modules functionallity MIG adhoc_modules REF REF change warning for validation error IMP views OCA Transbot updated translations from Transifex REF OCA Transbot updated translations from Transifex IMP FIX (6, False, []) for [] IMP FIX IMP usability IMP demo data ADD missing file IMP block uninstall of modules for other user than admin OCA Transbot updated translations from Transifex DEL createdb functionality, native if you set database on odoo conf IMP REF OCA Transbot updated translations from Transifex REF REF REF REF move db tools fix modules to adho modules (OCA#27) * REF move db tools fix modules to adho modules * REF REF REF OCA Transbot updated translations from Transifex REF disable automatic backup FIX REF
hughesbm
pushed a commit
to LasLabs/server-tools
that referenced
this pull request
Jul 17, 2017
IMP IMP IMp IMp IMP FIX lint IMP ADD server-tools depend FIX FIX IMP IMP IMP remove mass editting repe IMP increase version number FI IMP IMP reload on click IMP FIX IMP db fix FIX IMP IMP FIX FIX IMP IMP varias IMP IMP adhoc modules FIX FIX IMP IMP IMP FIX IMP IMP varias IMp FIX REF FIX IMP minor improvements IMP varios INIT v9 IMP FIX FIX REF IMP IMP IMP IMP IMP IMP adhoc modules FIX adhoc modules recurssion IMP try me on test IMP add incompatible modules functionallity MIG adhoc_modules REF REF change warning for validation error IMP views OCA Transbot updated translations from Transifex REF OCA Transbot updated translations from Transifex IMP FIX (6, False, []) for [] IMP FIX IMP usability IMP demo data ADD missing file IMP block uninstall of modules for other user than admin OCA Transbot updated translations from Transifex DEL createdb functionality, native if you set database on odoo conf IMP REF OCA Transbot updated translations from Transifex REF REF REF REF move db tools fix modules to adho modules (OCA#27) * REF move db tools fix modules to adho modules * REF REF REF OCA Transbot updated translations from Transifex REF disable automatic backup FIX REF
modoolar-bot
pushed a commit
to modoolar/oca-server-tools
that referenced
this pull request
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot commit d007be5
Fix additional style issues
Use official travis