Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16][IMP] attachment_synchronize : add hook when pushing file to remote #3011

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[16][IMP] attachment_synchronize : add hook when pushing file to remote #3011

merged 1 commit into from
Aug 29, 2024

Conversation

florian-dacosta
Copy link
Contributor

It may be usefull for instance to be able to pass custom parameters to the fsspec open method

@bealdav @kevinkhao @bguillot
Easy one if you may review it

@OCA-git-bot
Copy link
Contributor

Hi @sebastienbeau, @GSLabIt, @bealdav,
some modules you are maintaining are being modified, check this out!

kevinkhao
kevinkhao approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@kevinkhao kevinkhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

SirAionTech
SirAionTech approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Only code review: I don't see any issue with this change, just asking little clarification (see comment below).

attachment_synchronize/models/attachment_queue.py Outdated Show resolved Hide resolved
SirAionTech
SirAionTech suggested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't notice it before, but could you please adapt the commit message to the guidelines https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message?
In particular

please check if the commit message is cut with ellipsis.

@florian-dacosta
[IMP] attachment_synchronize: add hook
bf53ff5 
The goal is to be able easy overrides to pass custom parameters to the fsspec open method
@florian-dacosta
Copy link
Contributor Author

Sure, I've changed the commit message, thanks.

@bguillot
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3011-by-bguillot-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 6d04b10 into OCA:16.0 Aug 29, 2024
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6d04b10. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bealdav bealdav bealdav approved these changes

@kevinkhao kevinkhao kevinkhao approved these changes

@SirAionTech SirAionTech SirAionTech approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@florian-dacosta @OCA-git-bot @bguillot @bealdav @kevinkhao @SirAionTech