Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][ADD] calendar_event_state module #737

Closed
wants to merge 1 commit into from
Closed

[10.0][ADD] calendar_event_state module #737

wants to merge 1 commit into from

Conversation

tafaRU
Copy link
Member

@tafaRU tafaRU commented Feb 15, 2017

No description provided.

@tafaRU tafaRU changed the title [10.0][ADD] calendar_event_state module [WIP][10.0][ADD] calendar_event_state module Feb 15, 2017
@tafaRU tafaRU force-pushed the 10.0-calendar_event_state-add branch from a56af77 to e1f743e Compare February 15, 2017 15:41
@tafaRU tafaRU changed the title [WIP][10.0][ADD] calendar_event_state module [10.0][ADD] calendar_event_state module Feb 15, 2017
@lasley lasley added this to the 10.0 milestone Apr 19, 2017
lasley
lasley reviewed Apr 19, 2017
View reviewed changes
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tafaRU. Might I recommend basing on base_kanban_stage instead, which would provide more features, eliminate the untested code, and reduce the overall module footprint.

calendar_event_state/data/calendar_state_data.xml
@@ -0,0 +1,25 @@
<?xml version="1.0" encoding="utf-8"?>

<odoo>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odoo noupdate="1" & can remove the data tag

calendar_event_state/models/calendar.py
# Copyright 2016-2017 Lorenzo Battistini - Agile Business Group
# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).

from odoo import models, fields, api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize imports

@dreispt
Copy link
Sponsor Member

dreispt commented Apr 20, 2017

+1 to reuse base_kanban_stage

@tafaRU
Copy link
Member Author

tafaRU commented Aug 24, 2017 •
edited
Loading

@lasley, thanks a lot for the hint! I'm working on it.
After that, wouldn't be better rename it to calendar_event_kanban_stage? Do you agree?

@lasley
Copy link
Contributor

lasley commented Aug 24, 2017

After that, wouldn't be better rename it to calendar_event_kanban_stage? Do you agree?

I do!

@tafaRU
Copy link
Member Author

tafaRU commented Aug 25, 2017

I'm working on https://github.com/tafaRU/server-tools/tree/10.0-calendar_event_kanban_stage-add/calendar_event_kanban_stage

@tafaRU
Copy link
Member Author

tafaRU commented Sep 5, 2017

Superseded by #964

@tafaRU tafaRU closed this Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasley lasley lasley left review comments

@eLBati eLBati eLBati approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tafaRU @dreispt @lasley @eLBati