Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][ADD] Add calendar_event_kanban_stage module #964

Closed
wants to merge 1 commit into from
Closed

[10.0][ADD] Add calendar_event_kanban_stage module #964

wants to merge 1 commit into from

Conversation

tafaRU
Copy link
Member

@tafaRU tafaRU commented Sep 5, 2017 •
edited

Please set it as Work in Progress.

@tafaRU tafaRU mentioned this pull request Sep 5, 2017
Closed
@lasley lasley added this to the 10.0 milestone Sep 5, 2017
@tafaRU tafaRU force-pushed the 10.0-calendar_event_kanban_stage-add branch from 35c33b0 to 95865c7 Compare September 6, 2017 10:24
@tafaRU tafaRU mentioned this pull request Sep 14, 2017
Closed
@tafaRU tafaRU force-pushed the 10.0-calendar_event_kanban_stage-add branch from 95865c7 to 1f45b73 Compare October 11, 2017 08:10
@tafaRU
Copy link
Member Author

tafaRU commented Oct 11, 2017

@lasley, PR is ready to be reviewed. Please avoid work in progress label.
Thank you in advance.

@tafaRU tafaRU changed the title [10.0][WIP] Add calendar_event_kanban_stage module [10.0][ADD] Add calendar_event_kanban_stage module Oct 11, 2017
yajo
yajo approved these changes Oct 11, 2017
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems OK. No runbot here?

@tafaRU
Copy link
Member Author

tafaRU commented Oct 11, 2017

No runbot here?

No idea, maybe @gurneyalex could give us more info about this.

@lasley
Copy link
Contributor

lasley commented Oct 11, 2017

@gurneyalex - Looks like Runbot is failing pretty consistently across repos. It looks like the only build runner is runbot3, so I'm thinking we have something up with the build runners.

image

@eLBati
Copy link
Member

eLBati commented Oct 12, 2017

Shouldn't this go to https://github.com/OCA/event ?

@tafaRU tafaRU mentioned this pull request Oct 12, 2017
Closed
@tafaRU
Copy link
Member Author

tafaRU commented Oct 12, 2017 •
edited

Shouldn't this go to https://github.com/OCA/event ?

@eLBati, see OCA/event#93

lasley
lasley approved these changes Oct 12, 2017
View reviewed changes
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that the naming is ambiguous, but this is Odoo's fault not our's.

@hurrinico
Copy link

👍

@dreispt
Copy link
Sponsor Member

dreispt commented Oct 13, 2017

This module adds Kanban stage functionality to the calendar event.

This should really go into an OCA/calendar repository, but I'm aware it doesn't exist.
Should we have one, at least for >=11.0 ?

dreispt
dreispt reviewed Oct 13, 2017
View reviewed changes
Copy link
Sponsor Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (no test)

@pedrobaeza
Copy link
Member

This should really go into an OCA/calendar repository, but I'm aware it doesn't exist.
Should we have one, at least for >=11.0 ?

Do we have enough modules to feed that new repository?

@lasley
Copy link
Contributor

lasley commented Oct 13, 2017

Do we have enough modules to feed that new repository?

I think it would be worthy. We put calendar_resource in CRM for some reason

@pedrobaeza
Copy link
Member

OK, let's go for that repository then

@tafaRU
Copy link
Member Author

tafaRU commented Oct 16, 2017

Please ping me once OCA/calendar repository will be created.

@dreispt
Copy link
Sponsor Member

dreispt commented Oct 25, 2017

@pedrobaeza Are you the one creating the repo?

@pedrobaeza
Copy link
Member

Sorry, no. Can you do it?

@dreispt
Copy link
Sponsor Member

dreispt commented Nov 8, 2017

@pedrobaeza Sorry, I don't have permissions:

image

@lasley
Copy link
Contributor

lasley commented Nov 8, 2017 •
edited

@dreispt - You should have permissions now.

I just recently learned the process for this, but had a bit of difficulty finding it in our Odoo (Pedro pointed me in the right direction).

You're looking for the "New PSC" process 😉 (although only some of it needs to be followed in this instance)

@SimoRubi
Copy link
Member

@dreispt, any news on this?

@dreispt
Copy link
Sponsor Member

dreispt commented Dec 13, 2017

We already have the https://github.com/OCA/calendar repo.

@SimoRubi
Copy link
Member

Thanks @dreispt.
@tafaRU ping

@tafaRU
Copy link
Member Author

tafaRU commented Dec 13, 2017

@dreispt, @SimoRubi, thanks! I'll move it in the next days.

@tafaRU
Copy link
Member Author

tafaRU commented Dec 14, 2017

I close this in favour of OCA/calendar#1

@tafaRU tafaRU closed this Dec 14, 2017
@SimoRubi SimoRubi mentioned this pull request Dec 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajo yajo yajo approved these changes

@dreispt dreispt dreispt approved these changes

@lasley lasley lasley approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tafaRU @lasley @eLBati @hurrinico @dreispt @pedrobaeza @SimoRubi @yajo