[MIG] 10.0 db cleanup #894

ecino · 2017-07-10T15:57:34Z

Takes #607 with 9.0 commits for module database_cleanup.

pedrobaeza · 2017-07-10T16:12:20Z

Please squash together "OCA Transbot" commits.

* [FIX] database_cleanup: Isolate build * Isolate `database_cleanup` into its own build in Travis file to fix OCA#689 * [FIX] database_cleanup: Remove KeyError assertion * Remove KeyError assertion in tests due to PR in comment being merged

* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties

ecino · 2017-07-10T16:17:38Z

Squashed some transbot commits (not all to preserve the order)

ecino · 2017-07-11T07:19:05Z

Strange that no ir.property are present in the test database, tests are failing because of this. Any ideas?

pedrobaeza · 2017-07-11T07:23:11Z

Create some of them in your setUp phase to see

ecino · 2017-07-11T09:02:42Z

Tests are fixed 😄

StefanRijnhart · 2017-07-24T13:56:26Z

database_cleanup/__manifest__.py

        'views/menu.xml',
    ],
-    'installable': False,
+    'installable': True,
+    "application": True,


Not an application IMHO

You're right, I removed it.

StefanRijnhart · 2017-07-24T16:55:20Z

database_cleanup/views/purge_properties.xml

+        <field name="type">ir.actions.server</field>
+        <field name="state">code</field>
+        <field name="model_id" ref="database_cleanup.model_cleanup_purge_wizard_property" />
+        <field name="code">action = self.get_wizard_action(cr, uid, context=context)</field>


I get spurious errors

ValueError: <type 'exceptions.NameError'>: "name 'self' is not defined" while evaluating u'action = self.get_wizard_action(cr, uid, context=context)'

when clicking on some of the menu items. It seems to help to replace the code contents of lines like this with

action = env['cleanup.purge.wizard.property'].get_wizard_action()

Thanks! You missed one, the one I referred to initially.

Sorry for that, it's now included

StefanRijnhart · 2017-07-25T14:47:26Z

database_cleanup/views/purge_wizard.xml

+                        </footer>
+                    </form>
+                    <div attrs="{'invisible': [('purge_line_ids', '!=', [])]}">
+                        Nothing found to clean up.


This always shows up, even when there are result lines present. Maybe the way to check for an empty one2many widget has changed.

I tried to figure out how to fix it but didn't came out with a working solution. By inspecting odoo source code I found code which is exactly the same as here. Any help from others would be appreciated.

The problem is that the div is in the field tag itself. It works when the div is moved before the field tag.

Thanks, now it works.

StefanRijnhart · 2017-07-26T13:33:56Z

database_cleanup/views/create_indexes.xml

+        <field name="type">ir.actions.server</field>
+        <field name="state">code</field>
+        <field name="model_id" ref="database_cleanup.model_cleanup_create_indexes_wizard" />
+        <field name="code">action = env.get('cleanup.purge.wizard.data').get_wizard_action()</field>


Wrong model. Should be 'cleanup.create_indexes.wizard'

StefanRijnhart · 2017-07-26T13:35:22Z

database_cleanup/views/purge_properties.xml

+        <field name="type">ir.actions.server</field>
+        <field name="state">code</field>
+        <field name="model_id" ref="database_cleanup.model_cleanup_purge_wizard_property" />
+        <field name="code">action = env.get('cleanup.purge.wizard.data').get_wizard_action()</field>


Wrong model. Should be 'cleanup.purge.wizard.property'

Fixed. Sorry for the confusion.

Using new base model inheritance.

StefanRijnhart

Thanks for all the quick fixes!

hbrunn

small things. I also made CompassionCH#1 for an issue when purging modules

hbrunn · 2017-08-01T23:57:29Z

database_cleanup/models/create_indexes.py

@@ -74,7 +75,8 @@ def find(self):
            if not self.env.cr.rowcount:
                continue

-            yield (0, 0, {


what was the problem with the iterator?

hbrunn · 2017-08-01T23:58:29Z

database_cleanup/models/purge_columns.py

-        for line in self:
+        if self:
+            objs = self
+        else:


if this happens, I think something went wrong in the UI. How can I reproduce this?

PS: If you really need this for whatever reason, just assign to self and leave the rest of the code as it is. It's just a variable like any other

hbrunn · 2017-08-02T00:03:11Z

database_cleanup/models/purge_models.py

+        # The super method crashes if the model cannot be instantiated
+        if self.env.context.get('no_prepare_update'):
+            return True
+        return super(IrModelFields, self)._prepare_update()


can't you filter self for existing models as done above? This also would make the extra context key unnecessary

[FIX] really uninstall modules and avoid a crash on cached data

moylop260 · 2017-08-24T03:38:44Z

@ecino What about @hbrunn comments?

ecino · 2017-08-24T15:07:03Z

@moylop260 I missed those comments, I will look into it when I have time.

hbrunn · 2017-09-05T18:06:48Z

@ecino I addressed those in CompassionCH#2

10.0 database cleanup

ecino · 2017-09-05T19:59:16Z

thanks @hbrunn, I merged your commits.

oca-transbot and others added 3 commits July 10, 2017 17:14

OCA Transbot updated translations from Transifex

03b191f

fixes OCA#587

ef8780c

[FIX] database_cleanup: Fix test (OCA#612)

8eb30f0

pedrobaeza mentioned this pull request Jul 10, 2017

[MIG] database_cleanup: Migration to version 10.0 #607

Closed

oca-transbot and others added 5 commits July 10, 2017 18:15

OCA Transbot updated translations from Transifex

287f779

OCA Transbot updated translations from Transifex

3531dce

OCA Transbot updated translations from Transifex

145329f

ecino force-pushed the 10.0-db-cleanup branch from 2eb97b1 to a8a41e9 Compare July 10, 2017 16:16

ecino force-pushed the 10.0-db-cleanup branch from a8a41e9 to 36b77bf Compare July 11, 2017 06:56

yajo added the needs review label Jul 11, 2017

yajo added this to the 10.0 milestone Jul 11, 2017

ecino force-pushed the 10.0-db-cleanup branch 3 times, most recently from 0d9210c to a958d8c Compare July 11, 2017 08:31

StefanRijnhart reviewed Jul 24, 2017

View reviewed changes

ecino force-pushed the 10.0-db-cleanup branch from a958d8c to 4cdad3d Compare July 24, 2017 14:04

StefanRijnhart reviewed Jul 24, 2017

View reviewed changes

ecino force-pushed the 10.0-db-cleanup branch from 4cdad3d to a4da45c Compare July 25, 2017 07:20

StefanRijnhart reviewed Jul 25, 2017

View reviewed changes

ecino force-pushed the 10.0-db-cleanup branch 2 times, most recently from 9176134 to 28c6d37 Compare July 26, 2017 13:32

StefanRijnhart reviewed Jul 26, 2017

View reviewed changes

ecino force-pushed the 10.0-db-cleanup branch from 28c6d37 to f79e278 Compare July 26, 2017 13:38

[MIG] database_cleanup: Migration to version 10.0

bf40673

Using new base model inheritance.

ecino force-pushed the 10.0-db-cleanup branch from f79e278 to bf40673 Compare July 26, 2017 13:40

StefanRijnhart approved these changes Jul 26, 2017

View reviewed changes

[FIX] really uninstall modules and avoid a crash on cached data

55fd3d5

hbrunn requested changes Aug 2, 2017

View reviewed changes

Merge pull request #1 from hbrunn/10.0-database_cleanup

54141e5

[FIX] really uninstall modules and avoid a crash on cached data

alan196 approved these changes Aug 23, 2017

View reviewed changes

hbrunn added 3 commits September 5, 2017 19:55

[FIX] don't try to uninstall uninstalled modules

95e0b9c

[DEL] weird code

b466c0c

[FIX] actually cleanup where we can

88a5bbf

Merge pull request #2 from hbrunn/10.0-database_cleanup

02a9225

10.0 database cleanup

hbrunn approved these changes Sep 5, 2017

View reviewed changes

pedrobaeza merged commit 4ff0c09 into OCA:10.0 Sep 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] 10.0 db cleanup #894

[MIG] 10.0 db cleanup #894

ecino commented Jul 10, 2017

pedrobaeza commented Jul 10, 2017

ecino commented Jul 10, 2017

ecino commented Jul 11, 2017

pedrobaeza commented Jul 11, 2017

ecino commented Jul 11, 2017

StefanRijnhart Jul 24, 2017

ecino Jul 24, 2017

StefanRijnhart Jul 24, 2017

ecino Jul 25, 2017

StefanRijnhart Jul 25, 2017

ecino Jul 26, 2017

StefanRijnhart Jul 25, 2017

ecino Jul 26, 2017

StefanRijnhart Jul 26, 2017

ecino Jul 26, 2017

StefanRijnhart Jul 26, 2017

StefanRijnhart Jul 26, 2017

ecino Jul 26, 2017

StefanRijnhart left a comment

hbrunn left a comment •

edited

hbrunn Aug 1, 2017

hbrunn Aug 1, 2017

hbrunn Aug 2, 2017

hbrunn Aug 2, 2017

moylop260 commented Aug 24, 2017

ecino commented Aug 24, 2017

hbrunn commented Sep 5, 2017

ecino commented Sep 5, 2017

[MIG] 10.0 db cleanup #894

[MIG] 10.0 db cleanup #894

Conversation

ecino commented Jul 10, 2017

pedrobaeza commented Jul 10, 2017

ecino commented Jul 10, 2017

ecino commented Jul 11, 2017

pedrobaeza commented Jul 11, 2017

ecino commented Jul 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StefanRijnhart left a comment

Choose a reason for hiding this comment

hbrunn left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moylop260 commented Aug 24, 2017

ecino commented Aug 24, 2017

hbrunn commented Sep 5, 2017

ecino commented Sep 5, 2017

hbrunn left a comment •

edited