[MIG] 10.0 db cleanup

.travis.yml

@@ -23,8 +23,10 @@ env:
   matrix:
   - LINT_CHECK="1"
   - TRANSIFEX="1"
-  - TESTS="1" ODOO_REPO="odoo/odoo"
-  - TESTS="1" ODOO_REPO="OCA/OCB"
+  - TESTS="1" ODOO_REPO="odoo/odoo" EXCLUDE="database_cleanup"
+  - TESTS="1" ODOO_REPO="OCA/OCB" EXCLUDE="database_cleanup"
+  - TESTS="1" ODOO_REPO="odoo/odoo" INCLUDE="database_cleanup"
+  - TESTS="1" ODOO_REPO="OCA/OCB" INCLUDE="database_cleanup"
 
 virtualenv:
   system_site_packages: true

database_cleanup/README.rst

@@ -6,13 +6,13 @@
 Database cleanup
 ================
 
-Clean your OpenERP database from remnants of modules, models, columns and
+Clean your Odoo database from remnants of modules, models, columns and
 tables left by uninstalled modules (prior to 7.0) or a homebrew database
-upgrade to a new major version of OpenERP.
+upgrade to a new major version of Odoo.
 
 Caution! This module is potentially harmful and can *easily* destroy the
 integrity of your data. Do not use if you are not entirely comfortable
-with the technical details of the OpenERP data model of *all* the modules
+with the technical details of the Odoo data model of *all* the modules
 that have ever been installed on your database, and do not purge any module,
 model, column or table if you do not know exactly what you are doing.
 
@@ -28,7 +28,7 @@ in one big step (if you are *really* confident).
 
 .. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
     :alt: Try me on Runbot
-    :target: https://runbot.odoo-community.org/runbot/149/9.0
+    :target: https://runbot.odoo-community.org/runbot/149/10.0
 
 Bug Tracker
 ===========

database_cleanup/__manifest__.py

@@ -3,7 +3,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 {
     'name': 'Database cleanup',
-    'version': '9.0.1.0.0',
+    'version': '10.0.1.0.0',
     'author': "Therp BV,Odoo Community Association (OCA)",
     'depends': ['base'],
     'license': 'AGPL-3',
@@ -16,7 +16,9 @@
         'views/purge_columns.xml',
         'views/purge_tables.xml',
         'views/purge_data.xml',
+        "views/create_indexes.xml",
+        'views/purge_properties.xml',
         'views/menu.xml',
     ],
-    'installable': False,
+    'installable': True,
 }

database_cleanup/i18n/database_cleanup.pot

@@ -4,7 +4,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: Odoo Server 8.0\n"
+"Project-Id-Version: Odoo Server 10.0\n"
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2015-08-11 06:45+0000\n"
 "PO-Revision-Date: 2015-08-11 06:45+0000\n"

database_cleanup/models/__init__.py

@@ -5,3 +5,6 @@
 from . import purge_tables
 from . import purge_data
 from . import purge_menus
+from . import ir_model_fields
+from . import create_indexes
+from . import purge_properties

database_cleanup/models/create_indexes.py

@@ -0,0 +1,82 @@
+# -*- coding: utf-8 -*-
+# © 2017 Therp BV <http://therp.nl>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+from ..identifier_adapter import IdentifierAdapter
+from odoo import api, fields, models
+
+
+class CreateIndexesLine(models.TransientModel):
+    _inherit = 'cleanup.purge.line'
+    _name = 'cleanup.create_indexes.line'
+
+    purged = fields.Boolean('Created')
+    wizard_id = fields.Many2one('cleanup.create_indexes.wizard')
+    field_id = fields.Many2one('ir.model.fields', required=True)
+
+    @api.multi
+    def purge(self):
+        tables = set()
+        for field in self.mapped('field_id'):
+            model = self.env[field.model]
+            name = '%s_%s_index' % (model._table, field.name)
+            self.env.cr.execute(
+                'create index %s ON %s (%s)',
+                (
+                    IdentifierAdapter(name, quote=False),
+                    IdentifierAdapter(model._table),
+                    IdentifierAdapter(field.name),
+                ),
+            )
+            tables.add(model._table)
+        for table in tables:
+            self.env.cr.execute(
+                'analyze %s', (IdentifierAdapter(model._table),)
+            )
+        self.write({
+            'purged': True,
+        })
+
+
+class CreateIndexesWizard(models.TransientModel):
+    _inherit = 'cleanup.purge.wizard'
+    _name = 'cleanup.create_indexes.wizard'
+    _description = 'Create indexes'
+
+    purge_line_ids = fields.One2many(
+        'cleanup.create_indexes.line', 'wizard_id',
+    )
+
+    @api.multi
+    def find(self):
+        res = list()
+        for field in self.env['ir.model.fields'].search([
+                ('index', '=', True),
+        ]):
+            if field.model not in self.env.registry:
+                continue
+            model = self.env[field.model]
+            name = '%s_%s_index' % (model._table, field.name)
+            self.env.cr.execute(
+                'select indexname from pg_indexes '
+                'where indexname=%s and tablename=%s',
+                (name, model._table)
+            )
+            if self.env.cr.rowcount:
+                continue
+
+            self.env.cr.execute(
+                'select a.attname '
+                'from pg_attribute a '
+                'join pg_class c on a.attrelid=c.oid '
+                'join pg_tables t on t.tablename=c.relname '
+                'where attname=%s and c.relname=%s',
+                (field.name, model._table,)
+            )
+            if not self.env.cr.rowcount:
+                continue
+
+            res.append((0, 0, {
+                'name': '%s.%s' % (field.model, field.name),
+                'field_id': field.id,
+            }))
+        return res

database_cleanup/models/ir_model_fields.py

@@ -0,0 +1,17 @@
+# -*- coding: utf-8 -*-
+# © 2014-2016 Therp BV <http://therp.nl>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+from openerp import api, models
+
+
+class IrModelFields(models.Model):
+    _inherit = 'ir.model.fields'
+
+    # In case of purging it means the model does not exist anymore in
+    # installed module. In this specific case, we need to avoid to check
+    # if fields can be removed as it would fail.
+    @api.multi
+    def _prepare_update(self):
+        if self.env.context.get('purge'):
+            self -= self.filtered(lambda x: x.model not in self.env.registry)
+        return super(IrModelFields, self)._prepare_update()

database_cleanup/models/purge_columns.py

@@ -1,8 +1,8 @@
 # -*- coding: utf-8 -*-
 # © 2014-2016 Therp BV <http://therp.nl>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
-from openerp import _, api, fields, models
-from openerp.exceptions import UserError
+from odoo import _, api, fields, models
+from odoo.exceptions import UserError
 from ..identifier_adapter import IdentifierAdapter
 
 
@@ -20,7 +20,12 @@ def purge(self):
         """
         Unlink columns upon manual confirmation.
         """
-        for line in self:
+        if self:
+            objs = self
+        else:
+            objs = self.env['cleanup.purge.line.column']\
+                .browse(self._context.get('active_ids'))
+        for line in objs:
             if line.purged:
                 continue
             model_pool = self.env[line.model_id.model]
@@ -71,12 +76,10 @@ def get_orphaned_columns(self, model_pools):
         of fields which have been removed
         """
         columns = list(set([
-            column
+            column.name
             for model_pool in model_pools
-            for column in model_pool._columns
-            if not (isinstance(model_pool._columns[column],
-                               fields.fields.function) and
-                    not model_pool._columns[column].store)
+            for column in model_pool._fields.values()
+            if not (column.compute is not None and not column.store)
         ]))
         columns += models.MAGIC_COLUMNS
         columns += self.blacklist.get(model_pools[0]._table, [])

database_cleanup/models/purge_data.py

@@ -1,8 +1,8 @@
 # -*- coding: utf-8 -*-
 # © 2014-2016 Therp BV <http://therp.nl>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
-from openerp import _, api, fields, models
-from openerp.exceptions import UserError
+from odoo import _, api, fields, models
+from odoo.exceptions import UserError
 from ..identifier_adapter import IdentifierAdapter
 
 
@@ -17,10 +17,15 @@ class CleanupPurgeLineData(models.TransientModel):
     @api.multi
     def purge(self):
         """Unlink data entries upon manual confirmation."""
-        to_unlink = self.filtered(lambda x: not x.purged and x.data_id)
+        if self:
+            objs = self
+        else:
+            objs = self.env['cleanup.purge.line.data']\
+                .browse(self._context.get('active_ids'))
+        to_unlink = objs.filtered(lambda x: not x.purged and x.data_id)
         self.logger.info('Purging data entries: %s', to_unlink.mapped('name'))
         to_unlink.mapped('data_id').unlink()
-        return self.write({'purged': True})
+        return to_unlink.write({'purged': True})
 
 
 class CleanupPurgeWizardData(models.TransientModel):

database_cleanup/models/purge_menus.py

@@ -1,8 +1,8 @@
 # -*- coding: utf-8 -*-
 # © 2014-2016 Therp BV <http://therp.nl>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
-from openerp import _, api, fields, models
-from openerp.exceptions import UserError
+from odoo import _, api, fields, models
+from odoo.exceptions import UserError
 
 
 class CleanupPurgeLineMenu(models.TransientModel):
@@ -15,8 +15,16 @@ class CleanupPurgeLineMenu(models.TransientModel):
 
     @api.multi
     def purge(self):
-        self.mapped('menu_id').unlink()
-        return self.write({'purged': True})
+        """Unlink menu entries upon manual confirmation."""
+        if self:
+            objs = self
+        else:
+            objs = self.env['cleanup.purge.line.menu']\
+                .browse(self._context.get('active_ids'))
+        to_unlink = objs.filtered(lambda x: not x.purged and x.menu_id)
+        self.logger.info('Purging menu entries: %s', to_unlink.mapped('name'))
+        to_unlink.mapped('menu_id').unlink()
+        return to_unlink.write({'purged': True})
 
 
 class CleanupPurgeWizardMenu(models.TransientModel):

database_cleanup/models/purge_models.py

@@ -1,41 +1,38 @@
 # -*- coding: utf-8 -*-
 # © 2014-2016 Therp BV <http://therp.nl>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
-from openerp import _, api, models, fields
-from openerp.exceptions import UserError
-from openerp.addons.base.ir.ir_model import MODULE_UNINSTALL_FLAG
+from odoo import _, api, models, fields
+from odoo.exceptions import UserError
+from odoo.addons.base.ir.ir_model import MODULE_UNINSTALL_FLAG
 
 
 class IrModel(models.Model):
     _inherit = 'ir.model'
 
-    @api.multi
     def _drop_table(self):
         # Allow to skip this step during model unlink
         # The super method crashes if the model cannot be instantiated
         if self.env.context.get('no_drop_table'):
             return True
         return super(IrModel, self)._drop_table()
 
-    @api.multi
-    def _inherited_models(self, field_name, arg):
+    @api.depends()
+    def _inherited_models(self):
         """this function crashes for undefined models"""
-        result = dict((i, []) for i in self.ids)
-        existing_model_ids = [
-            this.id for this in self if this.model in self.env
-        ]
-        super_result = super(IrModel, self.browse(existing_model_ids))\
-            ._inherited_models(field_name, arg)
-        result.update(super_result)
-        return result
-
-    def _register_hook(self, cr):
-        # patch the function field instead of overwriting it
-        if self._columns['inherited_model_ids']._fnct !=\
-                self._inherited_models.__func__:
-            self._columns['inherited_model_ids']._fnct =\
-                self._inherited_models.__func__
-        return super(IrModel, self)._register_hook(cr)
+        existing_model_ids = self.filtered(lambda x: x.model in self.env)
+        super(IrModel, existing_model_ids)._inherited_models()
+
+
+class IrModelFields(models.Model):
+    _inherit = 'ir.model.fields'
+
+    @api.multi
+    def _prepare_update(self):
+        # Allow to skip this step during model unlink
+        # The super method crashes if the model cannot be instantiated
+        if self.env.context.get('no_prepare_update'):
+            return True
+        return super(IrModelFields, self)._prepare_update()
 
 
 class CleanupPurgeLineModel(models.TransientModel):
@@ -54,9 +51,16 @@ def purge(self):
         context_flags = {
             MODULE_UNINSTALL_FLAG: True,
             'no_drop_table': True,
+            'purge': True,
+            'no_prepare_update': True,
         }
 
-        for line in self:
+        if self:
+            objs = self
+        else:
+            objs = self.env['cleanup.purge.line.model']\
+                .browse(self._context.get('active_ids'))
+        for line in objs:
             self.env.cr.execute(
                 "SELECT id, model from ir_model WHERE model = %s",
                 (line.name,))