Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] base_tier_validation: port to v12 #52

Merged
merged 16 commits into from
May 27, 2019
Merged

[12.0] base_tier_validation: port to v12 #52

merged 16 commits into from
May 27, 2019

Conversation

naglis
Copy link

@naglis naglis commented Feb 13, 2019

No description provided.

This was referenced Feb 13, 2019
Closed
Merged
@pedrobaeza pedrobaeza added this to the 12.0 milestone Feb 13, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 13, 2019
Closed
10 tasks
@LoisRForgeFlow
Copy link
Contributor

Hi @naglis, Thank you very much for your interest and work. Could you try to follow the steps here to preserve past commit history of the module? Let me know if you hava any problem in the process.

@LoisRForgeFlow
Copy link
Contributor

You may also be interested on review and include this improvement from v11: #48

@naglis
Copy link
Author

naglis commented Feb 14, 2019

Hi @naglis, Thank you very much for your interest and work. Could you try to follow the steps here to preserve past commit history of the module? Let me know if you hava any problem in the process.

@lreficent, missed this, thank you! Sure, will do that 👍

You may also be interested on review and include this improvement from v11: #48

I saw that PR, but since it is not merged I was skeptical about including it, since it might change still. Do you think it should be included in this PR or if it would be better to do it separately once it's merged?

@naglis naglis force-pushed the 12.0-mig-base-tier-validation branch from f4f24ec to 2da5736 Compare February 14, 2019 12:48
@LoisRForgeFlow
Copy link
Contributor

@naglis You can review the v11 PR so we can get it merged and then include it here, what do you think?

@LoisRForgeFlow
Copy link
Contributor

@naglis So 2 PR has been merged in v11. Can you add the commits here?. We should be ready to go after that.

LoisRForgeFlow and others added 16 commits February 18, 2019 15:02
@LoisRForgeFlow
[9.0][ADD] base_tier_validation
3cef934
@LoisRForgeFlow
fix: blocking unneded records
0099271
@LoisRForgeFlow
[9.0][IMP] base_tier_validation: tries automatically request validati…
0fa1068 
…on and validate if possible.
@LoisRForgeFlow
[9.0][IMP] base_tier_validation: filter out reviews not pending
bcf78ea
@LoisRForgeFlow
make possible to filter by validated records
095c1fa
@LoisRForgeFlow
allow to add exceptions for fields that can be written on under valid…
4047996 
…ation records
@LoisRForgeFlow
[9.0][IMP] base_tier_validation:
cf1cb49 
* able to restart validation
* sudo() not needed anymore
@LoisRForgeFlow
[10.0][MIG] base_tier_validation
12f151e
@LoisRForgeFlow
[11.0][MIG] base_tier_validation
b665fb7
@LoisRForgeFlow
[11.0][IMP] base_tier_validation: add tests
3776d64
@JordiBForgeFlow
add 'can_review' to tier.validation so that the buttons approve
27534c1 
and reject can be hidden according to this computed field.
@LoisRForgeFlow
[11.0][IMP] base_tier_validation: enhance views and register who does…
c855f4e 
… and who asks for reviews in new fields 'done_by' and 'requested_by'.
@AdriaGForgeFlow
[11.0][FIX] base_tier_validation
9ae6408
@AdriaGForgeFlow
Add name attribute to filter
e8d5339
@oca-travis
[UPD] Update base_tier_validation.pot
20c331c
[MIG] base_tier_validation: Migration to 12.0
847c43b
@naglis naglis force-pushed the 12.0-mig-base-tier-validation branch from 2da5736 to 847c43b Compare February 18, 2019 13:23
@naglis
Copy link
Author

naglis commented Feb 18, 2019 •
edited
Loading

@naglis So 2 PR has been merged in v11. Can you add the commits here?. We should be ready to go after that.

@lreficent, did that. Please review :)

LoisRForgeFlow
LoisRForgeFlow approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link
Contributor

I think we can merge this, and we'll open another PR to include de latest improvements from v12.

@pedrobaeza @jbeficent

@pedrobaeza pedrobaeza merged commit 6541ff2 into OCA:12.0 May 27, 2019
@naglis naglis deleted the 12.0-mig-base-tier-validation branch May 27, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@naglis @LoisRForgeFlow @OCA-git-bot @HviorForgeFlow @pedrobaeza @JordiBForgeFlow @AdriaGForgeFlow @oca-travis