-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0] base_tier_validation: port to v12 #52
Conversation
You may also be interested on review and include this improvement from v11: #48 |
@lreficent, missed this, thank you! Sure, will do that 👍
I saw that PR, but since it is not merged I was skeptical about including it, since it might change still. Do you think it should be included in this PR or if it would be better to do it separately once it's merged? |
f4f24ec
to
2da5736
Compare
@naglis You can review the v11 PR so we can get it merged and then include it here, what do you think? |
@naglis So 2 PR has been merged in v11. Can you add the commits here?. We should be ready to go after that. |
…on and validate if possible.
* able to restart validation * sudo() not needed anymore
and reject can be hidden according to this computed field.
… and who asks for reviews in new fields 'done_by' and 'requested_by'.
2da5736
to
847c43b
Compare
@lreficent, did that. Please review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks!
This PR has the |
I think we can merge this, and we'll open another PR to include de latest improvements from v12. @pedrobaeza @jbeficent |
No description provided.