Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][IMP] base_tier_validation: #48

Merged
merged 1 commit into from
Feb 15, 2019
Merged

[11.0][IMP] base_tier_validation: #48

merged 1 commit into from
Feb 15, 2019

Conversation

LoisRForgeFlow
Copy link
Contributor

  • enhance views.
  • register who does reviews in new field 'done_by'.
  • Update README.

HviorForgeFlow
HviorForgeFlow reviewed Jan 15, 2019
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature @lreficent, does it make sense to add a request_by one??

@LoisRForgeFlow
Copy link
Contributor Author

@hveficent Yes, it also makes sense, added!

@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Feb 14, 2019
Merged
HviorForgeFlow
HviorForgeFlow approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LoisRForgeFlow
[11.0][IMP] base_tier_validation: enhance views and register who does…
4caa0af 
… and who asks for reviews in new fields 'done_by' and 'requested_by'.
naglis
naglis approved these changes Feb 15, 2019
View reviewed changes
base_tier_validation/views/tier_definition_view.xml
<separator/>
<filter string="All" name="all" domain="['|', ('active', '=', False), ('active', '=', True)]" />
<group expand="0" string="Group By">
<filter string="Model" domain="[]" context="{'group_by':'model_id'}"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd propose to add a name attribute to the group by filter, since without it it:

  • It can't be selected with a xpath.
  • It can't be used with default_search_foo on an action context.

[source]

And it's required starting with Odoo 12.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JordiBForgeFlow JordiBForgeFlow merged commit f43115f into OCA:11.0 Feb 15, 2019
@HviorForgeFlow HviorForgeFlow mentioned this pull request Feb 15, 2019
Merged
@LoisRForgeFlow LoisRForgeFlow deleted the 11.0-imp-base_tier_validation branch February 18, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naglis naglis naglis approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LoisRForgeFlow @OCA-git-bot @naglis @HviorForgeFlow @JordiBForgeFlow