[13.0][MIG] date_range #95

MiquelRForgeFlow · 2019-09-30T10:00:37Z

Standard migration.

* [ADD] Basic structure for the new date range module * [IMP] Add a basic description into the README * [IMP] Basic implementation * [IMP] First working implementation * [IMP] Improve datamodel * [ADD] Add basic tests for date.range * [PEP8] * [PYLINT] * [DEL] Remove unused code * [IMP] Remove unsused dependencies into the JS * [IMP] Better operator label for date range * [DEL] Remove unused file * [IMP] Better user experience by showing the select input only once empty * [FIX]Try to fix tests that fails only on travis by adding an explicit cast on the daterange methods parameters * [FIX]Try to fix tests that fails only on travis by adding an explicit cast on the daterange methods parameters * [FIX]Try to fix tests that fails only on travis by using postgresql 9.4 * [FIX]Try with postgresql 9.2 since the daterange method has appeared in 9.2 * [IMP] Add a limitation into the module description to warm about the minimal version of postgresql to use * [IMP]Add multi-company rules * [IMP]Remove unused files * [FIX] Add missing brackets into JS * [FIX] Overlap detection when company_id is False * [IMP] Add default order for date.range * [IMP] Add date range generator * [FIX] OE compatibility * [FIX] Travis * [IMP] Code cleanup and improves test coverage * [FIX] Add missing dependency on 'web' * [PYLINT] remove unused import * [FIX] Add missing copyright * [FIX] Limits are included into the range * [IMP][date_range] Security * [IMP] Improve module description * [IMP] Spelling

* Improve 'name' for generator wizard ir.rule should be active by default * Don't auto-add '-' after prefix when generating date ranges via wizard * code fine tuning suggested by Sylvain Garancher

Currently translated at 89.1% (41 of 46 strings) Translation: server-ux-11.0/server-ux-11.0-date_range Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-date_range/ar/

If any module adds a required field on company, module fails. Executing it on post_install, there's no problem.

Currently translated at 82.6% (38 of 46 strings) Translation: server-ux-11.0/server-ux-11.0-date_range Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-date_range/da/

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 100.0% (46 of 46 strings) Translation: server-ux-12.0/server-ux-12.0-date_range Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-date_range/it/

Currently translated at 100.0% (46 of 46 strings) Translation: server-ux-12.0/server-ux-12.0-date_range Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-date_range/pt/

MiquelRForgeFlow · 2019-10-01T13:39:17Z

@lmignon These onchanges are not good to be replaced by a compute, because these onchanges are conditional. The computes in v13 only work when they are not conditional and always end filling the field. Moreover, the constrains already are a warranty.

I think this PR is ready as it is. Just test it functionally.

astirpe · 2019-10-01T13:44:05Z

Error #95 (comment) still reproducible in Runbot.

It's caused by the call to method read_slice() that cannot be used anymore (it's now placed in a folder named "_deprecated"). See https://github.com/odoo/odoo/blob/saas-12.5/addons/web/static/src/js/_deprecated/data.js#L411

MiquelRForgeFlow · 2019-10-01T14:53:16Z

It's weird. In v12 the read_slice() was already in the _deprecated folder.

astirpe · 2019-10-01T15:04:26Z

And I just noticed: when opening the web console of the browser, I get: Error while loading date_range.search_filters.

MiquelRForgeFlow · 2019-10-01T21:33:07Z

wip. help wanted for javascript thing.

MiquelRForgeFlow · 2019-10-02T20:40:15Z

@lmignon finally converted the onchanges to computes 😉

lmignon

Some comments into the code....
Nevertheless the JS part seems to not work

date_range/models/date_range.py

lmignon · 2019-10-07T08:22:01Z

date_range/static/src/js/date_range.js

+//            this._rpc({
+//                model: 'date.range',
+//                method: 'search_read',
+//                fields: ['name', 'date_start', 'date_end'],
+//                context: this.context,
+//                domain: ['type_id', '=', parseInt(type_id, 10)]]
+//                }).done(this.proxy('on_range_type_selected'));


@mreficent This code must be removed id it's no more needed

I added this code expressly to indicate what should be the way to fix the javascript error, this code should replace the next two lines. I put commented instead because it's not correct yet.

lmignon · 2019-10-07T08:22:14Z

date_range/static/src/js/date_range.js

+//                this._rpc({
+//                    model: 'date.range.type',
+//                    method: 'search_read',
+//                    fields: ['name'],
+//                    context: this.context,
+//                    }).done(this.proxy('add_date_range_types_operator'));


@mreficent This code must be removed id it's no more needed

I added this code expressly to indicate what should be the way to fix the javascript error, this code should replace the next two lines. I put commented instead because it's not correct yet.

@mreficent Is this PR therefore still a WIP?

It's stated in #95 (comment).

date_range/tests/test_date_range.py

date_range/tests/test_date_range_generator.py

date_range/wizard/date_range_generator.py

lmignon · 2019-10-18T10:21:11Z

@mreficent I've fixed the JS, rebased the branch on 13.0 and fixed pre-commit issues in #99. It was not possible to PR your branch with mine due to the rebase. Can I close this one? Everything is working now

pedrobaeza · 2019-10-18T10:28:48Z

He is today on holidays, but I think there's no problem on that while you preserve his commit for proper attribution. We are all working in the same goal, which is having this migrated 😃

I dare to close it in advance.

lmignon · 2019-10-18T10:30:59Z

@pedrobaeza of course the commit history is preserved 😏 I close it.

pedrobaeza · 2019-10-18T10:32:06Z

Yeah, I don't doubt about that coming from you. That's why I closed it directly.

lmignon and others added 30 commits September 30, 2019 11:37

OCA Transbot updated translations from Transifex

b4d3597

[10.0][MIGRATION] Migrated module 'date_range' to V10

92a3eb1

OCA Transbot updated translations from Transifex

7dd1532

[REF] date_range: Use 'index' instead of 'select'

fc89ba4

OCA Transbot updated translations from Transifex

245e78f

[IMP] date_range: Several things

68a85c0

* Improve 'name' for generator wizard ir.rule should be active by default * Don't auto-add '-' after prefix when generating date ranges via wizard * code fine tuning suggested by Sylvain Garancher

OCA Transbot updated translations from Transifex

a4c64a6

[10.0][FIX][date_range] Periods of one day should be allowed (#947)

f042f48

[MIG] date_range

1340369

[MIG] date_range: Adapt JS to new framework

d63dd2c

Fix unlink date range type.

3156c88

[IMP] date_range: adapt to multicompany

f144ea2

[IMP] date_range: new README structure

4e1713f

[UPD] README.rst

1f4eacd

[UPD] Update date_range.pot

7efb492

Translated using Weblate (Arabic)

cd679a7

Currently translated at 89.1% (41 of 46 strings) Translation: server-ux-11.0/server-ux-11.0-date_range Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-date_range/ar/

[IMP] date_range: Pass integration tests

0bffc0d

If any module adds a required field on company, module fails. Executing it on post_install, there's no problem.

[UPD] README.rst

7fc5f60

[UPD] Update date_range.pot

1ec7c96

Translated using Weblate (Danish)

339594d

Currently translated at 82.6% (38 of 46 strings) Translation: server-ux-11.0/server-ux-11.0-date_range Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-date_range/da/

[12.0][MIG] date_range

f5af3a0

eslint

6df4cea

[UPD] README.rst

51b904d

[FIX] date_range: Remove useless post_install flag for tests

8472b8a

[UPD] Update date_range.pot

80e075d

Update translation files

5d65a17

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Translated using Weblate (Italian)

8e7f5d8

Currently translated at 100.0% (46 of 46 strings) Translation: server-ux-12.0/server-ux-12.0-date_range Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-date_range/it/

Translated using Weblate (Portuguese)

92853f6

Currently translated at 100.0% (46 of 46 strings) Translation: server-ux-12.0/server-ux-12.0-date_range Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-date_range/pt/

[UPD] README.rst

fba13ec

MiquelRForgeFlow force-pushed the 13.0-mig-date_range branch from ab21b6a to a6922ee Compare October 1, 2019 19:04

MiquelRForgeFlow force-pushed the 13.0-mig-date_range branch 3 times, most recently from ec73b8d to 7f61b56 Compare October 2, 2019 20:39

OCA-git-bot mentioned this pull request Oct 3, 2019

Migration to version 13.0 #93

Closed

12 tasks

This was referenced Oct 5, 2019

[13.0][MIG] l10n_es_aeat OCA/l10n-spain#1188

Closed

[13.0][MIG] l10n_es_aeat OCA/l10n-spain#1189

Closed

lmignon requested changes Oct 7, 2019

View reviewed changes

[MIG] date_range: Migration to 13.0

855dcef

MiquelRForgeFlow force-pushed the 13.0-mig-date_range branch from 7f61b56 to 855dcef Compare October 7, 2019 11:32

lmignon added help wanted work in progress labels Oct 7, 2019

lmignon added this to the 13.0 milestone Oct 7, 2019

This was referenced Oct 10, 2019

[13.0][MIG] l10n_nl_tax_statement OCA/l10n-netherlands#243

Merged

[13.0][MIG] account_fiscal_year OCA/account-financial-tools#898

Closed

MiquelRForgeFlow mentioned this pull request Oct 16, 2019

[13.0][MIG] account_fiscal_year OCA/account-financial-tools#900

Merged

1 task

lmignon mentioned this pull request Oct 18, 2019

[13.0] [MIG] date_range #99

Merged

pedrobaeza closed this Oct 18, 2019

MiquelRForgeFlow deleted the 13.0-mig-date_range branch October 21, 2019 10:29

bhaveshselarka mentioned this pull request Jan 8, 2020

[WIP][13.0] account_financial_report: migrate OCA/account-financial-reporting#620

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0][MIG] date_range #95

[13.0][MIG] date_range #95

MiquelRForgeFlow commented Sep 30, 2019

MiquelRForgeFlow commented Oct 1, 2019

astirpe commented Oct 1, 2019

MiquelRForgeFlow commented Oct 1, 2019 •

edited

Loading

astirpe commented Oct 1, 2019

MiquelRForgeFlow commented Oct 1, 2019 •

edited

Loading

MiquelRForgeFlow commented Oct 2, 2019

lmignon left a comment •

edited

Loading

lmignon Oct 7, 2019

MiquelRForgeFlow Oct 7, 2019

lmignon Oct 7, 2019

MiquelRForgeFlow Oct 7, 2019

lmignon Oct 7, 2019

MiquelRForgeFlow Oct 7, 2019

lmignon commented Oct 18, 2019

pedrobaeza commented Oct 18, 2019

lmignon commented Oct 18, 2019

pedrobaeza commented Oct 18, 2019

[13.0][MIG] date_range #95

[13.0][MIG] date_range #95

Conversation

MiquelRForgeFlow commented Sep 30, 2019

MiquelRForgeFlow commented Oct 1, 2019

astirpe commented Oct 1, 2019

MiquelRForgeFlow commented Oct 1, 2019 • edited Loading

astirpe commented Oct 1, 2019

MiquelRForgeFlow commented Oct 1, 2019 • edited Loading

MiquelRForgeFlow commented Oct 2, 2019

lmignon left a comment • edited Loading

Choose a reason for hiding this comment

lmignon Oct 7, 2019

Choose a reason for hiding this comment

MiquelRForgeFlow Oct 7, 2019

Choose a reason for hiding this comment

lmignon Oct 7, 2019

Choose a reason for hiding this comment

MiquelRForgeFlow Oct 7, 2019

Choose a reason for hiding this comment

lmignon Oct 7, 2019

Choose a reason for hiding this comment

MiquelRForgeFlow Oct 7, 2019

Choose a reason for hiding this comment

lmignon commented Oct 18, 2019

pedrobaeza commented Oct 18, 2019

lmignon commented Oct 18, 2019

pedrobaeza commented Oct 18, 2019

MiquelRForgeFlow commented Oct 1, 2019 •

edited

Loading

MiquelRForgeFlow commented Oct 1, 2019 •

edited

Loading

lmignon left a comment •

edited

Loading