[13.0] [MIG] date_range #99
Conversation
* [ADD] Basic structure for the new date range module * [IMP] Add a basic description into the README * [IMP] Basic implementation * [IMP] First working implementation * [IMP] Improve datamodel * [ADD] Add basic tests for date.range * [PEP8] * [PYLINT] * [DEL] Remove unused code * [IMP] Remove unsused dependencies into the JS * [IMP] Better operator label for date range * [DEL] Remove unused file * [IMP] Better user experience by showing the select input only once empty * [FIX]Try to fix tests that fails only on travis by adding an explicit cast on the daterange methods parameters * [FIX]Try to fix tests that fails only on travis by adding an explicit cast on the daterange methods parameters * [FIX]Try to fix tests that fails only on travis by using postgresql 9.4 * [FIX]Try with postgresql 9.2 since the daterange method has appeared in 9.2 * [IMP] Add a limitation into the module description to warm about the minimal version of postgresql to use * [IMP]Add multi-company rules * [IMP]Remove unused files * [FIX] Add missing brackets into JS * [FIX] Overlap detection when company_id is False * [IMP] Add default order for date.range * [IMP] Add date range generator * [FIX] OE compatibility * [FIX] Travis * [IMP] Code cleanup and improves test coverage * [FIX] Add missing dependency on 'web' * [PYLINT] remove unused import * [FIX] Add missing copyright * [FIX] Limits are included into the range * [IMP][date_range] Security * [IMP] Improve module description * [IMP] Spelling
* Improve 'name' for generator wizard ir.rule should be active by default * Don't auto-add '-' after prefix when generating date ranges via wizard * code fine tuning suggested by Sylvain Garancher
Currently translated at 89.1% (41 of 46 strings) Translation: server-ux-11.0/server-ux-11.0-date_range Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-date_range/ar/
If any module adds a required field on company, module fails. Executing it on post_install, there's no problem.
Currently translated at 82.6% (38 of 46 strings) Translation: server-ux-11.0/server-ux-11.0-date_range Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-date_range/da/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (46 of 46 strings) Translation: server-ux-12.0/server-ux-12.0-date_range Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-date_range/it/
Currently translated at 100.0% (46 of 46 strings) Translation: server-ux-12.0/server-ux-12.0-date_range Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-date_range/pt/
|
Please check runbot warning: |
|
@pedrobaeza If I use de Pypi package name, pylint fails 😒 a pylint issue I suppose? |
|
Well, I'm only saying about the thing that makes runbot CI red. But isn't that an Odoo requirement? Do we need to declare explicitly in this module? I don't think so. |
|
@pedrobaeza Yes it's an odoo requirement. I don't know why we must now declare this dependency compared to 12.0 but I'm not choked to have to do it since it's always better to not rely on transitively acquired dependencies when explicitly using one of them. I don't know how to solve the issue in this specfic case... |
|
It needs to evolve to avoid conflict with the local isort config, and handle the new python dependency mechanism of Odoo 13 (referencing PyPI distribution names instead of import name). In the meantime it does no harm to add the dependency explicitly. |
Except for the runbot warning... |
|
@lmignon The manifest must say |
|
@sbidoul but in this case, pylint fails... |
|
Ah yes, sorry. Then the pylint check must be temporarily disabled in |
|
@sbidoul OK I'll do like proposed |
Pylint-odoo is not able to detect properly whitelisted odoo's dependencies if an isort configuration file is present into the directory. Therefore the check fails by complaining that the dateutil dependecy is not declared into the manifest. A fix could have been to declare the dependency into the manifest . Unfortunately, in this case, a warning will be issued by runbot complaining that the python external dependency dateutil should be replaced by it's PyPI package name. Unfortunalely, if we put the Pypi package name into the external dependencies, pylint fails again since it's not able to play with PyPI distribution names. The workaround is to temporarily disable this check into pylint. I every case, all the pre-commit files will be reset once pylint will be fixed
lmignon
force-pushed
the
13.0-migrate-daterange-lmi
branch
from
5ca40cd
to
6dc3479
Compare
|
/ocabot merge |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
This PR has the |
|
Congratulations, your PR was merged at 7e4c455. Thanks a lot for contributing to OCA. ❤️ |
fixes and supersedes #95