-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] mail_outbound_static #1259
Conversation
* Allow for the configuration of the FROM header for outbound emails, and move the existing from header to Sender as per RFC-2822
Fixing and extending tests Add setup
Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>
use sudo to get ir.config_parameter, otherwise when normal users try to send email they get AccessError
- fix misspellings errors in documentation - add unit test to avoid github checkers red status in codecov tests. - add validation of email from and domain whitelist fields. - update documentation remove roadmap for already updated functionalities. - update translations
Since 15.0, smtp info is prepared in _prepare_email_message() which is called from send_email(), and the smtp info manipulation should be done in this method instead of in send_email().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review 👍
/ocabot migration mail_outbound_static |
This PR has the |
I keep getting this warning in the log? XML declarations in HTML module descriptions are deprecated since Odoo 17, mail_outbound_static can just have a UTF8 description with not need for a declaration. |
19a96e9
to
12ae8dc
Compare
@CasVissers-360ERP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running on live migrated v17 db.
@@ -0,0 +1 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed i guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed i guess
@francesco-ooops Removed.
12ae8dc
to
19aecb1
Compare
Does this module make sense anymore? We already have from filters upstream since 16.0. Check out: https://www.odoo.com/documentation/16.0/applications/general/email_communication/email_servers.html#use-a-default-from-email-address |
some times this module is nedded in case the mail server is provide by Microsoft with office 365 |
This module is also used for multi company purposes too |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at c638171. Thanks a lot for contributing to OCA. ❤️ |
No description provided.