Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] mail_outbound_static #1259

Merged
merged 34 commits into from
Dec 28, 2023
Merged

[17.0][MIG] mail_outbound_static #1259

merged 34 commits into from
Dec 28, 2023

Conversation

SodexisTeam
Copy link
Member

No description provided.

lasley and others added 30 commits November 21, 2023 13:15
@lasley
ADD mail_outbound_static: Allow configuration of from email header
32d934a 
* Allow for the configuration of the FROM header for outbound emails, and move the existing from header to Sender as per RFC-2822
@eLBati
Port mail_outbound_static to 12.0
997c00e 
Fixing and extending tests
Add setup
@eLBati @yajo
Update website in mail_outbound_static/__manifest__.py
9eb9585 
Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>
@oca-travis
[UPD] Update mail_outbound_static.pot
15c1f4c
@OCA-git-bot
[UPD] README.rst
b4e566a
@BT-fgarbely
[MIG] mail_outbound_static: Migration to 13.0
f64086c
@BT-fgarbely
[IMP] mail_outbound_static: black, isort, prettier
7206175
@oca-travis
[UPD] Update mail_outbound_static.pot
ea479a2
@OCA-git-bot
[UPD] README.rst
bdfc53e
@eLBati
[FIX] 13.0 mail_outbound_static
71b50fc 
use sudo to get ir.config_parameter, otherwise when normal users try to
send email they get AccessError
@OCA-git-bot
mail_outbound_static 13.0.1.0.1
3d6be90
@pierre-pizzetta
[MIG] mail_outbound_static: Migration to 14.0
afa00ae
@oca-travis
[UPD] Update mail_outbound_static.pot
0beedef
@zaoral
mail_outbound_static: Domain whitelist based logic.
3309100
@zaoral
new changes to squash after review:
89e5ba2 
- fix misspellings errors in documentation
- add unit test to avoid github checkers red status in codecov tests.
- add validation of email from and domain whitelist fields.
- update documentation remove roadmap for already updated functionalities.
- update translations
@rousseldenis
[14.0][FIX] mail_outbound_static: Apply pre-commit
3ab4666
@yankinmax
[IMP] mail_outbound_static: black, isort, prettier
032b43b
@yankinmax
[MIG] mail_outbound_static: Migration to 15.0
42e0392
@yankinmax
[IMP] mail_outbound_static: pylint
c712893
@yankinmax
fixup! [MIG] mail_outbound_static: Migration to 15.0
1dc9a1d
[UPD] Update mail_outbound_static.pot
2edbccc
@victoralmau
[FIX] mail_outbound_static: Remove warning
54f05f0
@dreispt
[MIG] mail_outbound_static: Migration to 16.0
f5e6221
[UPD] Update mail_outbound_static.pot
ba5645b
@OCA-git-bot
[UPD] README.rst
5f24a54
@yostashiro
[FIX] Move smtp info update logic to _prepare_email_message()
ea40115 
Since 15.0, smtp info is prepared in _prepare_email_message() which is called
from send_email(), and the smtp info manipulation should be done in this method
instead of in send_email().
@are-agilebg
Align maximum length of TLD to DNS limit (63 chars)
a8d8873
@OCA-git-bot
[UPD] README.rst
0cc4404
@OCA-git-bot
mail_outbound_static 16.0.1.0.1
71d8562
@OCA-git-bot
[UPD] README.rst
ea00c57
atchuthan
atchuthan approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@atchuthan atchuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review 👍

@SodexisTeam SodexisTeam changed the title 17.0 mig mail outbound static [17.0][MIG] mail_outbound_static Nov 21, 2023
@SodexisTeam SodexisTeam mentioned this pull request Nov 23, 2023
Open
30 tasks
@pedrobaeza
Copy link
Member

/ocabot migration mail_outbound_static

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 24, 2023
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CasVissers-360ERP
Copy link

I keep getting this warning in the log?

XML declarations in HTML module descriptions are deprecated since Odoo 17, mail_outbound_static can just have a UTF8 description with not need for a declaration.

@SodexisTeam
Copy link
Member Author

SodexisTeam commented Dec 6, 2023 •
edited
Loading

I keep getting this warning in the log?

XML declarations in HTML module descriptions are deprecated since Odoo 17, mail_outbound_static can just have a UTF8 description with not need for a declaration.

@CasVissers-360ERP
This recent commit odoo/odoo@9429986 impacted this deprecated warning. It has been fixed. Please check now.

CasVissers-360ERP
CasVissers-360ERP approved these changes Dec 6, 2023
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running on live migrated v17 db.

francesco-ooops
francesco-ooops reviewed Dec 14, 2023
View reviewed changes
mail_outbound_static/readme/ROADMAP.md Outdated
@@ -0,0 +1 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed i guess

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed i guess

@francesco-ooops Removed.

@yajo
Copy link
Member

yajo commented Dec 14, 2023

Does this module make sense anymore? We already have from filters upstream since 16.0. Check out: https://www.odoo.com/documentation/16.0/applications/general/email_communication/email_servers.html#use-a-default-from-email-address

@matteoopenf
Copy link

Does this module make sense anymore? We already have from filters upstream since 16.0. Check out: https://www.odoo.com/documentation/16.0/applications/general/email_communication/email_servers.html#use-a-default-from-email-address

some times this module is nedded in case the mail server is provide by Microsoft with office 365

@atchuthan
Copy link
Member

Does this module make sense anymore? We already have from filters upstream since 16.0. Check out: https://www.odoo.com/documentation/16.0/applications/general/email_communication/email_servers.html#use-a-default-from-email-address

This module is also used for multi company purposes too

@dreispt
Copy link
Sponsor Member

dreispt commented Dec 28, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1259-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 23e45e8 into OCA:17.0 Dec 28, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c638171. Thanks a lot for contributing to OCA. ❤️

@atchuthan atchuthan deleted the 17.0-mig-mail_outbound_static branch January 2, 2024 09:08
@nilshamerlinck nilshamerlinck mentioned this pull request Feb 15, 2024
Closed
nilshamerlinck pushed a commit to nilshamerlinck/social that referenced this pull request Feb 15, 2024
@OCA-git-bot
Merge PR OCA#1259 into 17.0
7fa67d4 
Signed-off-by dreispt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francesco-ooops francesco-ooops francesco-ooops left review comments

@dreispt dreispt dreispt approved these changes

@atchuthan atchuthan atchuthan approved these changes

@amkarthik amkarthik amkarthik approved these changes

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.