[10.0] Improving the mail tracking value #170

TDu · 2017-06-07T13:09:51Z

Improve the tracking of changed values on database fields
("mail.tracking.value" functionality) by adding many2many and one2many support.
As well as a more user friendly view to consult changes recorded.

guewen · 2017-06-07T13:48:02Z

@rafaelbn Travis is failing due to an error with Mailgun. The 10.0 branch is failing as well, do you have an idea why?

Travis logs of the 10.0 branch (https://travis-ci.org/OCA/social/jobs/234268290#L745-L746):

Mailgun: Database 'bad_db' is not the current database
Mailgun: event type 'bad_event' not supported
Mailgun: Invalid signature 'bad_signature' != '4fb6d4dbbe10ce5d620265dcd7a3c0b8ca0dede1433103891bc1ae4086e9d5b2'

simahawk · 2017-06-08T10:39:58Z

mail_improved_tracking_value/models/mail_tracking_value.py

+
+    _inherit = "mail.tracking.value"
+
+    new_value_formated = fields.Char(compute='_compute_formatted_value',


missing a "t" in fields name

Thanks, fixed

simahawk · 2017-06-08T10:46:55Z

mail_improved_tracking_value/models/mail_tracking_value.py

+    def _compute_formatted_value(self):
+        """ Sets the value formatted field used in the view """
+        for record in self:
+            if record.field_type in ('many2many', 'one2many', 'char'):


can't we do something better here? Just guessing.... maybe we can use qweb widgets to render values in human readable mode?

According to the type, the values are stored in different fields, we just want to read the value from the correct field. There is no need for a particular rendering more than that.

yes, is not required, I'm just saying that since the formatted value is always a char we can format it using qweb rendering (especially for date, datetime, monetary, etc)

@simahawk ah I get it, indeed it makes sense for date, datetime, monetary, ... Can be a future improvement :)

@TDu can you add a comment here to remind this improvement and add a line in the README roadmap?

rafaelbn

Tested functionally. I think module's name must be tracking_value_improved, please change if possible

rafaelbn · 2017-06-08T22:16:10Z

mail_improved_tracking_value/README.rst

+
+To access the new view displaying value changes :
+
+    Settings -> Technical -> Improved tracking values


Better -> Tracking Values Improved

That's not correct English, Rafa

rafaelbn · 2017-06-08T22:19:51Z

mail_improved_tracking_value/__manifest__.py

+    'name': 'Improved tracking value change',
+    'version': '10.0.1.0.0',
+    'summary': 'Improves tracking changes by adding many2many and one2many \
+                    support. As well as a view to consult changes',


This description is for user, normal people, they must understand what module makes but they don't know what's a many2many o similar. Please explain it from the functional point of view not a technical one

Additionally there is a bunch of whitespace being added here. The strings should instead be started and stopped.

'my first line. '
'my second line.'

Ok, changed description and removed whitespaces.

rafaelbn · 2017-06-08T22:31:48Z

mail_improved_tracking_value/__manifest__.py

+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+{
+    'name': 'Improved tracking value change',


IMHO: Tracking value change improved

rafaelbn · 2017-06-08T23:37:34Z

Please @carlosdauden could you check #170 (comment) thanks!

lasley · 2017-06-08T23:48:35Z

mail_improved_tracking_value/README.rst

+===========
+
+Bugs are tracked on `GitHub Issues
+<https://github.com/OCA/{project_repo}/issues>`_. In case of trouble, please


lasley · 2017-06-08T23:49:14Z

mail_improved_tracking_value/__manifest__.py

+    'name': 'Improved tracking value change',
+    'version': '10.0.1.0.0',
+    'summary': 'Improves tracking changes by adding many2many and one2many \
+                    support. As well as a view to consult changes',


Additionally there is a bunch of whitespace being added here. The strings should instead be started and stopped.

'my first line. '
'my second line.'

lasley · 2017-06-08T23:50:06Z

mail_improved_tracking_value/models/mail_tracking_value.py

+
+import json
+
+from odoo import models, fields, api


Alphabetize imports

pedrobaeza · 2017-08-03T10:53:12Z

Rebase as branch is already green

TDu · 2017-10-02T14:09:39Z

Change to the readme following comments.
And rebase is done.

simahawk

@TDu can you get back on this? 😄
BTW I triggered runbot rebuild as it was killed

simahawk · 2018-03-29T06:54:06Z

mail_improved_tracking_value/models/mail_tracking_value.py

+    def _compute_formatted_value(self):
+        """ Sets the value formatted field used in the view """
+        for record in self:
+            if record.field_type in ('many2many', 'one2many', 'char'):


@TDu can you add a comment here to remind this improvement and add a line in the README roadmap?

TDu · 2018-03-29T09:40:13Z

I added the comment in the code and readme about improving the rendering depending of value type.
Seems like I needed a memory refresh about this module...

rafaelbn · 2018-04-14T00:05:08Z

Hello, just a question before merging. Is there any possibility you add some test to improve codecov/patch — 28.57% of diff hit (target 97.13%). ? Please? 🙏

We have been working hard to have high coverage in this repo .

Thanks!

TDu · 2018-04-16T08:55:00Z

Yes sure, will do.
I also think it would be good to have some test for it.

Improve the tracking of changed values on database fields ("mail.tracking.value" functionality) by adding many2many and one2many support. As well as a more user friendly view to consult changes recorded.

TDu · 2018-04-26T11:27:53Z

@rafaelbn Tests are done, coverage three digits number 😁

rafaelbn · 2018-04-26T22:07:48Z

Thank you!!!

Improve the tracking of changed values on database fields ("mail.tracking.value" functionality) by adding many2many and one2many support. As well as a more user friendly view to consult changes recorded.

TDu force-pushed the improve-tracking-value branch 2 times, most recently from 03df92e to 5cfe1a5 Compare June 7, 2017 13:29

guewen approved these changes Jun 8, 2017

View reviewed changes

simahawk requested changes Jun 8, 2017

View reviewed changes

TDu force-pushed the improve-tracking-value branch from 5cfe1a5 to 57e3495 Compare June 8, 2017 11:00

yajo added the needs review label Jun 8, 2017

yajo added this to the 10.0 milestone Jun 8, 2017

simahawk approved these changes Jun 8, 2017

View reviewed changes

TDu force-pushed the improve-tracking-value branch 2 times, most recently from 7857fe2 to b8ec2e4 Compare June 8, 2017 13:07

rafaelbn requested a review from antespi June 8, 2017 21:49

rafaelbn approved these changes Jun 8, 2017

View reviewed changes

lasley reviewed Jun 8, 2017

View reviewed changes

TDu force-pushed the improve-tracking-value branch from b8ec2e4 to 8b2770b Compare June 9, 2017 07:15

TDu force-pushed the improve-tracking-value branch 2 times, most recently from 4e528c7 to 40796ba Compare October 2, 2017 13:58

simahawk requested changes Mar 29, 2018

View reviewed changes

simahawk approved these changes Mar 29, 2018

View reviewed changes

TDu force-pushed the improve-tracking-value branch from 1668d07 to e5c9292 Compare March 29, 2018 09:41

mpanarin mentioned this pull request Apr 5, 2018

[MIG] mail_improved_tracking_value: migration to Odoo 11 #254

Closed

guewen mentioned this pull request Apr 11, 2018

Many2many with track_visibility shows ids in place of names odoo/odoo#10149

Closed

TDu force-pushed the improve-tracking-value branch 2 times, most recently from 2f024c1 to e8c10bf Compare April 20, 2018 14:16

TDu force-pushed the improve-tracking-value branch 3 times, most recently from 7939834 to 26236f9 Compare April 26, 2018 10:55

[10.0] Improving the mail tracking value

b0c5065

Improve the tracking of changed values on database fields ("mail.tracking.value" functionality) by adding many2many and one2many support. As well as a more user friendly view to consult changes recorded.

TDu force-pushed the improve-tracking-value branch from 26236f9 to b0c5065 Compare April 26, 2018 11:01

rafaelbn merged commit fc4cccb into OCA:10.0 Apr 26, 2018

ThomasBinsfeld mentioned this pull request Jul 6, 2018

[9.0] [MIG] Backport mail_improved_tracking_value #290

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.0] Improving the mail tracking value #170

[10.0] Improving the mail tracking value #170

TDu commented Jun 7, 2017

guewen commented Jun 7, 2017

simahawk Jun 8, 2017

TDu Jun 8, 2017

simahawk Jun 8, 2017

guewen Jun 8, 2017

simahawk Jun 8, 2017

guewen Jun 8, 2017

simahawk Mar 29, 2018

TDu Mar 29, 2018

rafaelbn left a comment

rafaelbn Jun 8, 2017

pedrobaeza Jun 8, 2017

rafaelbn Jun 8, 2017

lasley Jun 8, 2017

TDu Jun 9, 2017 •

edited

Loading

rafaelbn Jun 8, 2017

rafaelbn commented Jun 8, 2017

lasley Jun 8, 2017

lasley Jun 8, 2017

lasley Jun 8, 2017

pedrobaeza commented Aug 3, 2017

TDu commented Oct 2, 2017

simahawk left a comment

simahawk Mar 29, 2018

TDu commented Mar 29, 2018

rafaelbn commented Apr 14, 2018

TDu commented Apr 16, 2018

TDu commented Apr 26, 2018

rafaelbn commented Apr 26, 2018


		_inherit = "mail.tracking.value"

		new_value_formated = fields.Char(compute='_compute_formatted_value',


		To access the new view displaying value changes :

		Settings -> Technical -> Improved tracking values

[10.0] Improving the mail tracking value #170

[10.0] Improving the mail tracking value #170

Conversation

TDu commented Jun 7, 2017

guewen commented Jun 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaelbn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TDu Jun 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaelbn commented Jun 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Aug 3, 2017

TDu commented Oct 2, 2017

simahawk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TDu commented Mar 29, 2018

rafaelbn commented Apr 14, 2018

TDu commented Apr 16, 2018

TDu commented Apr 26, 2018

rafaelbn commented Apr 26, 2018

TDu Jun 9, 2017 •

edited

Loading