-
-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] mail_improved_tracking_value: migration to Odoo 11 #254
Conversation
Improve the tracking of changed values on database fields ("mail.tracking.value" functionality) by adding many2many and one2many support. As well as a more user friendly view to consult changes recorded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we already have many reviews on v10 I think you have to include that commit and add a new one for v11 mig
Thank you! Agree with @simahawk in #254 (review) Also is possible to add some test. it should be very nice codecov/patch — 23.8% of diff hit (target 87.44%) |
Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0 |
Gives an error message if trying to delete a one2may line tracked:
|
|
||
def get_values(source, prefix): | ||
if source: | ||
names = ', '.join(source.mapped('display_name')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
names = ', '.join(source.mapped('display_name')) | |
names = ', '.join( | |
[s.display_name for s in source.exists()]) |
If you do this, you avoid the Missing Record
error for one2many, but then the message doesn't show the deleted record 😕
In fact, the best way I found to track a one2many is creating a computed char and tracking it, like I did in https://github.com/Eficent/ao-odoo/pull/121/files#diff-4a0c09c64bab72fb4713db84f0c2358dR25. |
Superseded by #678. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
migration of module #170