Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] mail_improved_tracking_value: migration to Odoo 11 #254

Closed

Conversation

mpanarin
Copy link

@mpanarin mpanarin commented Apr 5, 2018

migration of module #170

Improve the tracking of changed values on database fields
("mail.tracking.value" functionality) by adding many2many and one2many support.
As well as a more user friendly view to consult changes recorded.
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we already have many reviews on v10 I think you have to include that commit and add a new one for v11 mig

@rafaelbn rafaelbn added this to the 11.0 milestone Apr 14, 2018
@rafaelbn
Copy link
Member

Thank you! Agree with @simahawk in #254 (review)

Also is possible to add some test. it should be very nice codecov/patch — 23.8% of diff hit (target 87.44%)

@rafaelbn
Copy link
Member

rafaelbn commented May 2, 2018

Hi @mpanarin , please could you attend @simahawk comments ? Thank you!

@pedrobaeza
Copy link
Member

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

@tdombos
Copy link

tdombos commented Aug 10, 2018

Gives an error message if trying to delete a one2may line tracked:

Odoo Server Error - Missing Record
Record does not exist or has been deleted.


def get_values(source, prefix):
if source:
names = ', '.join(source.mapped('display_name'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
names = ', '.join(source.mapped('display_name'))
names = ', '.join(
[s.display_name for s in source.exists()])

If you do this, you avoid the Missing Record error for one2many, but then the message doesn't show the deleted record 😕

@MiquelRForgeFlow
Copy link
Contributor

In fact, the best way I found to track a one2many is creating a computed char and tracking it, like I did in https://github.com/Eficent/ao-odoo/pull/121/files#diff-4a0c09c64bab72fb4713db84f0c2358dR25.

@MiquelRForgeFlow
Copy link
Contributor

MiquelRForgeFlow commented Feb 22, 2021

Superseded by #678.

@github-actions
Copy link

github-actions bot commented Dec 5, 2021

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 5, 2021
@simahawk simahawk closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants