[MIG][mass_mailing_custom_unsubscribe] Migrate to v10 #178
Conversation
|
|
||
| #. Go to *Marketing > Configuration > Unsubscription Reasons*. |
There was a problem hiding this comment.
Mass Mailing > Configuration > Unsubscription Reasons
| <tree> | ||
| <field name="name"/> | ||
| <field name="details_required"/> | ||
| <field name="sequence" invisible="True"/> |
There was a problem hiding this comment.
widget="handle" would fit here quite well
| <field name="date"/> | ||
| <field name="mass_mailing_id"/> | ||
| <field name="unsubscriber_id"/> | ||
| <field name="email"/> |
There was a problem hiding this comment.
Isn't it weird that the email isn't get whenever the unsubscriber_id change?
There was a problem hiding this comment.
This is in purpose. The email where the unsusbscription came from must be stored, no matter the target unusbscriber. But in fact, this whole view should be readonly, at least for normal users, so I'll change that.
There was a problem hiding this comment.
This has been fixed now by adding edition permissions only to admins.
|
|
||
| - Choose which mailing lists are not cross-unsubscriptable when unsubscribing | ||
| from a different one. | ||
| - Know why and when a contact as been unsubscribed from a mass mailing. |
| <small>[EN] You can unsubscribe <a href="%(url)s">here</a></small><br/> | ||
| <small>[ES] Puedes darte de baja <a href="%(url)s">aquí</a></small> | ||
|
|
||
| * This module adds a security hash for mass mailing unsubscription URLs, which |
There was a problem hiding this comment.
Isn't this already includes in v10?
There was a problem hiding this comment.
No, it's v11: odoo/odoo#12040
There was a problem hiding this comment.
Please add them a comment on code and on README for serving as reminder on v11 migration.
| 'category': 'Marketing', | ||
| 'version': '8.0.1.0.0', | ||
| 'version': '10.0.2.0.0', |
| 'demo/assets.xml', | ||
| ], | ||
| 'images': [ | ||
| 'images/form.png', | ||
| ], | ||
| 'author': 'Antiun Ingeniería S.L., ' |
yajo
force-pushed
the
10.0-mass_mailing_custom_unsubscribe
branch
from
252cc69
to
4cd7485
Compare
|
All changed, I also did a full rebase to get fixed some commit messages that got stripped when using method prior to https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0/_compare/e6543dbec279c6108b7274b34d8d4f2f08d3f855 |
|
Please check Travis |
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
- Imported last updates from v8. - Adapted to v9. - Added a saner default to `mass_mailing.salt` configuration parameter by reusing `database.secret` if available, hoping that some day odoo/odoo#12040 gets merged. - Updated README. - Increase security, drop backwards compatibility. Security got improved upstream, which would again break compatibility among current addon and future master upstream. I choose to break it now and keep it secured future-wise, so I drop the backwards compatibility features. - Includes tour tests. - Removes outdated tests. - Extends the mailing list management form when unsubscriber is a contact. - Adds a reason form even if he is not. - Avoids all methods that were not model-agnostic. [FIX][mass_mailing_custom_unsubscribe] Reasons noupdate After this fix, when you update the addon, you will not lose your customized reasons. [FIX] Compatibilize with mass_mailing_partner Current test code was based on the assumption that the `@api.model` decorator on `create()` ensured an empty recordset when running the method, but that's not true. This was causing an incompatibility betwee these tests and the `mass_mailing_partner` addon, which works assuming 0-1 recordsets. Now records are created from an empty recordset, and thus tests work everywhere. Update instructions If the user does not add the unsubscribe snippet, nothing will happen, so it's added to README to avoid confusion when testing/using the addon. [FIX] Use the right operator to preserve recordsets order Using `|=` sorts records at will each time (treating them as Python's `set`). Using `+=` always appends a record to the end of the set. Since we are using the record position in the set, this caused the test to work sometimes and fail other times. Now it works always.
yajo
force-pushed
the
10.0-mass_mailing_custom_unsubscribe
branch
from
d598781
to
5dc6c87
Compare
|
I think the problem was #181, so I rebased. Let's see... |
@Tecnativa