-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription #58
[8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription #58
Conversation
…ption. Now you can know why an unsubscription was made.
Since they were not visible, I'm renaming them to under this module's namespace, but since it could have been used in production somewhere, I add a migration. The controller and view logic are simplified, images are added, README is improved, and some bugs are fixed by the way.
3116e13
to
a079324
Compare
This one should be ready to review, please somebody label as such 😊 |
@@ -8,10 +8,16 @@ Customizable unsubscription process on mass mailing emails | |||
With this module you can set a custom unsubscribe link appended at the bottom | |||
of mass mailing emails. | |||
|
|||
It also displays a beautiful and simple unsubscription form when somebody | |||
unsubscribes, to let you know why he left; and then displays to him a beautiful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use he/him. Better to use an inpersonal style. Remove that parts from the sentence. The meaning is the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also displays a beautiful and simple unsubscription form when somebody unsubscribes, to let you know why; and then displays a beautiful...
All should be ready now. |
2d1b70a
to
29d0ad9
Compare
29d0ad9
to
8ba3676
Compare
====================== | ||
|
||
* This module adds a security hash for mass mailing unsubscription URLs, which | ||
makes URLs of mass mailing messages sent before its installation not work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/makes URLs.../makes to not work anymore URLs... (and remove it from the end).
I got late here, but absolutely thank you @lasley! 🎉 |
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
* [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
Now you can know why an unsubscription was made.
@Tecnativa.