[FIX] mail_debrand: name of overridden method #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanRijnhart
force-pushed
the
fix/8.0-mail-debrand_method_name
branch
from
200b7b5
to
ab479eb
Compare
|
There was a previous attempt at #176, but it misses the tests fix. |
StefanRijnhart
changed the title
|
Please change module version number |
StefanRijnhart
force-pushed
the
fix/8.0-mail-debrand_method_name
branch
from
ab479eb
to
0360e94
Compare
yajo
requested changes
Nov 7, 2017
StefanRijnhart
force-pushed
the
fix/8.0-mail-debrand_method_name
branch
from
0360e94
to
01acc44
Compare
|
@yajo I fixed the lint error related to this change but the odoo/odoo build fails just like on the main branch (and I don't know how to fix timeouts in http tests anyway) |
|
Agh, same problem everywhere out of Odoo itself. There's a general problem with Travis + wkhtmltopdf, which reproduces the same way. Don't know if this one is the same. |
yajo
approved these changes
Nov 8, 2017
There was a problem hiding this comment.
Besides, there's an error in another addon.
OK, not blocking then
hbrunn
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://github.com/odoo/odoo/blob/8.0/addons/mail/mail_followers.py#L138.
@yajo, this one is a bit of a mystery. I could not find any trace of this method name with the preceding underscore.