[11.0][mail_activity_done] add new module to keep activities that have been completed. #296

JordiBForgeFlow · 2018-08-22T23:28:30Z

This module implements the capability to keep activities that have been
completed, for future reporting, by setting them with the boolean 'Done'.

The activities that have been completed will not appear in the chatter.

elicoidal

LGTM (details)

elicoidal · 2018-08-23T02:35:51Z

mail_activity_done/hooks.py

+                mail_activity_type_id=activity.activity_type_id.id,
+            )
+            message |= record.message_ids[0]
+        # ----  START OF PATCH


remove dead code

I think he wants to let clear for reviewers where is the patch.

elicoidal · 2018-08-23T02:37:36Z

mail_activity_done/static/src/js/mail_activity.js

@@ -0,0 +1,73 @@
+//-*- coding: utf-8 -*-
+//Copyright2018 Eficent <http://www.eficent.com>
+//License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).


AGPL or LGPL?

should be LGPL

MiquelRForgeFlow

LGTM

MiquelRForgeFlow · 2018-08-24T14:50:53Z

mail_activity_done/hooks.py

+    if not cr.fetchone():
+        cr.execute(
+            """
+            ALTER TABLE mail_activity ADD COLUMN done boolean;


What happens if the table is empty but already has the column done?

If the column exists it won't enter the if clause and won't create the column, right?

hbrunn · 2018-08-28T12:48:56Z

please fix lints

MiquelRForgeFlow · 2018-08-28T14:15:27Z

@hbrunn lints fixed

hbrunn · 2018-08-28T14:24:47Z

thanks, now we only need tests

dajuayen · 2018-09-16T20:19:19Z

In the tree view it is possible to add a different color for the activities done that allows to distinguish them from the overdue. Ex:

<record id="mail_activity_view_tree" model="ir.ui.view">
    <field name="name">mail.activity.view.tree</field>
    <field name="model">mail.activity</field>
    <field name="inherit_id" ref="mail.mail_activity_view_tree"/>
    <field name="arch" type="xml">
        <xpath expr="//tree" position="attributes">
            <attribute name="decoration-info">(state == 'done')</attribute>
        </xpath>
        <field name="date_deadline" position="after">
            <field name="state"/>
        </field>
    </field>
</record>

The definition in the mail module of this view adds colors according to its 'state'. If a color is not added to the 'Done' state, all activities will end up with the 'Overdue' color.
And the list would look something like this:

dajuayen · 2018-11-02T09:56:15Z

@jbeficent @hbrunn
Would you allow me to give you a hand for the tests?

JordiBForgeFlow · 2018-11-02T16:27:52Z

@dajuayen I have added colors and other small improvements. Please feel free to contribute and add tests! :)

dajuayen · 2018-11-04T11:40:47Z

@jbeficent Sorry for the question, but how can I contribute to the PR? I have tried to make a fork of your code and when I make the fork of 'social' your module does not appear to me. If I upload a commit with new development, I'm probably going to do a new PR and I do not think that's the right procedure. What should I do is a PR to your last commit?

JordiBForgeFlow · 2018-11-04T12:13:27Z

In order to contribute to myPR you have to clone my branch. git remote add Eficent git://github.com/Eficent/social git fetch Eficent git checkout eficent-mail_activity _done -b Eficent/mail_activity_done Then do your changes and push to you owr repo. Then push to your repo. From there create a PR and set as target my repo and my current branch. Is it clear? El dom., 4 nov. 2018 12:40, Dajuayen <notifications@github.com> escribió:

…

@jbeficent <https://github.com/jbeficent> Sorry for the question, but how can I contribute to the PR? I have tried to make a fork of your code and when I make the fork of 'social' your module does not appear to me. If I upload a commit with new development, I'm probably going to do a new PR and I do not think that's the right procedure. What should I do is a PR to your last commit? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#296 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHU_Vv6_KIinvrvPD_WZ8VCEJ8LgWtjnks5urtJAgaJpZM4WIlDR> .

dajuayen · 2018-11-04T13:57:39Z

Thanks for the response and the help. I think I understand what you tell me, but: ``` git checkout eficent-mail_activity _done -b Eficent / mail_activity_done ``` so I think with ``` git checkout 11.0-eficent-mail_activity_done ``` It was enough. I also wanted to tell you that for certain questions that may arise it would be interesting that there was an issue related to this PR, what do you think? El dom., 4 nov. 2018 a las 13:13, Jordi Ballester Alomar (< notifications@github.com>) escribió:

…

In order to contribute to myPR you have to clone my branch. git remote add Eficent git://github.com/Eficent/social git fetch Eficent git checkout eficent-mail_activity _done -b Eficent/mail_activity_done Then do your changes and push to you owr repo. Then push to your repo. From there create a PR and set as target my repo and my current branch. Is it clear? El dom., 4 nov. 2018 12:40, Dajuayen ***@***.***> escribió: > @jbeficent <https://github.com/jbeficent> Sorry for the question, but how > can I contribute to the PR? I have tried to make a fork of your code and > when I make the fork of 'social' your module does not appear to me. If I > upload a commit with new development, I'm probably going to do a new PR and > I do not think that's the right procedure. What should I do is a PR to your > last commit? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#296 (comment)>, or mute > the thread > < https://github.com/notifications/unsubscribe-auth/AHU_Vv6_KIinvrvPD_WZ8VCEJ8LgWtjnks5urtJAgaJpZM4WIlDR > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#296 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADmsM0sJIlI8VkPxXhFpYpnODDfg5TnVks5urtnpgaJpZM4WIlDR> .

JordiBForgeFlow · 2018-11-04T14:38:40Z

Just write on the PR your questions. El dom., 4 nov. 2018 14:57, Dajuayen <notifications@github.com> escribió:

…

Thanks for the response and the help. I think I understand what you tell me, but: `` ` git checkout eficent-mail_activity _done -b Eficent / mail_activity_done `` ` so I think with `` ` git checkout 11.0-eficent-mail_activity_done `` ` It was enough. I also wanted to tell you that for certain questions that may arise it would be interesting that there was an issue related to this PR, what do you think? El dom., 4 nov. 2018 a las 13:13, Jordi Ballester Alomar (< ***@***.***>) escribió: > In order to contribute to myPR you have to clone my branch. > > git remote add Eficent git://github.com/Eficent/social > > git fetch Eficent > > git checkout eficent-mail_activity _done -b Eficent/mail_activity_done > > Then do your changes and push to you owr repo. Then push to your repo. From > there create a PR and set as target my repo and my current branch. > > > Is it clear? > > > El dom., 4 nov. 2018 12:40, Dajuayen ***@***.***> escribió: > > > @jbeficent <https://github.com/jbeficent> Sorry for the question, but > how > > can I contribute to the PR? I have tried to make a fork of your code and > > when I make the fork of 'social' your module does not appear to me. If I > > upload a commit with new development, I'm probably going to do a new PR > and > > I do not think that's the right procedure. What should I do is a PR to > your > > last commit? > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > <#296 (comment)>, or mute > > the thread > > < > https://github.com/notifications/unsubscribe-auth/AHU_Vv6_KIinvrvPD_WZ8VCEJ8LgWtjnks5urtJAgaJpZM4WIlDR > > > > . > > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#296 (comment)>, or mute > the thread > < https://github.com/notifications/unsubscribe-auth/ADmsM0sJIlI8VkPxXhFpYpnODDfg5TnVks5urtnpgaJpZM4WIlDR > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#296 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHU_Vsv5J5s3gwFM_gnE7L4m-0bPsrbJks5urvJUgaJpZM4WIlDR> .

JordiBForgeFlow · 2019-01-13T18:31:35Z

@ageficent can you squash the commits, and prepare a PR for v12?

LoisRForgeFlow · 2019-01-14T09:20:01Z

mail_activity_done/tests/test_mail_activity_done.py

+        self.assertEquals(self.act1.state, 'done')
+
+    def test_activity_user_count(self):
+        self.employee.activity_user_count()


An assert after this will make more sense

JordiBForgeFlow · 2019-01-17T07:37:42Z

@ageficent can you attend the open comments? And consider the. Also for v12 PR?

have been completed. fixup moment js fixup

AdriaGForgeFlow · 2019-01-18T08:32:45Z

@ageficent can you attend the open comments? And consider the. Also for v12 PR?

Done 👍

HviorForgeFlow

LGTM 👍

JordiBForgeFlow requested review from LoisRForgeFlow, MiquelRForgeFlow and HviorForgeFlow August 22, 2018 23:29

JordiBForgeFlow force-pushed the 11.0-mail_activity_done branch from f2ef8b8 to d624a9c Compare August 22, 2018 23:33

JordiBForgeFlow mentioned this pull request Aug 22, 2018

[11.0][mail] mail activities shall not be deleted for reporting purposes odoo/odoo#26531

Closed

elicoidal approved these changes Aug 23, 2018

View reviewed changes

MiquelRForgeFlow approved these changes Aug 24, 2018

View reviewed changes

hbrunn added the needs fixing label Aug 28, 2018

hbrunn added this to the 11.0 milestone Aug 28, 2018

hbrunn added needs tests This PR is correct, but lowers test coverage and removed needs fixing labels Aug 28, 2018

dajuayen mentioned this pull request Sep 20, 2018

[11.0][mail_activity_board] Add new module that insert activities board in boards. #283

Merged

HviorForgeFlow force-pushed the 11.0-mail_activity_done branch 6 times, most recently from f9d0f4c to 1cadd25 Compare November 9, 2018 11:17

AdriaGForgeFlow force-pushed the 11.0-mail_activity_done branch from db6f515 to 0285b0b Compare January 14, 2019 07:14

AdriaGForgeFlow mentioned this pull request Jan 14, 2019

[12.0][MIG] mail_activity_done #354

Merged

LoisRForgeFlow mentioned this pull request Jan 14, 2019

Show done activities? #353

Closed

LoisRForgeFlow reviewed Jan 14, 2019

View reviewed changes

OCA-git-bot added the approved label Jan 14, 2019

[11.0][mail_activity_done] add new module to keep activities that

9277952

have been completed. fixup moment js fixup

AdriaGForgeFlow force-pushed the 11.0-mail_activity_done branch from 989a5b0 to 9277952 Compare January 18, 2019 08:31

HviorForgeFlow approved these changes Jan 18, 2019

View reviewed changes

JordiBForgeFlow merged commit 8eca724 into OCA:11.0 Jan 25, 2019

MiquelRForgeFlow deleted the 11.0-mail_activity_done branch January 25, 2019 16:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][mail_activity_done] add new module to keep activities that have been completed. #296

[11.0][mail_activity_done] add new module to keep activities that have been completed. #296

JordiBForgeFlow commented Aug 22, 2018

elicoidal left a comment

elicoidal Aug 23, 2018

MiquelRForgeFlow Aug 24, 2018

elicoidal Aug 23, 2018

MiquelRForgeFlow Aug 24, 2018

MiquelRForgeFlow left a comment

MiquelRForgeFlow Aug 24, 2018

AdriaGForgeFlow Jan 18, 2019

MiquelRForgeFlow Jan 18, 2019

hbrunn commented Aug 28, 2018

MiquelRForgeFlow commented Aug 28, 2018

hbrunn commented Aug 28, 2018

dajuayen commented Sep 16, 2018

dajuayen commented Nov 2, 2018

JordiBForgeFlow commented Nov 2, 2018

dajuayen commented Nov 4, 2018

JordiBForgeFlow commented Nov 4, 2018 via email

dajuayen commented Nov 4, 2018 via email •

edited

Loading

JordiBForgeFlow commented Nov 4, 2018 via email

JordiBForgeFlow commented Jan 13, 2019

LoisRForgeFlow Jan 14, 2019

AdriaGForgeFlow Jan 18, 2019

JordiBForgeFlow commented Jan 17, 2019

AdriaGForgeFlow commented Jan 18, 2019

HviorForgeFlow left a comment

[11.0][mail_activity_done] add new module to keep activities that have been completed. #296

[11.0][mail_activity_done] add new module to keep activities that have been completed. #296

Conversation

JordiBForgeFlow commented Aug 22, 2018

elicoidal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hbrunn commented Aug 28, 2018

MiquelRForgeFlow commented Aug 28, 2018

hbrunn commented Aug 28, 2018

dajuayen commented Sep 16, 2018

dajuayen commented Nov 2, 2018

JordiBForgeFlow commented Nov 2, 2018

dajuayen commented Nov 4, 2018

JordiBForgeFlow commented Nov 4, 2018 via email

dajuayen commented Nov 4, 2018 via email • edited Loading

JordiBForgeFlow commented Nov 4, 2018 via email

JordiBForgeFlow commented Jan 13, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JordiBForgeFlow commented Jan 17, 2019

AdriaGForgeFlow commented Jan 18, 2019

HviorForgeFlow left a comment

Choose a reason for hiding this comment

dajuayen commented Nov 4, 2018 via email •

edited

Loading