12.0 mig mail_tracking_mailgun #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
something with your dependencies seems wrong |
|
sorry, didn't read the first message... |
24 tasks
|
Please rebase |
…ent events (OCA#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
Both Carlos and me have work a lot in this module, maybe not coding but much testing and definition in usability
When this method is called without an event (a.k.a. `event=None`), this method produces the following error:
```
Traceback (most recent call last):
File "/opt/odoo/auto/addons/mail/models/mail_mail.py", line 278, in send
res = IrMailServer.send_email(msg, mail_server_id=mail.mail_server_id.id)
File "/opt/odoo/auto/addons/mail_tracking/models/ir_mail_server.py", line 88, in send_email
tracking_email.smtp_error(self, smtp_server_used, e)
File "/opt/odoo/auto/addons/mail_tracking/models/mail_tracking_email.py", line 213, in smtp_error
self.sudo()._partners_email_bounced_set('error')
File "/opt/odoo/auto/addons/mail_tracking/models/mail_tracking_email.py", line 203, in
_partners_email_bounced_set
]).email_bounced_set(self, reason, event=event)
File "/opt/odoo/auto/addons/mail_tracking_mailgun/models/res_partner.py", line 22, in
email_bounced_set
self._email_bounced_set(reason, event)
File "/opt/odoo/auto/addons/mail_tracking_mailgun/models/res_partner.py", line 33, in
_email_bounced_set
event['Message-Id'] or '') TypeError: 'NoneType' object has no attribute '__getitem__'
```
So, we now assume we do not always have an event.
- Configurable partner email auto check.
- json.load() in python under 3.6 doesn't support binary input. - https://docs.python.org/3/whatsnew/3.6.html#json - This way, we let requests to decode the response itself.
- Some res.partner form fields were not properly render due to this module inherited view.
Currently translated at 16.7% (4 of 24 strings) Translation: social-11.0/social-11.0-mail_tracking_mailgun Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking_mailgun/fr/
- In case the sending domain is different from the one configured in the mail.domain.catchall setting.
Besides Mailgun API url changes if the domain zone is in UE, it remains the same for Validation API.
- In v11 only admins can read from ir.config_parameter so a sudo() must be made to be able to get a parameter.
ernestotejeda
force-pushed
the
12.0-mig-mail_tracking_mailgun
branch
from
1ac4e80
to
39cded6
Compare
|
rebased |
pedrobaeza
reviewed
Jan 9, 2019
ernestotejeda
force-pushed
the
12.0-mig-mail_tracking_mailgun
branch
from
39cded6
to
19d9d2e
Compare
pedrobaeza
approved these changes
Jan 11, 2019
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #318
Cc @Tecnativa