-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0] porting mail_outbound_static #388
Conversation
* Allow for the configuration of the FROM header for outbound emails, and move the existing from header to Sender as per RFC-2822
b70df75
to
c6bf803
Compare
c6bf803
to
8840a2d
Compare
Looks good to me. |
LGTM 👍 odoo/odoo#20911 is taking too much time |
@yajo this is about DMARC conformity odoo/odoo#20911 |
Hi @eLBati do you have budget to increase test? codecov/patch — 82.6% of diff hit (target 95%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixing and extending tests Add setup
8840a2d
to
059c897
Compare
@rafaelbn increased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you know it, but you can do the static address enforcement with a local SMTP relay. It has the other advantage that odoo will get emails as sent quicker, and that a downtime of the real SMTP server won't block odoo. We support https://hub.docker.com/r/tecnativa/postfix-relay/ for these and other use cases.
Just in case you want to save one addon to maintain. 😉
OTOH this PR seems good.
This PR has the |
Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>
@yajo thanks, that's a useful information. I think an odoo module can be useful anyway, so that an odoo admin is not required to have SMTP server skills to achieve this goal |
Indeed. /ocabot merge |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at f703241. Thanks a lot for contributing to OCA. ❤️ |
Since odoo is still not DMARC compliant (odoo/odoo#20911), I propose this module as workaround, from #195