Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] porting mail_outbound_static #388

Merged
merged 3 commits into from
Sep 11, 2019

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented May 24, 2019

Since odoo is still not DMARC compliant (odoo/odoo#20911), I propose this module as workaround, from #195

* Allow for the configuration of the FROM header for outbound emails, and move the existing from header to Sender as per RFC-2822
@dreispt
Copy link
Sponsor Member

dreispt commented Jul 8, 2019

Looks good to me.

@hurrinico
Copy link

LGTM 👍 odoo/odoo#20911 is taking too much time

@rafaelbn rafaelbn added this to the 12.0 milestone Sep 4, 2019
@rafaelbn rafaelbn requested a review from yajo September 4, 2019 22:00
@rafaelbn
Copy link
Member

rafaelbn commented Sep 4, 2019

@yajo this is about DMARC conformity odoo/odoo#20911

@rafaelbn
Copy link
Member

rafaelbn commented Sep 4, 2019

Hi @eLBati do you have budget to increase test? codecov/patch — 82.6% of diff hit (target 95%)

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Fixing and extending tests
Add setup
@eLBati eLBati force-pushed the 12.0-mig-mail_outbound_static branch from 8840a2d to 059c897 Compare September 5, 2019 10:50
@eLBati
Copy link
Member Author

eLBati commented Sep 5, 2019

@rafaelbn increased

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you know it, but you can do the static address enforcement with a local SMTP relay. It has the other advantage that odoo will get emails as sent quicker, and that a downtime of the real SMTP server won't block odoo. We support https://hub.docker.com/r/tecnativa/postfix-relay/ for these and other use cases.

Just in case you want to save one addon to maintain. 😉

OTOH this PR seems good.

mail_outbound_static/__manifest__.py Outdated Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>
@eLBati
Copy link
Member Author

eLBati commented Sep 11, 2019

@yajo thanks, that's a useful information.

I think an odoo module can be useful anyway, so that an odoo admin is not required to have SMTP server skills to achieve this goal

@yajo
Copy link
Member

yajo commented Sep 11, 2019

Indeed.

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-388-by-Yajo-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 11, 2019
Signed-off-by Yajo
@OCA-git-bot OCA-git-bot merged commit 8ba3262 into OCA:12.0 Sep 11, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f703241. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants