[10.0][FIX] barcodes_generator_abstract: Caching issue

[lasley]

• Make cache method return ids & move the recordset method out of cache to fix OperationalError: Unable to use a closed cursor. #93

[pedrobaeza]

Isn't better to call to .invalidate() before reading data?

[lasley]

@pedrobaeza - What is the invalidate()? I know of _clear_cache, which is called in the create and write, which should invalidate when we need it to. Am I missing a nuance?

[pedrobaeza]

Sorry, I mean invalidate_cache:

https://github.com/odoo/odoo/blob/cf8985e37d48ead868c83a4589b2f755f57de379/odoo/models.py#L5252

[lasley]

Oh crap I'm using the wrong methods. Thanks Pedro!

[pedrobaeza]

@lasley actually you are right about not storing in ORM cache a browse_record. See odoo/odoo#8795 for a similar case.

[lasley]

Good call, thanks for the confirmation and Odoo core example case @pedrobaeza. I feel like this is worthy of documentation, so I created odoo/odoo#19113.

I think you're still right about the use of invalidate_cache though - I can't even find _clear_cache in the Odoo 10 codebase. I find it strange where the hell I would have gotten this method - this wasn't even migrated code 😑

I'll make the fix today

Edit: Ughhh I needed coffee. I'm using clear_caches - will still double check the necessity, but will also leave the above so you can laugh at me if you'd like

[piqoni]

Thanks for this fix, any idea when will this be merged? I also got the same cursor error and this fixed it. :)

[legalsylvain]

Hi @lasley. Sorry but I don't understand cache system very well, so I'm not the person the most adapted to review this change. (I never used @tools.ormcache)

thanks for investigating this bug.

I'm sure that @StefanRijnhart, or other core experts will have a more interesting point of view than mine.

regards.

[lasley]

@piqoni - We need two reviews to merge, one from someone with write access. If you have reviewed and confirmed this works, please add it officially in Files Changed => Review Changes => Approve

[StefanRijnhart]

Thanks!

[pedrobaeza]

Please change module version number

[lasley]

It's interesting how many people I call out on version numbers, but how many times I screw up the exact same thing myself.

Done!