Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] product_gtin: Migration to 13.0 #351

Merged
merged 37 commits into from
Oct 18, 2021
Merged

[13.0][MIG] product_gtin: Migration to 13.0 #351

merged 37 commits into from
Oct 18, 2021

Conversation

victoralmau
Copy link
Member

Migration to 13.0

Please @joao-p-marques and @pedrobaeza can you review it?

@Tecnativa TT30724

mga-odoo and others added 30 commits July 6, 2021 11:52
@mga-odoo @victoralmau
account_indian is a branch of the trunk addons
b9f7b22 
          make account_indian up to date with the trunk-extra-addons
(/home/gbaconnier/code/openerp/extra-addons/lp6.1-main rev 3288.4.56)
@victoralmau
[ADD] added fr_BE.po file for modules
911c7c8 
      [IMP] modify some existing files and solve some errors on modules
(/home/gbaconnier/code/openerp/extra-addons/lp6.1-main rev 4060.1.5)
@victoralmau
[ADD]product_*:added template file
8232811 
(/home/gbaconnier/code/openerp/extra-addons/lp6.1-main rev 4196.1.3)
@odony @victoralmau
[I18N] all: additional (partial) translations, courtesy of swedish tr…
c1b7be1 
…anslation team (Anders Erikkson <ae@mobilasystem.se>)

(/home/gbaconnier/code/openerp/extra-addons/lp6.1-main rev 5092.1.49)
@victoralmau
obsolete
3bb0477 
(/home/gbaconnier/code/openerp/extra-addons/lp6.1-main rev 5145)
@victoralmau
[MERGE]
b56f6ea 
(/home/gbaconnier/code/openerp/extra-addons/lp6.1-main rev 5383.1.5)
@guewen @victoralmau
[MIGR] set installable to False on all the modules, the flag has to b…
b4e6338 
…e reactivated when the modules are migrated
@gurneyalex @victoralmau
[DEL] remove product_gtin to replace it with chricar_product_gtin fro…
1f89922 
…m c2c-rd-addons
@gurneyalex @victoralmau
renamed chricar_product_gtin to product_gtin
b21b1ab
@gurneyalex @victoralmau
start porting to v7 OCA standards
c75b702
@victoralmau
Port to v7 coding standards.
d3382c5 
Fix logical bug in constraint function (only the last ID was really checked !)
Re-generate POT file.
Update link from wikipedia DE to wikipedia EN.
@victoralmau
removed useless view file
cf1858e
@victoralmau
Set all addons to uninstallable and move them into __unported__ folder
7a68274
@victoralmau
product_gtin: port to v8
8efc414 
Rename badly-named variable: ean13_len -> ean_len
Small code simplification
@lmignon @victoralmau
[ADD] also supports EAN11
9f4079b
@chafique-delli @victoralmau
add search on EAN in product
de9a411
@chafique-delli @victoralmau
using 'attributes' in place of 'replace' for extend product search
59e27a7
@chafique-delli @victoralmau
add check method for ean8, ean13 and upc
7e43549
@chafique-delli @victoralmau
pep8 compliant
6ed7ae5
@chafique-delli @victoralmau
use a dynamic dispatch for call methods
7f6d1b3
@chafique-delli @victoralmau
replace list of len(eancode) by dictionnary DICT_CHECK_EAN
05f3630
@bealdav @victoralmau
[IMP] refactor message calls
88fb658
@yvaucher @victoralmau
Add license key in __openerp__.py
023f8d7
@gurneyalex @victoralmau
Add OCA as author of OCA addons
499ef46 
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@gurneyalex @victoralmau
fix travis (flake8)
aa8b829
@victoralmau
[IMP] add unittests to product_gtin module
f2459a5 
It seems checks does not fully test the code. At this point, we need
to figures out what wrong with the code, the checks or the tests.
@victoralmau
[IMP] update product_gtin to reinforce the checks of ean8, ean13 and …
6265db1 
…upc.
@victoralmau
[IMP] product_gtin: pep8 and minor update of the doc.
f22a4fe
@yvaucher @victoralmau
Add missing default oca icons
e3d9aed
@sbidoul @victoralmau
[UPD] prefix versions with 8.0
6116f43
pedrobaeza
pedrobaeza requested changes Jul 6, 2021
View reviewed changes
product_gtin/models/abstract_barcodenumber.py Outdated Show resolved Hide resolved
product_gtin/models/abstract_barcodenumber.py Outdated Show resolved Hide resolved
product_gtin/models/product_product.py Outdated Show resolved Hide resolved
product_gtin/models/product_product.py Outdated Show resolved Hide resolved
product_gtin/views/product_view.xml Outdated Show resolved Hide resolved
@victoralmau victoralmau force-pushed the 13.0-mig-product_gtin branch 2 times, most recently from 029bcdd to cde93c9 Compare July 6, 2021 14:57
@victoralmau
Copy link
Member Author

Thanks @pedrobaeza changes done.
Any idea to prevent incompatibility with other addons like stock_barcodes_gs1?. Maybe we need to add custom context skip_barcode_gtin_check=True in stock_barcodes_gs1 tests.

@pedrobaeza
Copy link
Member

I think no error should be arisen if the length is different from the GTIN expected ones.

joao-p-marques
joao-p-marques suggested changes Jul 7, 2021
View reviewed changes
Copy link
Member

@joao-p-marques joao-p-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Looks good, apart from this small comments 👍

product_gtin/models/product_product.py Outdated Show resolved Hide resolved
product_gtin/tests/test_product_gtin_functions.py Outdated Show resolved Hide resolved
product_gtin/tests/test_product_gtin_functions.py Outdated Show resolved Hide resolved
@rousseldenis rousseldenis mentioned this pull request Jul 7, 2021
Closed
9 tasks
joao-p-marques
joao-p-marques approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@joao-p-marques joao-p-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review 👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-351-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 14, 2021
@OCA-git-bot
Merge PR #351 into 13.0
559667a 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@victoralmau
Copy link
Member Author

It seems that the bot has locked, can you launch it again?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-351-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7c4ba25 into OCA:13.0 Oct 18, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cd98738. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

@joao-p-marques joao-p-marques joao-p-marques approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.