Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] stock_picking_report_valued #181

Merged
merged 18 commits into from
Aug 17, 2022
Merged

[15.0][MIG] stock_picking_report_valued #181

merged 18 commits into from
Aug 17, 2022

Conversation

flachica
Copy link
Contributor

No description provided.

Luis M. Ontalba and others added 13 commits February 23, 2022 13:13
@flachica
[11.0][MIG] stock_valued_picking_report
0b608e7
@carlosdauden @flachica
[IMP] stock_picking_report_valued: Improve code
57e0b8a
@pedrobaeza @flachica
[IMP] stock_picking_report_valued: Perform related & compute with sudo
9ba1d0b 
For avoiding problems if you don't have access to sales orders (stricter
warehouse users, inter-company records...).
@chienandalu @flachica
[FIX] stock_picking_report_valued: core view change
f241e0c 
- This commit
odoo/odoo@41bea41
breaked the inheritance.
@pedrobaeza @flachica
[IMP] stock_picking_report_valued: Make tests more resilient
c02f263 
In certain conditions of the DB (i.e. integration tests), previous code doesn't assure
the price is going to be 100.
@carlosdauden @flachica
[FIX] stock_picking_report_valued: 6 things:
8b243d1 
[FIX] stock_picking_report_valued: Wrong taxes amount if round globally (OCA#56)

[FIX] stock_picking_report_valued: Remove round_method condition because don't apply here

[FIX] stock_picking_report_valued: price_reduce is stored with product decimal precision

[FIX] stock_picking_report_valued: division_by_zero when unrelated sale order

[FIX] stock_picking_report_valued: Improve code

[FIX] stock_picking_report_valued: Multiple taxes in sale line (WIP)
@ernestotejeda @flachica
[MIG] stock_picking_report_valued: Migration to 12.0
62ff5da
@sergio-teruel @flachica
[IMP] stock_picking_report_valued: black, isort
4fcf76a
@sergio-teruel @flachica
[MIG] stock_picking_report_valued: Migration to v13.0
f604cce
@rousseldenis @flachica
[13.0][FIX] E741 ambiguous variable name 'l'
f96c6e4
@erik-bzcl @flachica
Added translation using Weblate (Romanian)
d5a54ff
@sergio-teruel @flachica
[FIX] stock_picking_report_valued: Make visible valued_picking field …
03fe802 
…in customer
@flachica
[IMP] stock_picking_report_valued: black, isort, prettier
8ed5c04
@oca-clabot
Copy link

Hey @flachica, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@flachica flachica force-pushed the 15.0-mig-stock_picking_report_valued branch 2 times, most recently from 0981494 to 4fe1286 Compare February 24, 2022 08:24
@flachica flachica mentioned this pull request Mar 23, 2022
Closed
13 tasks
@rousseldenis rousseldenis added this to the 15.0 milestone Mar 25, 2022
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration stock_picking_report_valued

extrememicro
extrememicro approved these changes Aug 16, 2022
View reviewed changes
Copy link

@extrememicro extrememicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never liked that tax column order in valued_report_picking header but anyway.... LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

@flachica please rename latest commit message to follow standard guidelines:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message

@flachica flachica force-pushed the 15.0-mig-stock_picking_report_valued branch from 4fe1286 to c45ef8b Compare August 16, 2022 13:58
@flachica
Copy link
Contributor Author

@flachica please rename latest commit message to follow standard guidelines:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message

Sorry. Message was fixed, thanks for your review @pedrobaeza

@pedrobaeza
Copy link
Member

I'm afraid it's still not correct. Please read the link I have put, although as tip it should be something like: [MIG] stock_picking_report_valued: Migration to 15.0

@flachica flachica force-pushed the 15.0-mig-stock_picking_report_valued branch from c45ef8b to 51cca07 Compare August 17, 2022 09:40
@flachica
Copy link
Contributor Author

Done @pedrobaeza

@pedrobaeza
Copy link
Member

Why do you insist with 15.0.1.0.0 instead of 15.0 or v15 that doesn't give an special meaning? And the proper commit message format is [TAG] <module>: ... (with 2 points).

@pedrobaeza
Copy link
Member

I'm merging now as not being critical and don't block this, but please follow strictly guidelines (or didn't you read them?)

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-181-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 469914a into OCA:15.0 Aug 17, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ac93374. Thanks a lot for contributing to OCA. ❤️

@flachica flachica deleted the 15.0-mig-stock_picking_report_valued branch August 17, 2022 09:55
@flachica
Copy link
Contributor Author

Why do you insist with 15.0.1.0.0 instead of 15.0 or v15 that doesn't give an special meaning? And the proper commit message format is [TAG] <module>: ... (with 2 points).

In the guideline I read

"Use tags as listed in the Odoo Guidelines with the following extensions: - [MIG] for migrating a module"

I haven't found anything about how to name the version. And yes, I have seen that the tag issue was included last year. When someone tells me to read something interesting I do it.

@pedrobaeza
Copy link
Member

I find this one referred from OCA guidelines to be very instructive:

imagen

Anyways, it's true that the document contains several incorrect things that I'm fixing in OCA/odoo-community.org#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@extrememicro extrememicro extrememicro approved these changes

@cesar-tecnativa cesar-tecnativa cesar-tecnativa approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet