Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 add shipment plan #4

Merged
merged 67 commits into from
Apr 9, 2015
Merged

Conversation

gurneyalex
Copy link
Member

@yvaucher
Copy link
Member

We lost history from transport_plan there.

@gurneyalex
Copy link
Member Author

@yvaucher: did some git magick to restore that piece of history.

@yvaucher
Copy link
Member

@gurneyalex nice

@yvaucher
Copy link
Member

@gurneyalex According to github diff, it removes .gitignore and license 😟

@yvaucher
Copy link
Member

@gurneyalex Guilt commit is here gurneyalex@c210308

a git commit --fixup might fix it

@gurneyalex
Copy link
Member Author

@yvaucher good catch. One more round of rebase -i and commit --amend fixed this.

@yvaucher
Copy link
Member

👍

@yvaucher yvaucher self-assigned this Apr 1, 2015
@yvaucher
Copy link
Member

yvaucher commented Apr 1, 2015

Setted to work in progress, I will add some enhencements

guewen and others added 8 commits April 2, 2015 10:33
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 8.1.6)
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 8.1.7)
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 8.1.8)
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 8.1.9)
…olumn to transport_mode_id and change the field's type

(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 8.1.10)
  You'll find here the changes on Logistic Requisitions (formerly known as Logistic Requests) specified in the OM-Spec-01 - Logistics Requisition document [0].

  [0] https://docs.google.com/a/camptocamp.com/document/d/1zXZPmZvLPUsZL-85Pd1wJ7yjJwFxUH3sc8Tgm_ueydI
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 9)
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 9.1.1)
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 10)
@yvaucher yvaucher force-pushed the 8.0-add-shipment-plan branch 2 times, most recently from 9dff938 to d870b6e Compare April 2, 2015 11:57
@yvaucher
Copy link
Member

yvaucher commented Apr 7, 2015

👍

def _check_initial_estimated_times(self):
if (self.initial_etd and self.initial_eta and
self.initial_etd > self.initial_eta):
raise Warning(_('Initial ETD cannot be set after initial ETD.'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the documentation [0], if the validation failed, a ValidationError should be raised.

[0] https://www.odoo.com/documentation/8.0/reference/orm.html#openerp.api.constrains

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed (and built in Warning was being raised, not Odoo's exception class...)

)

move_ids = fields.One2many(
compute=lambda rec: True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this computed field?
It is set in defaut_get() so if I understand it is to avoid to create a field in the database?
Deserves at least a comment I think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already in version on stock-logistics-workflow

I created an issue to solve this later #11

@yvaucher
Copy link
Member

yvaucher commented Apr 9, 2015

I merged as it is mostly a move of the module from stock-logistics-workflow

I opened an issue for the last opened point.

ajaniszewska-dev added a commit to ajaniszewska-dev/stock-logistics-transport that referenced this pull request Apr 27, 2022
max3903 pushed a commit to ursais/stock-logistics-transport that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants