-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0 add shipment plan #4
Conversation
ea3c6d5
to
a8a6115
Compare
a8a6115
to
482bd73
Compare
17778c3
to
c48f9d6
Compare
c48f9d6
to
aaad470
Compare
We lost history from transport_plan there. |
aaad470
to
44cdf31
Compare
@yvaucher: did some git magick to restore that piece of history. |
@gurneyalex nice |
@gurneyalex According to github diff, it removes .gitignore and license 😟 |
@gurneyalex Guilt commit is here gurneyalex@c210308 a git commit --fixup might fix it |
44cdf31
to
e49ed2a
Compare
@yvaucher good catch. One more round of |
👍 |
Setted to work in progress, I will add some enhencements |
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 8.1.6)
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 8.1.7)
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 8.1.8)
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 8.1.9)
…olumn to transport_mode_id and change the field's type (/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 8.1.10)
You'll find here the changes on Logistic Requisitions (formerly known as Logistic Requests) specified in the OM-Spec-01 - Logistics Requisition document [0]. [0] https://docs.google.com/a/camptocamp.com/document/d/1zXZPmZvLPUsZL-85Pd1wJ7yjJwFxUH3sc8Tgm_ueydI (/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 9)
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 9.1.1)
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 10)
9dff938
to
d870b6e
Compare
👍 |
def _check_initial_estimated_times(self): | ||
if (self.initial_etd and self.initial_eta and | ||
self.initial_etd > self.initial_eta): | ||
raise Warning(_('Initial ETD cannot be set after initial ETD.')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the documentation [0], if the validation failed, a ValidationError
should be raised.
[0] https://www.odoo.com/documentation/8.0/reference/orm.html#openerp.api.constrains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed (and built in Warning was being raised, not Odoo's exception class...)
d870b6e
to
fe044e6
Compare
) | ||
|
||
move_ids = fields.One2many( | ||
compute=lambda rec: True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this computed field?
It is set in defaut_get()
so if I understand it is to avoid to create a field in the database?
Deserves at least a comment I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already in version on stock-logistics-workflow
I created an issue to solve this later #11
fe044e6
to
9d9ad2d
Compare
If there are undone moves, a popup list them and ask if the user agree to remove them from shipment plan
9d9ad2d
to
e8dd144
Compare
e8dd144
to
056d0ba
Compare
af3e343
to
e8dd144
Compare
I merged as it is mostly a move of the module from stock-logistics-workflow I opened an issue for the last opened point. |
8.0 make it works
depends on