Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] stock_request: Add a "Submitted" state #595

Closed
max3903 opened this issue May 20, 2019 · 9 comments
Closed

[IMP] stock_request: Add a "Submitted" state #595

max3903 opened this issue May 20, 2019 · 9 comments
Assignees
Labels
enhancement stale PR/Issue without recent activity, it'll be soon closed automatically.
Milestone

Comments

@max3903
Copy link
Sponsor Member

max3903 commented May 20, 2019

Requirement

Users from other departments than the Warehouse uses stock requests to specify where products needs to be and when. This can be done from a project task, help desk ticket or field service order. Users may make modifications before the requests get processed by the warehouse team.

Current module

The current module provides the following states: Draft, In Progress, Done, Cancelled.

Change

We would like to add a new state "Submitted" between Draft and In Progress so the other teams can make modifications to their requests before it is submitted and showing up on the radar of the Warehouse team.

What do you think?

@max3903 max3903 added this to the 12.0 milestone May 20, 2019
@max3903 max3903 self-assigned this May 20, 2019
@max3903 max3903 changed the title [IMP] stock_request [IMP] stock_request: Add a "Submitted" state May 20, 2019
@max3903
Copy link
Sponsor Member Author

max3903 commented May 20, 2019

Ping @jbeficent @patrickrwilson @wolfhall

@etobella
Copy link
Member

It's a good option, but could you add a parameter in order to allow this new state? This way we can maintain the old functionality with the new one

@rousseldenis
Copy link
Sponsor Contributor

@max3903 And what about https://github.com/OCA/stock-logistics-warehouse/tree/11.0/stock_request_tier_validation

That is more compliant to your business flow requirement no ?

@max3903
Copy link
Sponsor Member Author

max3903 commented May 21, 2019

@rousseldenis How would you configure it using stock_request_tier_validation? What happens when the user create the stock request?

We would like to hide the draft records to the Warehouse users.

@rousseldenis
Copy link
Sponsor Contributor

We would like to hide the draft records to the Warehouse users.

Ok, maybe misunderstood your requirements.

Do your flow first create request, secondly review request and then submit to warehouse users ?

Is that correct?

@max3903
Copy link
Sponsor Member Author

max3903 commented May 21, 2019

Internal User:

  • create stock requests
  • come back later and modify it.
  • when ready, submit to Warehouse user

Warehouse User:

  • Review submitted requests
  • Make modifications
  • Confirm

There is no review or validation step.

@JordiBForgeFlow
Copy link
Sponsor Member

I would add it as a new state, and through the settings decide if you want to use it.

Something like:
[ ] Allow user to submit stock requests.

In the line that @etobella suggests.

@max3903
Copy link
Sponsor Member Author

max3903 commented May 24, 2019

👍 Thank you. We will work on it. Please expect the pull request to review next week.

max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue May 28, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jun 11, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jun 12, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jun 12, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jun 27, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jun 27, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jun 27, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 9, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 9, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 9, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 11, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 11, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 11, 2019
osi-scampbell pushed a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 12, 2019
osi-scampbell added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 12, 2019
# This is the 1st commit message:

[IMP] Stock Request Order Bypass Submitted

[IMP] stock_request: Add group to bypass submission (OCA#595)

# This is the commit message #2:

[IMP] Flake8

# This is the commit message #3:

[IMP] Migration Script

# This is the commit message #4:

[IMP] Add Direction Functionality
osi-scampbell added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 12, 2019
# This is the 1st commit message:

[IMP] Stock Request Order Bypass Submitted

[IMP] stock_request: Add group to bypass submission (OCA#595)

[IMP] Flake8

[IMP] Migration Script

[IMP] Add Direction Functionality

[IMP] stock_request: Add group to bypass submission (OCA#595)

# This is the commit message #2:

[IMP] Fix Indent

# This is the commit message #3:

[IMP] Expected Date

# This is the commit message #4:

[IMP] Remove Warning Depricated Method Name

# This is the commit message #5:

[IMP] Add Test Location_id Outbound

# This is the commit message #6:

[IMP] Flake8 Line Too Long

# This is the commit message #7:

[IMP] Indent, Expected Date
osi-scampbell added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 12, 2019
[IMP] stock_request: Add group to bypass submission (OCA#595)

[IMP] Flake8

[IMP] Migration Script

[IMP] Add Direction Functionality

[IMP] stock_request: Add group to bypass submission (OCA#595)

[IMP] Fix Indent

[IMP] Expected Date

[IMP] Remove Warning Depricated Method Name

[IMP] Add Test Location_id Outbound

[IMP] Flake8 Line Too Long

[IMP] Indent, Expected Date

[IMP] stock_request: Add group to bypass submission (OCA#595)

[FIX] stock_request_purchase: Travis error
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 16, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 16, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 30, 2019
max3903 added a commit to ursais/stock-logistics-warehouse that referenced this issue Jul 30, 2019
i-vyshnevska pushed a commit to camptocamp/stock-logistics-warehouse that referenced this issue Apr 13, 2020
Signed-off-by pedrobaeza
@github-actions
Copy link

github-actions bot commented Jan 2, 2022

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 2, 2022
@github-actions github-actions bot closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

4 participants