Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] stock_request_picking_type: Use Submitted state #606

Merged
merged 5 commits into from Aug 13, 2019
Merged

[IMP] stock_request_picking_type: Use Submitted state #606

merged 5 commits into from Aug 13, 2019

Conversation

max3903
Copy link
Sponsor Member

@max3903 max3903 commented May 28, 2019 •
edited

@max3903 max3903 added this to the 12.0 milestone May 28, 2019
@max3903 max3903 self-assigned this May 28, 2019
rousseldenis
rousseldenis requested changes May 28, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

Please update module version

@max3903 max3903 requested a review from rousseldenis May 28, 2019 14:20
patrickrwilson
patrickrwilson approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@patrickrwilson patrickrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got now suggested changes.

@max3903 max3903 mentioned this pull request May 31, 2019
Closed
@osi-scampbell osi-scampbell mentioned this pull request Jun 14, 2019
Merged
2 tasks
@max3903
Copy link
Sponsor Member Author

max3903 commented Jun 18, 2019

@osi-scampbell Please implement the onchange method to update the location based on the direction.
See https://github.com/OCA/field-service/blob/a1e3a506d83f922b024d4e0199076a31a54424b5/fieldservice_stock/models/stock.py#L14

@max3903 max3903 force-pushed the 12.0-imp-stock_request_picking_type branch from 7cf2f56 to 3395c09 Compare June 27, 2019 15:18
@max3903 max3903 mentioned this pull request Aug 9, 2019
Merged
1 task
bodedra
bodedra approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Manor Comment:

Please rebase PR branch and make CI happy.

@bodedra bodedra force-pushed the 12.0-imp-stock_request_picking_type branch from 015bf12 to dbf3b36 Compare August 13, 2019 04:21
@bodedra
Copy link
Member

bodedra commented Aug 13, 2019

@max3903 I have taken care of it and make CI happy.

@rousseldenis Could you please update your review ?

@max3903
Copy link
Sponsor Member Author

max3903 commented Aug 13, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Rebased to 12.0-ocabot-merge-pr-606-by-max3903-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit dbf3b36 into OCA:12.0 Aug 13, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 806fe71. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

OCA-git-bot added a commit that referenced this pull request Aug 13, 2019
@OCA-git-bot
Merge PR #606 into 12.0
806fe71 
Signed-off-by max3903
@max3903 max3903 deleted the 12.0-imp-stock_request_picking_type branch August 14, 2019 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodedra bodedra bodedra approved these changes

@patrickrwilson patrickrwilson patrickrwilson approved these changes

@JordiBForgeFlow JordiBForgeFlow Awaiting requested review from JordiBForgeFlow

@etobella etobella Awaiting requested review from etobella

@rousseldenis rousseldenis Awaiting requested review from rousseldenis

@osi-scampbell osi-scampbell Awaiting requested review from osi-scampbell

Assignees

@max3903 max3903

Labels
enhancement merged 🎉 needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@max3903 @bodedra @OCA-git-bot @rousseldenis @patrickrwilson