New module stock_reserve_mrp #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Stock Reserve MRP | ||
| ================= | ||
|
|
||
| This module allows an automatic reserve when the product is finished. |
There was a problem hiding this comment.
Thanks for your contribution.
s/reserve/reservation
[MRG] Upload the module to make automatic reserve finished product
[MRG] - stock_reserve_mrp: Default field: reserve_stock default True
|
Hey @dg-clearcorp, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
| from openerp import models, fields, api | ||
|
|
||
|
|
||
| class mrp_bom(models.Model): |
There was a problem hiding this comment.
in stock.py you use camel case for the class name which is the recommended practise. Can you rename this class to MrpBom?
|
In addition to the notes above, could you:
Thanks for your time |
|
user lost interes, no CLA, old PR -> closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module allows manufacturing orders to reserve stock.