8.0 port module stock_reserve_sale #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think the build is red because of OCA/maintainer-quality-tools#91 👍 |
|
Now the build is still red, but that's just because of a minor lint error. I'll fix it when merging. |
|
I realised I had the right to fix directly. We're green now. Thanks! |
| for line in lines: | ||
| if not line.is_stock_reservable: | ||
| continue | ||
| vals = self._prepare_stock_reservation(line)[0] |
There was a problem hiding this comment.
you can remove the [0] by changing the decorator of the function from api.one to api.multi (use self.ensure_one() at the beginning of the method if needed)
…6. setting base string as unicode didn't solve it
lepistone
force-pushed
the
8.0-stock_reserve_sale
branch
from
d173695
to
0fba1c1
Compare
|
@gurneyalex I addressed your remarks. I also rebased to be able to test, to bring #8 in. Thanks! |
|
👍 |
|
👍 Thanks for the fixes @lepistone |
yvaucher
added a commit
that referenced
this pull request
Oct 3, 2014
8.0 port module stock_reserve_sale
rousseldenis
pushed a commit
to acsone/stock-logistics-warehouse
that referenced
this pull request
Jan 12, 2018
…l_procurement_setup-dro [10.0][FIX] stock orderpoint manual procurement: Add setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes re-factoring with new API
This PR depends on #8 which is merged 😸