8.0 port module stock_reserve #8

yvaucher · 2014-09-03T17:11:32Z

No description provided.

pedrobaeza · 2014-09-03T17:15:21Z

Can't you do this with reserved quants?

yvaucher · 2014-09-04T07:19:06Z

@pedrobaeza Here we want to be able to reserve a quantity of products manually and release them.
It also adds an expiration date on those reservations.

Here we want to be able to reserve some products from a specific location for a specific duration.

…e test pass as it isn't a dependancy.

coveralls · 2014-09-08T13:27:50Z

Coverage remained the same when pulling d593727 on yvaucher:8.0-stock_reserve into af9499e on OCA:8.0.

don't use half the quantity so that the reserved qty is different from available qty

* check that multiple reservations are handled correctly * check that various UOM are handled correctly

coveralls · 2014-09-08T13:59:51Z

Coverage remained the same when pulling 7e81c6c on yvaucher:8.0-stock_reserve into af9499e on OCA:8.0.

test that reservations will trigger orderpoint procurements

coveralls · 2014-09-08T14:48:59Z

Coverage remained the same when pulling 8061ad3 on yvaucher:8.0-stock_reserve into af9499e on OCA:8.0.

fix a bug in the code to make the tests green

gurneyalex · 2014-09-08T15:03:35Z

I've given the addon a good shake, added some tests and fixed an issue found on the way

LGTM 👍

coveralls · 2014-09-08T15:08:54Z

Coverage remained the same when pulling f475283 on yvaucher:8.0-stock_reserve into af9499e on OCA:8.0.

guewen · 2014-09-08T15:11:49Z

stock_reserve/model/product.py

+
+    @api.multi
+    def action_view_reservations(self):
+        assert len(self._ids) == 1, "Expected 1 ID, got %r" % self._ids


Is the assertion necessary with the new api?
Also, if self._ids is a tuple, it will fail the string substitution so it should be put in a tuple (I don't know what self._ids is supposed to be so do not take my remark into account if it is irrelevant).

Please use the official self.ids instead.

in fact shouldn't it be @api.one?

Yeah, it can be, although the meaning maybe it's not the same if he wants to limit the operation to one record each time.

@api.one would return a list of returned results I'll check if it works for an action

Yeah, that's true, so the behaviour changes. It must be this way then

Just tested it, button action calling a method with decorator @api.one does nothing.

maybe this should be reported as an odoo bug, don't you think?

coveralls · 2014-09-08T16:53:55Z

Coverage remained the same when pulling a4e8885 on yvaucher:8.0-stock_reserve into af9499e on OCA:8.0.

nbessi · 2014-09-09T06:48:49Z

Effectivly it looks like a bug:

Decorate a record-style method where `self` is expected to be a 
singleton instance. The decorated method automatically loops on records,
and makes a list with the results. In case the method is decorated 
with  @returns, it concatenates the resulting instances

Maybe action button are explicitly decortated with multi and adding one has no effect. AFAIK there is not mutex test on those decorators.

lepistone · 2014-09-10T15:28:36Z

The discussion on the decorator doesn't seem me to be this module's fault. So 👍, thanks!

lepistone · 2014-09-11T11:59:14Z

Hi @pedrobaeza do you agree it's a problem in odoo and we can merge that one? thanks a lot!

pedrobaeza · 2014-09-11T12:11:39Z

Yeah, sure. 👍

lepistone · 2014-09-11T13:11:44Z

thanks!

8.0 port module stock_reserve

…mpletion_info Rely on stock_move_common_dest as dependency

yvaucher added the needs review label Sep 4, 2014

yvaucher added 9 commits September 8, 2014 15:09

reactivate module stock_reserve

c6d897d

port models and method to api 8.0

292fd2a

port onchanges

d2f0e22

change type to stock.picking.type

d72c566

improve descriptor

b4fe305

improve action_view_reservations from product

e648a37

replace product_qty by product_uom_qty

2cec2e5

fix default_get to ensure product_qty is not set

b664229

some products' fields moved in stock_accout. removing them to make th…

1c131d9

…e test pass as it isn't a dependancy.

gurneyalex force-pushed the 8.0-stock_reserve branch from 97d1cc1 to 1c131d9 Compare September 8, 2014 13:11

fix flake8 warnings

d593727

gurneyalex added 2 commits September 8, 2014 15:29

update test

25c434c

don't use half the quantity so that the reserved qty is different from available qty

more stock_reserve tests

7e81c6c

* check that multiple reservations are handled correctly * check that various UOM are handled correctly

product_reserve: test orderpoint

8061ad3

test that reservations will trigger orderpoint procurements

gurneyalex added 2 commits September 8, 2014 16:54

fix typo in docstring

ea80500

add test for expiration of reservations

f475283

fix a bug in the code to make the tests green

gurneyalex force-pushed the 8.0-stock_reserve branch from b9ca443 to f475283 Compare September 8, 2014 15:00

guewen reviewed Sep 8, 2014
View reviewed changes

fix button to open related move

5b9758b

fix domain using list instead of string

a4e8885

yvaucher force-pushed the 8.0-stock_reserve branch from c53d3fd to a4e8885 Compare September 8, 2014 16:45

gurneyalex mentioned this pull request Sep 9, 2014

new api: button action calling a method with decorator @api.one does nothing odoo/odoo#2270

Closed

This was referenced Sep 10, 2014

8.0 port module stock_reserve_sale #14

Merged

[8.0][API] onchange - read of inherited id erase values odoo/odoo#2325

Closed

lepistone added a commit that referenced this pull request Sep 11, 2014

Merge pull request #8 from yvaucher/8.0-stock_reserve

974953e

8.0 port module stock_reserve

lepistone merged commit 974953e into OCA:8.0 Sep 11, 2014

yvaucher deleted the 8.0-stock_reserve branch September 11, 2014 15:39

guewen added a commit to camptocamp/stock-logistics-warehouse that referenced this pull request Apr 8, 2020

Merge pull request OCA#8 from grindtildeath/13.0-mig-stock_picking_co…

a8245a7

…mpletion_info Rely on stock_move_common_dest as dependency

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8.0 port module stock_reserve #8

8.0 port module stock_reserve #8

yvaucher commented Sep 3, 2014

pedrobaeza commented Sep 3, 2014

yvaucher commented Sep 4, 2014

coveralls commented Sep 8, 2014

coveralls commented Sep 8, 2014

coveralls commented Sep 8, 2014

gurneyalex commented Sep 8, 2014

coveralls commented Sep 8, 2014

guewen Sep 8, 2014

pedrobaeza Sep 8, 2014

guewen Sep 8, 2014

pedrobaeza Sep 8, 2014

yvaucher Sep 8, 2014

pedrobaeza Sep 8, 2014

yvaucher Sep 8, 2014

gurneyalex Sep 9, 2014

coveralls commented Sep 8, 2014

nbessi commented Sep 9, 2014

lepistone commented Sep 10, 2014

lepistone commented Sep 11, 2014

pedrobaeza commented Sep 11, 2014

lepistone commented Sep 11, 2014

8.0 port module stock_reserve #8

8.0 port module stock_reserve #8

Conversation

yvaucher commented Sep 3, 2014

pedrobaeza commented Sep 3, 2014

yvaucher commented Sep 4, 2014

coveralls commented Sep 8, 2014

coveralls commented Sep 8, 2014

coveralls commented Sep 8, 2014

gurneyalex commented Sep 8, 2014

coveralls commented Sep 8, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Sep 8, 2014

nbessi commented Sep 9, 2014

lepistone commented Sep 10, 2014

lepistone commented Sep 11, 2014

pedrobaeza commented Sep 11, 2014

lepistone commented Sep 11, 2014