[9.0] [MIG] stock_inventory_lockdown

[MiquelRForgeFlow]

Standard migration.

[StefanRijnhart]

Thanks! Code reviewed and tested on runbot.

[LoisRForgeFlow]

Functional and technical review 👍

Just to minor (not blocking) things:

• It would be good to update the images of the description, they are v8.
• Squash transifex commits.

[lmignon]

@mreficent IMO we can improve the logic to check for locked locations.... and improve the performances. see my comments. What do you think about?

[lmignon]

@mreficent IMO if would be more efficient to allow to pass a location_ids parameter to this method and t use this paramaterd (if provided) into the domain for the search on inventories...
ex:

 @api.model
 def _get_locations_open_inventories(self, locations_ids = None):
    inventory_domain = [('state', '=', 'confirm')]
    if locations_ids:
        inventory_domain.append(('location_id', 'child_of', location_ids))
    inventories = self.search(inventory_domain)
    location_ids = inventories.mapped('location_id')
    location_domain = [
        ('location_id', 'child_of', location_ids.ids),
        ('usage', 'in', ['internal', 'transit'])]
     if locations_ids:
        location_domain.append(('location_id', 'child_of', location_ids))
    return self.env['stock.location'].search(location_domain)

In this way we will filter the result to the locations for which we want to check if an inventory exist.

[lmignon]

@mreficent With the change proposed for _get_locations_open_inventories the method will be simplified

location_inventory_open_ids = self.env['stock.inventory'].sudo()._get_locations_open_inventories(self.ids)
if location_inventory_open_ids:
    raise ValidationError(...)

[MiquelRForgeFlow]

@lmignon suggestion attended to 😊

[lmignon]

@mreficent This code should be also modified to take advantage of the new paramater on _get_locations_open_inventories

if 'location_id' in vals.keys():
    locked_location_ids = self.env['stock.inventory']._get_locations_open_inventories(
        self.env['stock.location'].browse(vals['location_id']) + self.mapped('location_id')
    )
   if locked_location_ids:
        raise ...

[MiquelRForgeFlow]

But then the raise message will not have explicit locations 😕

[lmignon]

@mreficent

location_names = locked_location_ids.mapped('name')
raise ValidationError(
    _('An inventory is being conducted at the following '
      'location(s):\n%s') % "\n - ".join(location_names))

[lmignon]

@mreficent same comment as above

[lmignon]

Lgtm code review only

[JordiBForgeFlow]

👍 Functional review