Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][MIG] stock_valuation_account_manual_adjustment #371

Conversation

LoisRForgeFlow
Copy link
Contributor

Migration to v10.

@LoisRForgeFlow LoisRForgeFlow force-pushed the 10.0-mig-stock_valuation_account_manual_adjustment branch 5 times, most recently from 6616e38 to 7fb6feb Compare January 26, 2018 13:16
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks.

@rousseldenis
Copy link
Sponsor Contributor

@lreficent Any news on this?

@LoisRForgeFlow
Copy link
Contributor Author

@rousseldenis Sorry I will not work on this at the moment, I will eventually do it but it could be not in the short term...

@LoisRForgeFlow LoisRForgeFlow force-pushed the 10.0-mig-stock_valuation_account_manual_adjustment branch from 59e97dd to e58c0e1 Compare November 14, 2018 16:34
@LoisRForgeFlow
Copy link
Contributor Author

@rousseldenis Sorry, I completely forgot about this 😞 I'm now fixing, see my comments in your review

@LoisRForgeFlow LoisRForgeFlow force-pushed the 10.0-mig-stock_valuation_account_manual_adjustment branch from 6e6c1be to 68a4815 Compare November 14, 2018 16:41
@LoisRForgeFlow
Copy link
Contributor Author

@rousseldenis Could you check my latest comments?

@rousseldenis
Copy link
Sponsor Contributor

@lreficent Can you squash in order to merge this ?

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@LoisRForgeFlow LoisRForgeFlow force-pushed the 10.0-mig-stock_valuation_account_manual_adjustment branch from efba1fc to 9c8ad0a Compare January 2, 2019 10:04
@LoisRForgeFlow LoisRForgeFlow merged commit 4e4e193 into OCA:10.0 Jan 3, 2019
@LoisRForgeFlow LoisRForgeFlow deleted the 10.0-mig-stock_valuation_account_manual_adjustment branch January 3, 2019 11:41
@pedrobaeza pedrobaeza added this to the 11.0 milestone Jan 3, 2019
@pedrobaeza pedrobaeza mentioned this pull request Jan 3, 2019
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants