Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] stock_orderpoint_manual_procurement #557

Merged

Conversation

kittiu
Copy link
Member

@kittiu kittiu commented Mar 16, 2019

Module migrated to v12

@kittiu kittiu changed the title [12.0][MIG] stock_orderpoint_purchase_link [12.0][MIG] stock_orderpoint_manual_procurement Mar 16, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 18, 2019
23 tasks
@rousseldenis rousseldenis added this to the 12.0 milestone Mar 18, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 18, 2019
54 tasks
@LoisRForgeFlow
Copy link
Contributor

@kittiu Please check warnings in runbot logs

@kittiu kittiu force-pushed the 12.0-mig-stock_orderpoint_manual_procurement branch from fd71901 to eefe302 Compare March 29, 2019 04:41
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM 👍

Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bodedra
Copy link
Member

bodedra commented Apr 2, 2019

@kittiu Appreciate your work. IMO we can avoid cosmetic changes on next module migration. 😉 That's not really important on migration. Reference: eefe302#diff-caa1ed47e650d4d52dc2c98f85bee472R99

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittiu Could you amend commit message ?

@kittiu kittiu force-pushed the 12.0-mig-stock_orderpoint_manual_procurement branch from eefe302 to 495f2ba Compare April 3, 2019 08:07
@kittiu
Copy link
Member Author

kittiu commented Apr 3, 2019

@kittiu Could you amend commit message ?

Done

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis rousseldenis merged commit 70f7bf2 into OCA:12.0 Apr 4, 2019
LRovira-PlanetaTIC pushed a commit to PlanetaTIC/stock-logistics-warehouse that referenced this pull request May 15, 2020
Signed-off-by lreficent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants