Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] stock_orderpoint_manual_procurement_uom #558

Merged
merged 5 commits into from Apr 26, 2019
Merged

[12.0][MIG] stock_orderpoint_manual_procurement_uom #558

merged 5 commits into from Apr 26, 2019

Conversation

kittiu
Copy link
Member

@kittiu kittiu commented Mar 16, 2019 •
edited

Migrated to v12

Dependencies

@kittiu kittiu mentioned this pull request Mar 16, 2019
Closed
@rousseldenis rousseldenis added this to the 12.0 milestone Mar 18, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 18, 2019
Closed
54 tasks
@kittiu kittiu mentioned this pull request Mar 21, 2019
Closed
23 tasks
@kittiu
Copy link
Member Author

kittiu commented Apr 2, 2019

Wait for other dependencies to be merged.

@rousseldenis
Copy link
Sponsor Contributor

Wait for other dependencies to be merged.

@kittiu Usually, it's advised to put the link to dependencies (with a checkbox) in the top of the PR to help reviewers going there first.

@LoisRForgeFlow
Copy link
Contributor

This one is ready to be rebased, all dependencies are merged.

@kittiu kittiu force-pushed the 12.0-mig-stock_orderpoint_manual_procurement_uom branch 2 times, most recently from 46ca76a to 4b26157 Compare April 9, 2019 11:49
@kittiu
Copy link
Member Author

kittiu commented Apr 9, 2019

Added more test to pass test check

LoisRForgeFlow
LoisRForgeFlow approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks

tbaden
tbaden suggested changes Apr 25, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work.
I did a code review. just a minor detail.

stock_orderpoint_manual_procurement_uom/__manifest__.py Outdated
"stock_orderpoint_uom",
"stock_orderpoint_manual_procurement",
],
"data": [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you dont use the tag, just delete it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thank you!

@kittiu kittiu force-pushed the 12.0-mig-stock_orderpoint_manual_procurement_uom branch from 4b26157 to 03a7649 Compare April 26, 2019 01:04
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis rousseldenis merged commit 692f43f into OCA:12.0 Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbaden tbaden tbaden approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kittiu @rousseldenis @LoisRForgeFlow @OCA-git-bot @tbaden @oca-travis