Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] stock_orderpoint_uom #568

Merged
merged 18 commits into from Apr 4, 2019
Merged

[12.0][MIG] stock_orderpoint_uom #568

merged 18 commits into from Apr 4, 2019

Conversation

kittiu
Copy link
Member

@kittiu kittiu commented Apr 2, 2019

Migrate to v12

JordiBForgeFlow and others added 17 commits April 2, 2019 09:11
@JordiBForgeFlow @kittiu
[IMP] Several improvements and fixes.
18d86b4
@oca-transbot @kittiu
OCA Transbot updated translations from Transifex
957112b
@LoisRForgeFlow @kittiu
stock_orderpoint_uom: Migrated to 9.0
830146e
@oca-transbot @kittiu
OCA Transbot updated translations from Transifex
3a15a3a
@LoisRForgeFlow @kittiu
Warning deprecated.
3a6aa95
@LoisRForgeFlow @kittiu
[MIG] stock_orderpoint_uom to v10.0
02e6e36
@oca-transbot @kittiu
OCA Transbot updated translations from Transifex
17cdc8a
@LoisRForgeFlow @kittiu
[10.0][FIX] stock_orderpoint_uom: product_uom not stored
7110810
@LoisRForgeFlow @kittiu
move constrain to product
7fdc8a3
@LoisRForgeFlow @kittiu
optimize
09f5725
@oca-transbot @kittiu
OCA Transbot updated translations from Transifex
8da7c5b
@kittiu
[MIG] stock_orderpoint_uom: Migration to 11.0
23d41f1
@grindtildeath @kittiu
Fix UOM conversion, improve tests
578b056
@kittiu
[CHG] website url and improve method
b3a89aa
@oca-travis @kittiu
[UPD] Update stock_orderpoint_uom.pot
0e0aa4f
@oca-travis @kittiu
[UPD] Update stock_orderpoint_uom.pot
3f7a528
@oca-transbot @kittiu
Update translation files
87beede 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@kittiu kittiu mentioned this pull request Apr 2, 2019
Closed
@rousseldenis rousseldenis added this to the 12.0 milestone Apr 2, 2019
@rousseldenis
Copy link
Sponsor Contributor

@kittiu Is it normal you have deleted some .po files ?

@kittiu
Copy link
Member Author

kittiu commented Apr 2, 2019

@kittiu Is it normal you have deleted some .po files ?

Yes, this area I am still unsure what to do. We have to recreated the .pot for v12, right? Can we still keep the old .po files?

@kittiu
Copy link
Member Author

kittiu commented Apr 3, 2019

@rousseldenis I found old OCA mail Weblate.
So, from now we do not need to create .pot or .po file anymore, same for migration? So, we should delete them all and wait for Weblate to recreate?

Important: always translate using Weblate, and never push changes to .po files manually. This simple rule will avoid all merge conflicts, as all .pot file changes are done by Travis, and Weblate is the master of all .po files.
Weblate has an upload feature: use it in case you need to translate outside the Weblate interface for any reason.

@rousseldenis
Copy link
Sponsor Contributor

@kittiu Indeed, Weblate is the tool used to translate OCA modules. But, this is true for new translations. Old po files should be kept on migration flow (as you are not aware easily if those po files were generated by Weblate or through another mean).

@kittiu kittiu force-pushed the 12.0-mig2-stock_orderpoint_uom branch from 9d1a1a6 to 3f94e81 Compare April 3, 2019 06:05
@kittiu
Copy link
Member Author

kittiu commented Apr 3, 2019

@kittiu Indeed, Weblate is the tool used to translate OCA modules. But, this is true for new translations. Old po files should be kept on migration flow (as you are not aware easily if those po files were generated by Weblate or through another mean).

I have moved the translation files from 11.0 to 12.0. The .pot file also as of 11.0.

rousseldenis
rousseldenis approved these changes Apr 3, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM.
@kittiu Could you amend your commit message to keep only '[12.0][MIG] stock_orderpoint_uom' string ?

@kittiu kittiu force-pushed the 12.0-mig2-stock_orderpoint_uom branch from 3f94e81 to b7bfc8f Compare April 3, 2019 06:13
@kittiu
Copy link
Member Author

kittiu commented Apr 3, 2019

Code review. LGTM.
@kittiu Could you amend your commit message to keep only '[12.0][MIG] stock_orderpoint_uom' string ?

Done

@kittiu kittiu mentioned this pull request Apr 3, 2019
Merged
2 tasks
LoisRForgeFlow
LoisRForgeFlow approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for migrating!

@LoisRForgeFlow LoisRForgeFlow merged commit e6ac6be into OCA:12.0 Apr 4, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 30, 2019
Closed
23 tasks
@HviorForgeFlow HviorForgeFlow mentioned this pull request May 20, 2019
Closed
54 tasks
i-vyshnevska pushed a commit to camptocamp/stock-logistics-warehouse that referenced this pull request Apr 13, 2020
@moylop260
Merge pull request OCA#568 from vauxoo-dev/12.0-mig-stock_picking_bac…
2c90fa1 
…korder_strategy

[MIG] stock_picking_backorder_strategy: Migration to 12.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kittiu @rousseldenis @LoisRForgeFlow @OCA-git-bot @JordiBForgeFlow @oca-transbot @grindtildeath @oca-travis