-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][IMP][stock_move_location] Start wizard from inventory dashboard #755
Conversation
1c06d32
to
76ed21e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally tested, works good. 👍
Just one small thing. In the menu Inventory > Configuration > Operation Types I don't see the option "Show moveOn hand Stock" checkbox. I think it would be good to include it there too.
Also, a small margin between buttons like here: #751 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use cherry-pick operation to preserve commit authorship
I would wait a bit until v11 PR is merged to move forward with this one. |
@Joansis can you update this PR? its v11 brother has been merged! |
- The ability to start the wizard from a picking type in the inventory dasbhoard - A toggle to edit the origin and destination locations.
done inline because the same margin is defined in style files for account dashboard, however I don't want to apply the account_kanban class here as it would have more effects.
* fix tests as per latest changes * extend test as per latest changes * add little help in technical fields
9d6e6db
to
cd32b32
Compare
* fix test as per migration * fix inconsistency in reserved quantity for planned transfers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you 👍
/ocabot merge minor |
On my way to merge this fine PR! |
This PR has the |
Congratulations, your PR was merged at cd34135. Thanks a lot for contributing to OCA. ❤️ |
This PR introduces:
This is a migration to v12 of #751
cc ~ @eficent @jbeficent