Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][IMP][stock_move_location] Start wizard from inventory dashboard #755

Merged
merged 6 commits into from
Dec 9, 2019
Merged

[12.0][IMP][stock_move_location] Start wizard from inventory dashboard #755

merged 6 commits into from
Dec 9, 2019

Conversation

JoanSForgeFlow
Copy link
Contributor

This PR introduces:

  • The ability to start the wizard from a picking type in the inventory dashboard. A button "Move On Hand".
  • You can define in the settings of the picking type if you want the button to appear for each picking type.
  • Pickings created using this button will adopt the corresponding picking type.
  • Added toggle to edit the origin and destination locations. By default one cannot edit the origin and destination locations when they press the button from the picking type in the inventory dashboard.

This is a migration to v12 of #751

cc ~ @eficent @jbeficent

@JoanSForgeFlow JoanSForgeFlow force-pushed the 12.0-imp-stock_move_location branch 2 times, most recently from 1c06d32 to 76ed21e Compare November 13, 2019 16:16
@rousseldenis rousseldenis added this to the 12.0 milestone Nov 14, 2019
AaronHForgeFlow
AaronHForgeFlow approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested, works good. 👍

Just one small thing. In the menu Inventory > Configuration > Operation Types I don't see the option "Show moveOn hand Stock" checkbox. I think it would be good to include it there too.

Also, a small margin between buttons like here: #751 (comment)

rousseldenis
rousseldenis approved these changes Dec 3, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM!

LoisRForgeFlow
LoisRForgeFlow requested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use cherry-pick operation to preserve commit authorship

@LoisRForgeFlow
Copy link
Contributor

I would wait a bit until v11 PR is merged to move forward with this one.

@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Dec 5, 2019
Merged
@LoisRForgeFlow
Copy link
Contributor

@Joansis can you update this PR? its v11 brother has been merged!

JordiBForgeFlow and others added 5 commits December 9, 2019 10:45
@JordiBForgeFlow
This commit introduces changes to stock_move_location:
6975f6c 
- The ability to start the wizard from a picking type in the inventory dasbhoard
- A toggle to edit the origin and destination locations.
@JordiBForgeFlow
in planned transfers do not set the qty_done in move lines
39b2b38
@LoisRForgeFlow
[11.0] stock_move_location: add small margin between buttons,
08d6af3 
done inline because the same margin is defined in  style files
for account dashboard, however I don't want to apply the
account_kanban class here as it would have more effects.
@JordiBForgeFlow
display picking type in move location wizard, and get a default value
7fff921
@LoisRForgeFlow
[11.0][IMP] stock_move_location:
cd32b32 
* fix tests as per latest changes
* extend test as per latest changes
* add little help in technical fields
[11.0][FIX] stock_move_location:
ac422a6 
* fix test as per migration
* fix inconsistency in reserved quantity for planned transfers
LoisRForgeFlow
LoisRForgeFlow approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you 👍

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-755-by-lreficent-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 9, 2019
@OCA-git-bot
Merge PR #755 into 12.0
eada107 
Signed-off-by lreficent
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit ac422a6 into OCA:12.0 Dec 9, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cd34135. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 12.0-imp-stock_move_location branch December 9, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
7 participants
@JoanSForgeFlow @LoisRForgeFlow @OCA-git-bot @rousseldenis @AaronHForgeFlow @MiquelRForgeFlow @JordiBForgeFlow